Repository navigation
fix(composer): retain dictation hover while its menu is open - #34606
Conversation
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1fcd01147ccc682ec320
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Passes: CI passes on CI passes on Written by web and size checks: green Shipped in:
|
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1fcd01147ccc682ec320
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (gpt-6.1-sol high): SHIP at 7094ae9
Review (subagent gpt-6.1-sol high): SHIP at 7094ae9
The CSS preserves only the invoking dictation control's existing hover tone, including the running mic accent. The browser-test marker assertion now excludes ContextMenu's hidden host marker, resolving the prior blocker. No code or test regressions found in the correction.
Visual verdict: captures pending; missing captures are a follow-up only. Fleet behavioral results remain pending.
Follow-ups: inspect the light/dark captures when the fleet run returns.
|
Found 1 test failure on Blacksmith runners: Failure
|
|
Visual follow-up (independent subagent gpt-6.1-sol high) at 7094ae9: SHIP. Reviewed the synthetic before/after contact sheet and private reference comparison. Only the invoking mic/Finish control retains its existing hover fill across light/dark states; neighboring controls remain at rest, with no row-wide highlight or movement. The listening waveform/accent treatment is preserved. Capture follow-up closed. |
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (gpt-6.1-sol high): SHIP at ff514a8
Review (subagent gpt-6.1-sol high): SHIP at ff514a8.
Independent reviewer checked the clean base merge against 2fc8c42: the scoped hover patch is unchanged and introduces no integration regression.
Visual verdict: prior light/dark visual SHIP remains applicable to the unchanged hover patch. Only the invoking control stays lit while its menu is open; neighbors stay at rest, without movement.
Follow-ups: none.
|
Owned by an agent session · session |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
This PR changes a hunk marked |
|
Review (subagent claude-opus-5-5 medium): BLOCK at 4650b0b The head commit Its parent |
|
Review (subagent claude-opus-5-5 medium): SHIP at 820e18f Scoped to the change since the passing product review at ff514a8. The tree at 820e18f equals 5b821dd's tree, so the two resync commits net to nothing. The net diff against the merge base (Dictation.gallery.tsx, dictation.css, test/dictation-popup-hover.test.ts; +152) is byte-identical to the reviewed one at ff514a8. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
820e18f to
102fe65
Compare
|
SHIP carried to 102fe65: delta = history rewrite History rewrite: the resync commit 4650b0b had the empty tree (the helper committed from a --no-checkout worktree), and the restore commit 820e18f then failed the fast-gates prepush gate, which judges each commit. I force-pushed the branch, leasing against 820e18f, to 5b821dd plus one empty commit 102fe65 built with |
|
Not merged at 102fe65: blocked on a feat-cmux-next webview red. Net scope against the reviewed parent: Classifier (base copy): fast gates run 41830233606, cmux-next checks run 41830233864 and nightly-guards run 41830234081 are excused (exit 0). gallery health run 41830233690 was refused at first; one rerun of that job passed (attempt 2, success). CI run 41830234107 |
|
SHIP carried to 5c36f6a: delta = base merge (update-branch, merge of feat-cmux-next 3dcd5db, which carries the webview base-red fix #35471) Net scope: the PR's diff against its merge base 3dcd5db (Dictation.gallery.tsx, dictation.css, dictation-popup-hover.test.ts; +152) has |
|
Not merged at 5c36f6a: one base red that the classifier does not excuse. Webview verdict ( Classifier (base copy) on run 41851440771, |
|
Review (subagent claude-opus-5-5 medium): SHIP at 61d735d Carried from 5c36f6a. The delta is a base merge of feat-cmux-next cea84c3 (update-branch), which brings in the nightly-guards fix #35524. The net diff against merge base cea84c3 (3 files, +152) has |
|
Not merged at 61d735d: the classifier refuses gallery health run 41860236635 (health (4)): 'agent-pane.agent-start#slow-start: play threw: layout shift(s) while the agent started (cv-shimmer__row "Writing…")', not on base runs 41861455104, 41858251275, 41856863458, 41856346528. It is the same flaky shimmer CLS that passed on its one allowed rerun at 102fe65. Every other red is excused: nightly-guards (exit 0, same failure on base run 41865097385). Waiting on a decision about a rerun. |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (subagent claude-opus-5-5 medium): SHIP at 9e8a7bf Carried from 85e1f91. The delta is a base merge of feat-cmux-next e01bbae (update-branch), which brings in the webview timeout fix #35839 and the chat-row test fix #35851. The net diff against merge base e01bbae (3 files, +152) has |
|
Not merged at 9e8a7bf. The webview verdict is clear, CI and fast gates are green, and the patch-id is unchanged. The base classifier refuses the remaining reds (see the coordinator report): the gallery-health agent-start shimmer CLS (cmux#35744) and a cmux-next guards infra failure. Parked for a coordinator decision. |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (next-review patch-id; carried): SHIP at 7ba213e Carried from the SHIP at 9e8a7bf (#34606 (comment)). The delta is cmux-bot's base merge of feat-cmux-next fe924c0 (update-branch, 21:40Z). The net diff against merge base fe924c0 has |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Opening Hide Dictation Button now keeps the invoking mic or Finish control at its hover tone until dismissal. Listening dictation preserves its accent. The surrounding row and neighboring controls stay unchanged.
Leo (2026-11-04):
Extends #28861's existing ContextMenu opener marker to the dictation styles introduced in #22713. No new state, timers, observers or animation; on by default, with a one-commit revert.
Design:
leo-workspace/design/composer.mdanddesign/menus.md. Private reference id:claude/live/composer-voice-listening-waveform(preserved active mic accent and quiet Finish control). Gallery:agent-pane.dictation,idle-menu,listening-menu,finish-menu; retained hover is the chosen treatment.Validation at
7094ae981e0bcf70a51940a6780ef7e113ee4437: fleet run 41761893377 passed all 12 browser cases and 14 DictationButton/ContextMenu unit tests. Original CSS failed all 12 retention cases in the same harness. The browser test covers glyph right-click, exact source-only retention, stable bounds and dismissal cleanup. Static prepush gate and changed-file formatting passed.The full web check found four failures outside this diff: design tokens in
pages/changelog/updateSurfaces.css(margin-top: 2px); formatting inApp.tsxandcloudRun.test.ts; lint/typecheck for missingafterintest/transcript-spacing-kinds.test.ts:247(owned by #34577). These files are unchanged from base49d2b6e52cb9494d59ce798689c78ac913533621; the attempted exact-base run 41762865343 returned no command receipt or artifacts, so it does not establish an executed base comparison. The scoped behavior suite is green; the unrelated failures remain source-attributed to unchanged base files.Performance
dictation-popup-hover.test.ts, original vs patched CSS; run 41761893377Screenshots (synthetic, 2×): left before, right after; dark idle/listening/Finish, then light. Private reference was compared locally and is not included here.
🤖 Generated with Codex
Agent session: agent session