Repository navigation
base red: revert 010ffb95c155 (Cloud Tunnel extension does not compile on the macOS 26.5 SDK) - #34198
Conversation
…the macOS 26.5 SDK) The full app build (fleet job a565ad1d55c788476e604c39, feat 7fd3931, Xcode 26.6, MacOSX26.5 SDK, Release arm64 and x86_64) fails: CloudTunnelExtension/PacketTunnelProvider.swift:50:35: error: value of type 'PacketTunnelProvider' has no member 'defaultPath' 010ffb9 added the CloudTunnelExtension target. The eleven commits after it (f973ea6..cc33e08) build on it, so this reverts all twelve, which landed together in one direct push to feat-cmux-next at 19:09Z (ad2c767..cc33e08). The two cmux-wg-tun Rust commits before them (b4f6d32, d2b1b1c) stay: they do not touch the app build. Reverted: 010ffb9 f973ea6 97f41b1 bb65fdb a302e37 6b29137 9665ccf 43b0832 d2d0c58 461bfa8 dcf123c cc33e08. The re-land with the path observation on NWPathMonitor follows in its own PR. Packages/macOS/CmuxNext/ci-target-graph.json is generated; the autofix regenerates it.
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41725013576 at 53bb59f failed: cmux-next web bundles (source-keyed cache). |
|
Full Release app build on the fleet: job |
|
Review (claude-opus-reviewer): SHIP at 288fc62 Independent review (read-only, git at exact SHAs): the PR reverts exactly the 12 commits d2b1b1c..cc33e08. For the 66 files no later commit touched, the diff is byte-identical to the inverse of the series. In Package.swift and SettingsSchema.swift, the later #33215 and #32827 lines are kept. The kept cmux-wg-tun Rust commits are unchanged and stand alone. Non-blocking: the generated ci-target-graph.json keeps stale CmuxNextCloudTunnel entries (the autofix regenerates it), and a comment in cmux-tui/crates/cmux-wg-tun/Cargo.toml:14 names the removed build-wg-tun.sh. Note on the tier: the bot set risk:high because the reverted files include entitlements and signing scripts. This receipt plus a green full build is the evidence that tier needs. |
|
Full Release app build at the exact head 288fc62 is green: fleet job |
…evert (#34271) #34198 (8048d4f) reverted 010ffb9, which removed nightly.yml's 'Prepare the Cloud Tunnel extension' step. Its registry entry from #34201 stayed, so test_nightly_step_coverage reports it as stale and 'Validate every nightly step has a pull request counterpart' is red on feat-cmux-next. A re-land of the step re-adds the entry. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…o longer offers) (#34505) 3d978ec (lawrencecchen, direct push 00:29Z) added cloud help rows for `tunnel on`, `tunnel off` and `tunnel status`. The Cloud Tunnel actions were reverted in #34198, and the base autofix ca66a4c (22:54Z) had already removed them from plans/cmux-next/action-surfaces.json. So at the tip cli::cloud_help::tests::help_lists_exactly_the_offered_cloud_verbs fails: "cloud help lists verbs the catalog no longer offers: [tunnel off, tunnel on, tunnel status]" (fleet step fcedf354570a0ebf13c21dcd at 4f13a23). The re-land #34262 brings the tunnel verbs back as `tunnel-on`, `tunnel-off` and `tunnel-status`, with their help rows, at the same time as the actions.
Summary
The full app build of
feat-cmux-nextis red. Fleet joba565ad1d55c788476e604c39(feat 7fd3931, Xcode 26.6, MacOSX26.5 SDK, Release, arm64 and x86_64) fails:010ffb95c155added theCloudTunnelExtensiontarget. It came in one direct push tofeat-cmux-nextat 19:09Z (ad2c76731f28..cc33e089376e, 14 commits, no PR). The 11 commits after it build on it, so this PR reverts all 12 (010ffb95c155..cc33e089376e). The twocmux-wg-tunRust commits before them (b4f6d32a9a37,d2b1b1c70ac5) stay; they do not change the app build.Team rule: revert first, re-land with the fix second. The re-land (path observation on
NWPathMonitor) follows in its own PR.Packages/macOS/CmuxNext/ci-target-graph.jsonis generated; the autofix regenerates it (no hand edit).Takes back the direct push
010ffb95c155..cc33e089376e(no PR number): its extension does not compile on the macOS 26.5 SDK, which makes every full app build red.Changelog
none
Testing
python3 scripts/cmux-next/prepush-gate.py: no new violations.Observed / Not run
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Reverts the Cloud Tunnel extension push that broke every full app build on
feat-cmux-next—PacketTunnelProviderreferencesdefaultPath, which doesn't exist on the macOS 26.5 SDK.CloudTunnelExtensiontarget, theCmuxNextCloudTunnelpackage and its tests, the cloud tunnel settings, CLI verbs, and signing/CI scripts, plus the design doc and arch exceptions.cmux-wg-tunRust commits, which don't touch the app build.NWPathMonitor-based path observation follows in a separate PR.Written for commit 288fc62. Summary will update on new commits.