Skip to content

base red: revert 010ffb95c155 (Cloud Tunnel extension does not compile on the macOS 26.5 SDK) - #34198

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red-tunnel-revert
Nov 3, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red-tunnel-revert

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The full app build of feat-cmux-next is red. Fleet job a565ad1d55c788476e604c39 (feat 7fd3931, Xcode 26.6, MacOSX26.5 SDK, Release, arm64 and x86_64) fails:

CloudTunnelExtension/PacketTunnelProvider.swift:50:35: error: value of type 'PacketTunnelProvider' has no member 'defaultPath'

010ffb95c155 added the CloudTunnelExtension target. It came in one direct push to feat-cmux-next at 19:09Z (ad2c76731f28..cc33e089376e, 14 commits, no PR). The 11 commits after it build on it, so this PR reverts all 12 (010ffb95c155..cc33e089376e). The two cmux-wg-tun Rust commits before them (b4f6d32a9a37, d2b1b1c70ac5) stay; they do not change the app build.

Team rule: revert first, re-land with the fix second. The re-land (path observation on NWPathMonitor) follows in its own PR.

Packages/macOS/CmuxNext/ci-target-graph.json is generated; the autofix regenerates it (no hand edit).

Takes back the direct push 010ffb95c155..cc33e089376e (no PR number): its extension does not compile on the macOS 26.5 SDK, which makes every full app build red.

Changelog

none

Testing

  • python3 scripts/cmux-next/prepush-gate.py: no new violations.
  • Full Release app build on the fleet: see the comment with the job ID.

Observed / Not run

  • Observed: the prepush gate; the fleet build result (comment).
  • Not run: Swift package tests (the revert only removes code and tests).

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Reverts the Cloud Tunnel extension push that broke every full app build on feat-cmux-next — PacketTunnelProvider references defaultPath, which doesn't exist on the macOS 26.5 SDK.

  • Removes the CloudTunnelExtension target, the CmuxNextCloudTunnel package and its tests, the cloud tunnel settings, CLI verbs, and signing/CI scripts, plus the design doc and arch exceptions.
  • Keeps the two cmux-wg-tun Rust commits, which don't touch the app build.
  • A re-land with a NWPathMonitor-based path observation follows in a separate PR.

Written for commit 288fc62. Summary will update on new commits.

View guided diff Turn on auto-fix

…the macOS 26.5 SDK)

The full app build (fleet job a565ad1d55c788476e604c39, feat 7fd3931,
Xcode 26.6, MacOSX26.5 SDK, Release arm64 and x86_64) fails:

  CloudTunnelExtension/PacketTunnelProvider.swift:50:35: error: value of type
  'PacketTunnelProvider' has no member 'defaultPath'

010ffb9 added the CloudTunnelExtension target. The eleven commits after it
(f973ea6..cc33e08) build on it, so this reverts all twelve, which landed
together in one direct push to feat-cmux-next at 19:09Z (ad2c767..cc33e08).
The two cmux-wg-tun Rust commits before them (b4f6d32, d2b1b1c) stay: they
do not touch the app build.

Reverted: 010ffb9 f973ea6 97f41b1 bb65fdb a302e37
6b29137 9665ccf 43b0832 d2d0c58 461bfa8 dcf123c
cc33e08.

The re-land with the path observation on NWPathMonitor follows in its own PR.
Packages/macOS/CmuxNext/ci-target-graph.json is generated; the autofix regenerates it.
@cursor

cursor Bot commented Nov 3, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 288fc62: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34198 -f ref=base-red-tunnel-revert -f platform=macos -f backend_mode=local

Shipped in:

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41725013576 at 53bb59f failed: cmux-next web bundles (source-keyed cache).
Those jobs last passed at c874cb9. This pull request is one of 2 merged since: #34198, #34260.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Full Release app build on the fleet: job dc9c961cbb359b582458cbd3 at 288fc62ba1568e242838b5974fa3cb72bf376761 (tag base-red-tunnel-revert-v1). Result follows. Forward-fix alternative: #34204.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (claude-opus-reviewer): SHIP at 288fc62

Independent review (read-only, git at exact SHAs): the PR reverts exactly the 12 commits d2b1b1c..cc33e08. For the 66 files no later commit touched, the diff is byte-identical to the inverse of the series. In Package.swift and SettingsSchema.swift, the later #33215 and #32827 lines are kept. The kept cmux-wg-tun Rust commits are unchanged and stand alone. Non-blocking: the generated ci-target-graph.json keeps stale CmuxNextCloudTunnel entries (the autofix regenerates it), and a comment in cmux-tui/crates/cmux-wg-tun/Cargo.toml:14 names the removed build-wg-tun.sh.

Note on the tier: the bot set risk:high because the reverted files include entitlements and signing scripts. This receipt plus a green full build is the evidence that tier needs.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Full Release app build at the exact head 288fc62 is green: fleet job dc9c961cbb359b582458cbd3 is done ('Build complete.', 0 compiler errors). The SHIP receipt for this head is above. The red 'backend migrations applied' shows 'migration plan cancelled', and the PR touches no backend file, so I reran it. The other cancelled runs were replaced by green runs after the body edit.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 3, 2026
@lawrencecchen
lawrencecchen merged commit 8048d4f into feat-cmux-next Nov 3, 2026
227 of 241 checks passed
@lawrencecchen
lawrencecchen deleted the base-red-tunnel-revert branch November 3, 2026 21:40
teamleaderleo added a commit that referenced this pull request Nov 3, 2026
…evert (#34271)

#34198 (8048d4f) reverted 010ffb9, which removed nightly.yml's
'Prepare the Cloud Tunnel extension' step. Its registry entry from #34201
stayed, so test_nightly_step_coverage reports it as stale and
'Validate every nightly step has a pull request counterpart' is red on
feat-cmux-next. A re-land of the step re-adds the entry.


Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Nov 4, 2026
…o longer offers) (#34505)

3d978ec (lawrencecchen, direct push 00:29Z) added cloud help rows for
`tunnel on`, `tunnel off` and `tunnel status`. The Cloud Tunnel actions were
reverted in #34198, and the base autofix ca66a4c (22:54Z) had already removed
them from plans/cmux-next/action-surfaces.json. So at the tip
cli::cloud_help::tests::help_lists_exactly_the_offered_cloud_verbs fails:
"cloud help lists verbs the catalog no longer offers: [tunnel off, tunnel on,
tunnel status]" (fleet step fcedf354570a0ebf13c21dcd at 4f13a23).

The re-land #34262 brings the tunnel verbs back as `tunnel-on`, `tunnel-off` and
`tunnel-status`, with their help rows, at the same time as the actions.
lawrencecchen added a commit that referenced this pull request Nov 4, 2026
…nel revert #34198; the tree pixel-perfect's Release film build 948b6ff3 was made from, scratch 63b290e)

This branch was previously deployed

3 inactive deployments
artifacts — 288fc62b Deployed Nov 3, 2026 by lawrencecchen via publish tree-addressed cmux-tui #107460
sentry-dsyms — 288fc62b Deployed Nov 3, 2026 by lawrencecchen via upload cmux-tui dSYMs to Sentry #107460
ci-routing-agent — 288fc62b Deployed Nov 3, 2026 by lawrencecchen via namespace autofix #13569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:high Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant