Repository navigation
base red: revert 3d978ecd7da (cloud help lists tunnel verbs the catalog no longer offers) - #34505
Conversation
…o longer offers) 3d978ec (lawrencecchen, direct push 00:29Z) added cloud help rows for `tunnel on`, `tunnel off` and `tunnel status`. The Cloud Tunnel actions were reverted in #34198, and the base autofix ca66a4c (22:54Z) had already removed them from plans/cmux-next/action-surfaces.json. So at the tip cli::cloud_help::tests::help_lists_exactly_the_offered_cloud_verbs fails: "cloud help lists verbs the catalog no longer offers: [tunnel off, tunnel on, tunnel status]" (fleet step fcedf354570a0ebf13c21dcd at 4f13a23). The re-land #34262 brings the tunnel verbs back as `tunnel-on`, `tunnel-off` and `tunnel-status`, with their help rows, at the same time as the actions.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Review (claude-opus-reviewer): SHIP at 7e7eb6d Independent review (read-only). The commit is the exact inverse of 3d978ec: after it, both files have the same blobs as at 3d978ec^. The base catalog offers 59 cloud verbs and the help now lists the same 59, so none are missing, stale or listed twice. Before this PR, the 3 stale verbs were tunnel on, off and status. TARGETLESS is consistent. Nothing else in cmux-tui needs the removed rows. |
Summary
The tip is red in cmux-tui:
cli::cloud_help::tests::help_lists_exactly_the_offered_cloud_verbsfails with "cloud help lists verbs the catalog no longer offers: [tunnel off, tunnel on, tunnel status]" (fleet stepfcedf354570a0ebf13c21dcdat 4f13a23).Culprit: 3d978ec (lawrencecchen, direct push at 00:29Z, no PR). It added cloud help rows for the Cloud Tunnel verbs. Those actions were reverted in #34198, and the base autofix ca66a4c (22:54Z) had already removed them from
plans/cmux-next/action-surfaces.json, so the rows name verbs the catalog no longer offers.This reverts 3d978ec. The re-land #34262 brings the verbs back as
tunnel-on,tunnel-offandtunnel-status(the two-word CLI rule), with their help rows, at the same time as the actions.Takes back 3d978ec (direct push, no PR number): its rows name actions that are not in the catalog.
Changelog
none
Testing
cmux-tui-rust-check.sh test cli::cloud_help::at the tip (red,fcedf354570a) and at this head (comment).python3 scripts/cmux-next/prepush-gate.py: no new violations.Observed / Not run