Skip to content

base red: revert 3d978ecd7da (cloud help lists tunnel verbs the catalog no longer offers) - #34505

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red-cloud-help-tunnel
Nov 4, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red-cloud-help-tunnel

Conversation

@lawrencecchen

Copy link
Copy Markdown
Contributor

Summary

The tip is red in cmux-tui: cli::cloud_help::tests::help_lists_exactly_the_offered_cloud_verbs fails with "cloud help lists verbs the catalog no longer offers: [tunnel off, tunnel on, tunnel status]" (fleet step fcedf354570a0ebf13c21dcd at 4f13a23).

Culprit: 3d978ec (lawrencecchen, direct push at 00:29Z, no PR). It added cloud help rows for the Cloud Tunnel verbs. Those actions were reverted in #34198, and the base autofix ca66a4c (22:54Z) had already removed them from plans/cmux-next/action-surfaces.json, so the rows name verbs the catalog no longer offers.

This reverts 3d978ec. The re-land #34262 brings the verbs back as tunnel-on, tunnel-off and tunnel-status (the two-word CLI rule), with their help rows, at the same time as the actions.

Takes back 3d978ec (direct push, no PR number): its rows name actions that are not in the catalog.

Changelog

none

Testing

  • Fleet cmux-tui-rust-check.sh test cli::cloud_help:: at the tip (red, fcedf354570a) and at this head (comment).
  • python3 scripts/cmux-next/prepush-gate.py: no new violations.

Observed / Not run

  • Observed: the red at the tip; the result at the head in the comment.
  • Not run: the full cmux-tui test suite.

…o longer offers)

3d978ec (lawrencecchen, direct push 00:29Z) added cloud help rows for
`tunnel on`, `tunnel off` and `tunnel status`. The Cloud Tunnel actions were
reverted in #34198, and the base autofix ca66a4c (22:54Z) had already removed
them from plans/cmux-next/action-surfaces.json. So at the tip
cli::cloud_help::tests::help_lists_exactly_the_offered_cloud_verbs fails:
"cloud help lists verbs the catalog no longer offers: [tunnel off, tunnel on,
tunnel status]" (fleet step fcedf354570a0ebf13c21dcd at 4f13a23).

The re-land #34262 brings the tunnel verbs back as `tunnel-on`, `tunnel-off` and
`tunnel-status`, with their help rows, at the same time as the actions.
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 7e7eb6d: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34505 -f ref=base-red-cloud-help-tunnel -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (claude-opus-reviewer): SHIP at 7e7eb6d

Independent review (read-only). The commit is the exact inverse of 3d978ec: after it, both files have the same blobs as at 3d978ec^. The base catalog offers 59 cloud verbs and the help now lists the same 59, so none are missing, stale or listed twice. Before this PR, the 3 stale verbs were tunnel on, off and status. TARGETLESS is consistent. Nothing else in cmux-tui needs the removed rows.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Fleet cmux-tui-rust-check.sh test cli::cloud_help:: (Linux, Blacksmith) at the head 7e7eb6d is green: step c6f69184949c9008f2f0ea3d, including help_lists_exactly_the_offered_cloud_verbs. The tip red is step fcedf354570a0ebf13c21dcd at 4f13a23.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 4, 2026
@lawrencecchen
lawrencecchen merged commit 6615e63 into feat-cmux-next Nov 4, 2026
196 of 199 checks passed
@lawrencecchen
lawrencecchen deleted the base-red-cloud-help-tunnel branch November 4, 2026 01:50

This branch was previously deployed

3 inactive deployments
ci-routing-agent — 7e7eb6df Deployed Nov 4, 2026 by github-actions[bot] via cmux-next macOS placement #67989
artifacts — 7e7eb6df Deployed Nov 4, 2026 by lawrencecchen via publish tree-addressed cmux-tui #108495
sentry-dsyms — 7e7eb6df Deployed Nov 4, 2026 by lawrencecchen via upload cmux-tui dSYMs to Sentry #108495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant