Repository navigation
test determinism: the idle-probe test's setTimeout calls are its input, not a sleep (base red after #34155) - #34259
Conversation
…t, not a sleep #34155 (755e54b) added webviews/test/agent-pane-idle-probe.test.ts, whose two window.setTimeout(() => undefined, 5) calls are what idleProbe counts. The gate read them as sleep-then-assert and turned 'Validate test determinism gate' red on feat-cmux-next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
Owned by an agent session · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next page strings generate; base red: the same failure on the base 43c9bee; does not block Shipped in:
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41725135574 at f3a4bab failed: cmux-next checks (god files, concurrency, crash safety, l10n), cmux-next web bundles (source-keyed cache). |
|
Review (subagent claude-opus-5-5 medium): SHIP at 352904b |
Base red fix:
cmux-next CI guard group→workflow-guard-tests / quality-determinism: Validate test determinism gateis red on feat-cmux-next, for example https://github.com/manaflow-ai/cmux/actions/runs/41722291773:#34155 (755e54b) added that test. These two calls don't make the test wait for state. They are what
idleProbecounts: the test asserts the probe saw exactly 2 timeouts and restoredsetTimeout. That makes the finding a false positive, so the file gets an allowlist line with that reason. Nothing in the test is changed.Tests:
python3 scripts/check-test-determinism.pyon the fleet (cmux-ci test).Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the determinism check that went red on
feat-cmux-nextafter #34155 added the idle-probe test. The twosetTimeoutcalls the gate flagged aren't sleeps — they're the inputidleProbecounts, so the test asserts on them. Adds an allowlist entry with that reason; no test code changes.Written for commit 352904b. Summary will update on new commits.