Repository navigation
gallery shift: the folder search field keeps its height; the commit form's scope line keeps its size - #33901
gallery shift: the folder search field keeps its height; the commit form's scope line keeps its size#33901teamleaderleo wants to merge 4 commits into
Conversation
…orm's scope line keeps its size The folder popover is a flex column with a max height (#26536), so a long project list squeezed its search field by about 8 px; a search that shortened the list let it grow back and moved every row under it (agent-pane.composer-context#repo-worktrees-search, a base red at 0.0070 over 0.00447). The field no longer shrinks. The commit form's hint line now stacks both scope hints in one cell and keeps Include new files in place (hidden while Staged is picked), so picking a scope never changes its height and the content under the form never moves. Shift rows lowered to what the fixed tree measures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules Gallery before/after for
States
Pick other states with a |
GitHub Actions
Inactive
|
Owned by an agent session · session |
|
Review (subagent claude-opus-5-5 medium, correctness): SHIP at 6744037 |
|
Found 4 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Its second ArrowDown highlights the cmux row below the list's fold, and the list scrolls it into view. With the search field at its full height the list is 8 px shorter, so that scroll is 14 px instead of 3 px (0.00536 against 0.00106). It is the list scrolling to the highlighted row, not a layout shift, so the row follows it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
GitHub Actions
Inactive
|
Review (subagent claude-opus-5-5 medium, correctness): SHIP at ae14032 |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
teamleaderleo
left a comment
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (next-review patch-id; carried, since=20261103T152618Z): SHIP at 1a78c84
The independent SHIP at ae14032 carries to this head: the PR's own change (git diff $(git merge-base feat-cmux-next HEAD) HEAD) has the same git patch-id --verbatim (dc4e5846c787c327) at both heads, and no merge between them was resolved by hand. Nothing new to review. A newer BLOCK, or any change to the PR's own diff, ends the carry.
…r height In a short pane the field used to give up its height to the list so a whole project row fit under the pinned actions (composer-location-strip.test.ts); flex: none alone failed that test. The field there is now a fixed 6 px shorter with no bottom margin: the row still fits, and the field no longer changes height with the list. The gallery frame for these states is a short pane. repo-worktrees-open and lane-checkouts-open go back to their base rows (0.01305 and 0.00143 measured, both twice). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Review (subagent claude-opus-5-5 medium, correctness): SHIP at 719cdb7 |
|
Superseded by #32836 (merged as ee78bc6). It landed the same two fixes: the folder search field no longer shrinks ( |
Base red on
feat-cmux-next: gallery health's layout-shift budgets foragent-pane.composer-context#repo-worktrees-search(0.0070 over its 0.00447 row) andagent-pane.changes-git-actions#include-new/#keyboard(0.0570 over 0.02985), reproduced on base in the replay at #33809 (comment). Leo's standing rule is no layout shift, so this stops the shift instead of raising the rows.Folder search field (repo-worktrees-search). The folder popover has been a flex column with a max height since #26536. A long project list squeezed the search field (an
<input>, so it may shrink) by about 8 px; typing a search shortened the list, the field grew back, and every row under it moved down. The field is nowflex: none. In a short pane (260 px or less, which is also the gallery's 180 px frame for these states) the squeeze was what let a whole project row fit under the pinned actions (composer-location-strip.test.ts). There the field now has a fixed height 6 px shorter, with no bottom margin, so the row still fits and the field never changes height with the list. The size of the shift depended on how far the list overflowed, so the score also moved run to run on the same tree (0.00443 and 0.00699 on base); with the fix it is 0.00014 every time.Commit form (changes-git-actions). The 0.0570 came from the inline scope row that #33796 has since split (it landed after the replay's base, so tip already scores 0 in the gallery). The hint line under the scope still changed height: All's longer hint plus Include new files wraps where Staged's short hint does not, which pushes down whatever sits under the form in the app. Both hints now share one grid cell and Include new files keeps its place while Staged is picked (
visibility: hidden, so it is out of the tab order and accessibility tree, and disabled). The variants'layoutShiftMax: 0.05allowances are gone.Shift rows for these states come down to what the fixed tree measures (rows only go down).
Overlap: #32836 (open, conflicting) reserves the same commit-form space on the old one-row layout, bundled with menu fades; this applies the idea to the layout #33796 landed.
Performance
Same harness, same runner, run twice per arm without retries (
gallery-matrix/health.ts --retries 0over the component frames). Base6dedb9cc163fagainst the first head (run https://github.com/manaflow-ai/cmux/actions/runs/41646133443); the final head re-measured in https://github.com/manaflow-ai/cmux/actions/runs/41670524470 and its follow-up run, andcomposer-location-strip.test.tspasses 37/37 there.new-tab#suggestions-sessionandsubagent-split-pair#defaultshowed as reds in this PR's gallery health. A same-runner replay of base201216c52796and this branch (run https://github.com/manaflow-ai/cmux/actions/runs/41668766616) scores suggestions-session 0.00966 to 0.01916 on both, so it is flaky on base. The split pair's ready-time budget is red on base and renders nothing this PR touches.Risk: low. Two CSS rules and one render change in the commit form; no behaviour change beyond where the elements sit.
Agent session: agent session
🤖 Generated with Claude Code