Repository navigation
Project picker: pin actions beneath search and keep scrollbars inside menus - #26536
Conversation
|
Bead |
|
Found 3 test failures on Blacksmith runners: Failures
|
|
Owned by an agent session · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; base red: the same failure on the base 52145fe; does not block Gallery before/after for
States
Pick other states with a |
d70b874 to
ceade04
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…ject-picker-actions # Conflicts: # webviews/test/new-tab-no-entry-classic.test.ts
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40675011262 at c0d504c failed: cmux-next checks (god files, concurrency, crash safety, l10n). |
|
Shipped in:
|
- empty-state#search: #26536 keeps the pinned project actions above the results while searching; the play counts the filtered results. - computer-use-preview#close: the fixture's shell took 100% of a stage root with no height (0 px) and its overflow clip hid the card from the click; it takes the stage viewport. - narrow#model-menu: the composer's look dots, invisible until hovered, lay over the quiet row's Model and mode chips at most widths under 480 px and took their clicks. They now stand aside (hidden) while they overlap a control of the row, measured by a ResizeObserver. - transcript-view#chat-menu: #29920 moved Delete into the chat menu; the stage is tall enough for the full menu, one more row still fails it. - transcript-view#verbose: the submenu pick waits for the submenu to rest before clicking a row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
…ter-use close, narrow model menu, transcript view) (#30960) * gallery: diagnostics for the gallery health base reds (temporary) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * gallery: computer-use preview fixture takes the stage's height; more diagnostics (temporary) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * base red: gallery health agent-pane states - empty-state#search: #26536 keeps the pinned project actions above the results while searching; the play counts the filtered results. - computer-use-preview#close: the fixture's shell took 100% of a stage root with no height (0 px) and its overflow clip hid the card from the click; it takes the stage viewport. - narrow#model-menu: the composer's look dots, invisible until hovered, lay over the quiet row's Model and mode chips at most widths under 480 px and took their clicks. They now stand aside (hidden) while they overlap a control of the row, measured by a ResizeObserver. - transcript-view#chat-menu: #29920 moved Delete into the chat menu; the stage is tall enough for the full menu, one more row still fails it. - transcript-view#verbose: the submenu pick waits for the submenu to rest before clicking a row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-bot[bot] <348531757+cmux-bot[bot]@users.noreply.github.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Project actions stay directly below Search projects and above the results. Only the project list scrolls; its thumb is inside the menu, and pressing or dragging it keeps the menu open. Shared Combobox behavior also keeps long environment and unpinned folder lists scrollable. In a short pane, actions and results each retain a usable scroll area.
Leo, word for word:
The pinned actions remain keyboard reachable. Typing a project name or path highlights the matching project both visually and through aria-activedescendant, so Enter selects it; ArrowDown and ArrowRight still expand a repository's worktrees. Escape from a focused action closes the menu and returns focus to its trigger. Menus open without an entrance fade. The visual reference is cmux-design-references/apps/claude/live/NOTES.md for its project/environment popover; this keeps cmux's existing colours and glass.
Reviewed head: 6781b5f. Reconciled base: 52145fe. Independent Astra review: SHIP at that head. Focused Chromium: 5/5 short-pane, hint, and long-list geometry cases pass. The short English, German and French hint cases were red before the final CSS cascade repair (9 px of padding and border squeezed a 16 px line) and green after. The broader composer-location/New Tab browser run was 37 pass / 3 fail; those same three failures reproduce at the exact base with identical measurements (two New Tab strip gaps of 78.390625 px and one footer-rim 18% to 28% change). Web lint, fixed-wait check, scoped formatting and pre-push gate pass. The exact-head Linux gallery build and eight-state Chromium capture completed; this change is web-only.
Before captures are from the older base used when the PR began. After captures below are from the final reviewed head, at the same 720 px menu width:
The final-head Chromium gallery also captures a 560 px pane with 40 projects and 180 px panes with private-folder hints. The hints are intentionally ellipsized horizontally in a short pane while their line stays fully visible vertically and a project row remains usable.
Agent session: agent session