Skip to content

base red: the fold-stream upward-anchor trace starts off the very bottom (#32644 fix forward) #33135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmux-bot merged 2 commits into from
Nov 3, 2026
Merged

base red: the fold-stream upward-anchor trace starts off the very bottom (#32644 fix forward) #33135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
668ba6c
base red: the fold-stream trace starts off the very bottom (#32644 fi…
teamleaderleo Nov 3, 2026
eece95f
test(transcript): upward-anchor fold trace starts off the end determi…
teamleaderleo Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions webviews/test/transcript-upward-anchor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,24 @@ await requireBrowserLane("transcript-upward-anchor.test.ts", async () => {
await page.evaluate(() => (window as unknown as { __seedFoldStream(): void }).__seedFoldStream());
const card = page.locator('[data-row-id="gap-incoming"]');
await card.waitFor();
// Fonts settle before the card is placed, so its rows keep their measured height.
await page.evaluate(() => document.fonts.ready);
await card.evaluate((node) => node.scrollIntoView({ block: "start" }));
// Off the very bottom: the card sits in the last turns, so scrolling it to the top lands at
// the physical end, and there opening a line pushes the text above it up (#32644, Leo
// 2026-11-02: "YOU EXPAND UP WHILE YOUR SCCROLL IS AT THE VERY BOTTOM ... JUST THAT CASE").
// This trace is about a fold that keeps its place while the reply streams, so start at least
// 48px up. Whether scrollIntoView lands on the end depended on timing (base runs read 128 to
// 136 compared frames), so the start is pinned here: never further down than end - 48, and
// never further down than where scrollIntoView put the card, so the card stays in view.
const fromEnd = await page.locator(".acpmux-scroll").evaluate(async (node) => {
node.scrollTop = Math.max(0, Math.min(node.scrollTop, node.scrollHeight - node.clientHeight - 48));
node.dispatchEvent(new Event("scroll"));
await window.cmuxPaintFrame();
await window.cmuxPaintFrame();
return node.scrollHeight - node.clientHeight - node.scrollTop;
});
expect(fromEnd).toBeGreaterThan(8);
const result = await page.evaluate(traceUpwardAnchors, {
steps: Array.from({ length: 112 }, () => 0),
foldStream: true,
Expand Down
Loading