Repository navigation
base red: a new tab group nobody coloured has color none (TabSelectionActionsTests, after #32198) - #33095
Conversation
…32198 made it thePaletteGroupsTheSameSelectedTabs failed at TabSelectionActionsTests.swift:85 (color "none", expected "grey"). #32156 made tabGroup.create send grey and added this check; #32198 then made every group created without a colour store none (the daemon's cmux-tui state test expects none, and tabGroup.create sends GroupTint.noneWire), so no dot or underline shows. #32198 did not update this check. The product is right (Leo 2026-10-31: 'WHY DOES THIS HAVE A LINE AND COLOR'); the check now asks for none. Culprit: 3a5b96c (#32198), over 4816325 (#32156). Red: fleet job 2bf90b6c18ca136f3fb6c15d at feat 11dfe91.
|
Found 6 test failures on Blacksmith runners: Failures
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 6b31a88 to compare; do not merge until green; see lane-rules Shipped in:
|
|
Review (independent review subagent, Opus 5.5 claude-opus-5-5, read-only): SHIP at 220df77
|
|
Correction to my review receipt above: the lanes were red overall because of the test-bundle run-loop guard, which held the main thread in xctest. It was not the macOS AddressBook store; that was only a symptom. #33023 and #33013 fixed it on feat (ecfbb44). This head is older than that fix, so its lane still shows the XCTest stage red. The suite's own result (passes at this head, fails at the tip) is unchanged. No action is needed on this PR. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Base red on feat-cmux-next:
CmuxNextAppTests.TabSelectionActionsTests.thePaletteGroupsTheSameSelectedTabsfails at TabSelectionActionsTests.swift:85 (color"none", expected"grey").Cause: #32156 (4816325) made
tabGroup.createsend grey and added this check. #32198 (3a5b96c) then made every group created without a color storenone(no dot, underline or wash; Leo 2026-10-31: "WHY DOES THIS HAVE A LINE AND COLOR"), and changed the daemon's state test to expectnone, but did not update this check. The product is right; the check now asks fornone.Owner: no OWNERS.md row covers tab groups; #32198 is teamleaderleo's.
Testing
Command:
cmux-ci run --class light --display --script scripts/ci/package-test-lane.sh --ref SHA --arg=suite --arg=Packages/macOS/CmuxNext --arg=CmuxNextAppTests.TabSelectionActionsTests(5 runs in one step).Each job's lane summary is red for a reason outside this change: on these hosts the target's XCTest pass aborts (signal 6, after Contacts/AddressBook CoreData store errors) or hangs ~680-900 s with no test in flight, after the Swift Testing pass. The Swift Testing results below are the suite's own.
Observed / Not run
Observed: the fleet runs above.
python3 scripts/cmux-next/prepush-gate.pypasses.Not run: no app build; test-only change.
Changelog
none