Skip to content

base red: a new tab group nobody coloured has color none (TabSelectionActionsTests, after #32198) - #33095

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red-tab-group-color
Nov 3, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
base-red-tab-group-color

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Base red on feat-cmux-next: CmuxNextAppTests.TabSelectionActionsTests.thePaletteGroupsTheSameSelectedTabs fails at TabSelectionActionsTests.swift:85 (color "none", expected "grey").

Cause: #32156 (4816325) made tabGroup.create send grey and added this check. #32198 (3a5b96c) then made every group created without a color store none (no dot, underline or wash; Leo 2026-10-31: "WHY DOES THIS HAVE A LINE AND COLOR"), and changed the daemon's state test to expect none, but did not update this check. The product is right; the check now asks for none.

Owner: no OWNERS.md row covers tab groups; #32198 is teamleaderleo's.

Testing

Command: cmux-ci run --class light --display --script scripts/ci/package-test-lane.sh --ref SHA --arg=suite --arg=Packages/macOS/CmuxNext --arg=CmuxNextAppTests.TabSelectionActionsTests (5 runs in one step).

  • Base (feat 73eaec7 on cmuxs-Mac-mini and cmux11s): fails at line 85.
  • Tip: job a554671b75a6b853405d5c5d at feat 11dfe91 (cmux8s) is red on the first two of five rounds for this suite.
  • Head: job caedacddbf5bec9f3a7b4a94 (cmux9s) at 220df77: passed 4 of 5; the fifth round stalled with no test in flight (the host's XCTest hang below), not a test failure.

Each job's lane summary is red for a reason outside this change: on these hosts the target's XCTest pass aborts (signal 6, after Contacts/AddressBook CoreData store errors) or hangs ~680-900 s with no test in flight, after the Swift Testing pass. The Swift Testing results below are the suite's own.

Observed / Not run

Observed: the fleet runs above. python3 scripts/cmux-next/prepush-gate.py passes.
Not run: no app build; test-only change.

Changelog

none

…32198 made it

thePaletteGroupsTheSameSelectedTabs failed at TabSelectionActionsTests.swift:85
(color "none", expected "grey"). #32156 made tabGroup.create send grey and
added this check; #32198 then made every group created without a colour
store none (the daemon's cmux-tui state test expects none, and
tabGroup.create sends GroupTint.noneWire), so no dot or underline shows.
#32198 did not update this check. The product is right (Leo 2026-10-31:
'WHY DOES THIS HAVE A LINE AND COLOR'); the check now asks for none.

Culprit: 3a5b96c (#32198), over 4816325 (#32156).
Red: fleet job 2bf90b6c18ca136f3fb6c15d at feat 11dfe91.
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp27t1vd6w/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmphkw4bsiw/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 220df77: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33095 -f ref=base-red-tab-group-color -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 6b31a88 to compare; do not merge until green; see lane-rules

Shipped in:

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (independent review subagent, Opus 5.5 claude-opus-5-5, read-only): SHIP at 220df77

  • "none" is the intended behavior, not a regression. fix(groups): draw no color until one is chosen #32198 (3a5b96c) says a group created with no color now stores none, which draws no dot, underline, chip fill or wash ("it was grey"). It updated the daemon's own test, but not this app test.
  • The test is not weakened. It is still an exact match (color == "none"), and a nil color still fails.
  • No global state and no windows change.
  • Fleet: TabSelectionActionsTests passed 4 of 4 completed runs in job caedacddbf5b. The fifth round stalled before any test ran, and the PR body says so.

@lawrencecchen
lawrencecchen marked this pull request as ready for review November 3, 2026 07:37
@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 3, 2026
@lawrencecchen
lawrencecchen merged commit 0fda64e into feat-cmux-next Nov 3, 2026
302 of 326 checks passed
@lawrencecchen
lawrencecchen deleted the base-red-tab-group-color branch November 3, 2026 07:47
@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Correction to my review receipt above: the lanes were red overall because of the test-bundle run-loop guard, which held the main thread in xctest. It was not the macOS AddressBook store; that was only a symptom. #33023 and #33013 fixed it on feat (ecfbb44). This head is older than that fix, so its lane still shows the XCTest stage red. The suite's own result (passes at this head, fails at the tip) is unchanged. No action is needed on this PR.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 220df771 Deployed Nov 3, 2026 by lawrencecchen via namespace autofix #13100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant