Repository navigation
cmux NEXT: a new tab group nobody coloured is grey, not the next palette colour - #32156
Conversation
…tte colour Leo, 2026-10-31, on an orange dot and underline on an agent chat tab: "WHERE IS ORANGE COMING FROM". tabGroup.create (tab menu, palette, CLI through the app) gave a group with no colour the next palette colour (TabGroupOrdering.nextColor). It now takes grey, the daemon's own default; a colour the caller names still shows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-15424b596fd5f2bb23d6
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Default changesThis pull request changes 1 default at
Signed off on this commit by Merge receipt: merged as Regenerate the snapshot with Shipped in:
|
|
Review (subagent opus-5.5 medium): SHIP at 95345a1 Checked that the imports are still used and that nothing is newly unused. The test's types (PaneModel.tabGroups, TabGroupModel.color) match. No existing test expects a palette colour from tabGroup.create. The daemon accepts and stores "grey". Follow-ups: screen groups still use nextColor. |
|
This PR made the feat-cmux-next tip red on the arch ratchet: |
…p_lines +1 from #32156) (#32165) #32156 made the tab-group comment one line longer than the comment and expression it replaced; the tip arch ratchet failed with app_lines +1 over the last green arch tip 5029823. The comment keeps the rule and Leo's reason in two lines. Behavior does not change. Observed: arch-ratchet.py --base 5029823 --head HEAD was +1 before, see PR for after.
…32198 made it (#33095) thePaletteGroupsTheSameSelectedTabs failed at TabSelectionActionsTests.swift:85 (color "none", expected "grey"). #32156 made tabGroup.create send grey and added this check; #32198 then made every group created without a colour store none (the daemon's cmux-tui state test expects none, and tabGroup.create sends GroupTint.noneWire), so no dot or underline shows. #32198 did not update this check. The product is right (Leo 2026-10-31: 'WHY DOES THIS HAVE A LINE AND COLOR'); the check now asks for none. Culprit: 3a5b96c (#32198), over 4816325 (#32156). Red: fleet job 2bf90b6c18ca136f3fb6c15d at feat 11dfe91.
Leo, 2026-10-31, on an agent chat tab with a salmon underline and an orange dot beside it: "WHY DOES THIS HAVE A LINE AND COLOR?????? / WHERE IS ORANGE COMING FROM?????????? AN ORANGE DOT????"
Leo-ask: ask-88148faefe
What it was
The tab was in an unnamed tab group. Such a group's chip is a bare colour dot (TabGroupChipCell), and the group band draws the underline (TabGroupBandCell). Nobody picked the colour:
tabGroup.create(the tab menu's New Tab Group, the palette and the CLI through the app) gave any group created without a colour the next palette colour (TabGroupOrdering.nextColor, from cx-wqn5).Change
create-tab-group. No palette colour shows up that nobody chose.--color, the group editor) still shows as before.Tests
TabSelectionActionsTests.thePaletteGroupsTheSameSelectedTabsnow also asserts that the new group's colour isgrey. The app compile check runs on the fleet.Small change (one-line default plus a test assertion).
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Tab groups created without a chosen color now get grey instead of the next palette color, so no unintended orange dot and underline appear when nobody picked a color. A color the caller names (via
--coloror the group editor) still shows as before.Written for commit 95345a1. Summary will update on new commits.