Skip to content

base red: a new tab group nobody coloured has color none (TabSelectionActionsTests, after #32198) #33095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 1 commit into from
Nov 3, 2026
Merged

base red: a new tab group nobody coloured has color none (TabSelectionActionsTests, after #32198) #33095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/TabSelectionActionsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ struct TabSelectionActionsTests {
let refusal = services.registry.capturingRefusal { _ = services.registry.perform("tabGroup.create", invocation: ActionInvocation()) }
#expect(refusal == nil, "the palette's New Tab Group refused: \(refusal ?? "")")
try await PinnedPageTests.until({ Self.grouped(ids, in: pane) }, report: { "groups \(ids.map { pane.tab($0)?.tabGroup?.rawValue })" })
// A group nobody gave a color is grey, never a palette color nobody picked (Leo,
// 2026-10-31: "WHERE IS ORANGE COMING FROM?").
// A group nobody gave a color has none (#32198): no dot, underline or palette color
// nobody picked (Leo, 2026-10-31: "WHY DOES THIS HAVE A LINE AND COLOR").
let group = try #require(pane.tab(ids[0])?.tabGroup)
let color = pane.pane.tabGroups.first { $0.id == group }?.color
#expect(color == "grey", "a new tab group took \(color ?? "nil"), not grey")
#expect(color == "none", "a new tab group took \(color ?? "nil"), not none")
}
}

Expand Down
Loading