Skip to content

Session Info: the machine, Context, what it runs, then Sources by default - #32850

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/si-order-machine-first
Nov 3, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/si-order-machine-first

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #32817 (the web Session Info panel is the default again).

Leo, on the Session Info panel: "buttons stay in swift, summary panel in react", "i just want a good one". His list, in this order: "1. Machines showing up so I know if it's cloud or not 2. context 3. Subagents/background tasks running 4. Sources... you can technically use that area to add them".

What changes

References

cmux-design-references ids (private, not attached): claude/live/session-info-environment-and-context-panel, claude/live/session-info-popover-remote-control-context (the machine first, then context), claude/live/claude-right-panel-running-tasks (running tasks and agents in the rail), chatgpt/live/sidebar-session-info-rail-sections (subagents and sources in one panel), cmux/live/session-info-summary-panel-regressed.

Spec: leo-workspace design/session-info.md, updated in a separate notes PR with the order rule.

Changelog

Changed: Session Info lists the machine first, then Context, running subagents and background tasks, then Sources.

Observed / Not run

  • Observed: scripts/web-lint.sh passed and prepush-gate.py reported no new violations. Test results from cmux-ci test are in a comment below.
  • Not run: no local gallery capture.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Changes the Session Info panel's default section order so the machine appears first, then Context, running subagents and background tasks, then Sources. A saved order from any drag still wins, and the stored format is unchanged, so no migration is needed.

  • New default order: Environment, Context, Usage, Subagents, Background tasks, Sources, Changes, Outputs, Connectors. Usage keeps its spot after Context, and the sections Leo didn't name follow Sources; none is dropped.
  • Block membership and hairline styling are unchanged, so the hairlines now fall between Usage and Subagents, between Background tasks and Sources, and before Connectors.
  • Adds a test pinning the existing width stages (floating in the gutter at wide panes, pushing the chat at mid widths, waiting for the toggle at the 200px floor); no layout code changed.
  • The gallery's full chat now asserts the default order.

Written for commit 118a79b. Summary will update on new commits.

View guided diff Turn on auto-fix

…ault

Leo's order for the summary panel: "1. Machines showing up so I know if it's
cloud or not 2. context 3. Subagents/background tasks running 4. Sources".
DEFAULT_ORDER is now environment, context, usage, subagents, tasks,
sources, changes, outputs, connectors. Usage keeps its place after Context
(#28773); the sections he did not name follow Sources; none is dropped. A
saved order (any drag) still wins, and the stored format is unchanged, so no
migration. Block membership (the hairlines, the #27291 per-block format) is
unchanged.

The gallery's full chat asserts the order; a new unit test pins the width
stages (gutter at 1800px, push at 900px, push at the 200px floor waiting for
the toggle at 370px, never over the chat in a tall pane; a short pane's
popover is the one overlay).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-7a7568197607c3cdfb81
@cursor

cursor Bot commented Nov 3, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 118a79b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32850 -f ref=lane/si-order-machine-first -f platform=macos -f backend_mode=local

Gallery before/after for 118a79b: the capture produced no images (run).

Probably yours: inline-html-svg-preview-browser.test.ts, popup-reduce-motion.test.ts, popup-reduce-motion.test.ts fails here but not on main's latest full suite. Seen on other PRs too (likely flaky): RowGrammar.test.tsx, agent-pane-write-row-label.test.tsx, agent-pane-write-row-label.test.tsx and 2 more. This PR merged before its CI finished: fix forward on main.

CI failed on 118a79bc8a (run 41564844210 attempt 1): 1 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (4) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs RowGrammar.test.tsx the trailing column and chevron use the shared flex row contract: failed (job)
  • seen on other PRs agent-pane-write-row-label.test.tsx a Write named before its input reads Writing a file, not Write: failed (job)
  • seen on other PRs agent-pane-write-row-label.test.tsx a Write waiting on a permission keeps its own title: failed (job)
  • seen on other PRs find-import-pressed.test.tsx dark > disabled Find actions keep their paint while held: failed (job)
  • seen on other PRs glass-never-opaque.test.ts every tooltip and hover card in the page code is glass: failed (job)
  • new in this PR inline-html-svg-preview-browser.test.ts chromium: the document's script never runs, and the height still reports: failed (job)
  • new in this PR popup-reduce-motion.test.ts a dialog and its backdrop fade in and out: failed (job)
  • new in this PR popup-reduce-motion.test.ts a dialog and its backdrop fade in and out under Reduce Motion: failed (job)
Matched log lines
web / react-apps-base-check (4): (fail) the trailing column and chevron use the shared flex row contract [0.36ms]

Not re-run automatically: web / react-apps-base-check (4), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-base-check (4); NEW webview test reds: test/session-info.test.tsx > with only started chats Subagents is still drawn, and the running line's count lands on it; do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (claude-opus-5-5 medium subagent): SHIP at 118a79b

Review (subagent claude-opus-5-5 medium): SHIP at 118a79b

Visual verdict: no images. The diff changes the default section order only; the gallery full play asserts it.

The reviewer worked the new section tops through by hand and checked the drag and probe arithmetic, the fill() and mergeShown results, the hairline runs (matching the native separator's change-of-block rule), the width-stage math against SessionInfo.tsx, and that the legacy per-block format still parses.

Follow-ups: [follow-up] native/model.ts:119 and the header comment of session-info-section-order.test.tsx still describe the old three-block default.

@teamleaderleo teamleaderleo added the leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel label Nov 3, 2026
@teamleaderleo
teamleaderleo merged commit ee383dc into feat-cmux-next Nov 3, 2026
181 of 203 checks passed
@teamleaderleo
teamleaderleo deleted the lane/si-order-machine-first branch November 3, 2026 02:40
cmux-bot Bot pushed a commit that referenced this pull request Nov 3, 2026
…#32955)

* test: Session Info width stages read #32751's overlay stage

session-info-width-stages.test.ts (#32850) was written against #32591's
narrow-pane push; #32751, merged right after, made a pane too narrow to push
lay the panel over the chat above the composer (Leo, 2026-11-03: "but you
should still be able to have it be an overlay"). The test now reads
sessionInfoStage and expects that overlay below sessionInfoFits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

* test: Session Info width stages: format

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
cmux-bot Bot pushed a commit that referenced this pull request Nov 3, 2026
… trail line for #32817's hidden fold (#32965)

Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Nov 3, 2026
context-autocompact-window: the fixture's acpmux cap (200k) is under the
400k /context window, and since #32665 Context reads the smaller of the two,
so the state read 171.4K / 200K. The /context chats now carry a 400k cap.

tasks-finished, workflow-finished, workflow-agent-failed: their shift rows
predate #32850 (Sources now sits right below Background tasks) and #32939
(the Show more row below the last section); opening the fold pushes those
rows down, which the browser's layout-shift entries count. The rows follow
the new layout.


Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Nov 3, 2026
…#33900)

#subagents-open and #subagents-busy-more open the Subagents list, which pushes
Background tasks, Sources and the list's own fold rows straight down past the
viewport. The box tracker exempts that; the browser's layout-shift entries do
not. Since #32850 put Subagents above Background tasks and Sources, those rows
sit inside the viewport, so the old rows (seeded in #30256) were wrong for the
new layout. Raise them to the measured scores, as #33753 did for the sibling
states.


Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 118a79bc Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #103464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant