Repository navigation
base red: message-preview opens the "Received N messages" row before it reads a preview - #32823
Conversation
…efore it reads a preview #32720 draws received messages next to each other as one "Received N messages" row whose messages show once it opens. The message-preview stage has two received messages in a row, so .cv-received counted 0 and every preview read waited out its 5 s. open() now opens that row when the stage draws one; inside, each message keeps its own line, toggle and preview, which the test reads (as c6e52c4 did for the earlier fold). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Review (subagent opus-5.5 medium): SHIP at 9592d2f Visual verdict: unchanged by this diff (test-only). Checked: #32720 gathers the stage's two adjacent received messages into a closed "Received N messages" row (laneNoticeBatches.ts receivedRun); opening it restores two .cv-received rows with their own toggles, previews and panels; Minimal Mode batches the same way; code-first (one received) and sent-row tests are unaffected; formatting fits 120 columns. Follow-ups: none. |
Base-red-job: web / react-apps-check
webviews/test/message-preview-browser.test.tsfails on every recent base web run (41556018937, 41556254089, 41556613101, 41557134592, 41555236821 at 3891b41): line 70expect(.cv-received count).toBe(2)gets 0, and line 138 (Minimal Mode) times out reading.cv-received__preview.Cause: #32720 ("a turn's inbox notices and received lines are one 'Received N messages' row") deliberately gathers received messages next to each other into one "Received N messages" row whose messages show only once it opens. The
agent-pane.message-previewstage has two received messages in a row, so they now sit inside that closed row. Green at 708aa6d, red from the run that includes #32720.Fix: the test's
open()opens the "Received N messages" row when the stage draws one, then reads each message's own line, toggle and preview inside it, the same way c6e52c4 handled the earlier fold. No product change; the behaviour is #32720's intended design.Observed / Not run
laneNoticeBatches.tsreceivedRun) and itsreceived-messages-columns-browser.test.tsselectors.Changelog
none
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the failing
message-preview-browser.test.tsby opening the "Received N messages" row before reading message previews. #32720 groups consecutive received messages into one collapsible row that renders its messages only once opened, so the test now expands that row when the stage draws one and then reads each message's line, toggle, and preview inside it. No product change; the grouped row is #32720's intended behavior.Written for commit 9592d2f. Summary will update on new commits.