Repository navigation
gallery health: chat inspector Subagents rows follow the section order - #33900
Merged
teamleaderleo merged 1 commit intoNov 3, 2026
Merged
Conversation
#subagents-open and #subagents-busy-more open the Subagents list, which pushes Background tasks, Sources and the list's own fold rows straight down past the viewport. The box tracker exempts that; the browser's layout-shift entries do not. Since #32850 put Subagents above Background tasks and Sources, those rows sit inside the viewport, so the old rows (seeded in #30256) were wrong for the new layout. Raise them to the measured scores, as #33753 did for the sibling states. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 3, 2026 13:47 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
Owned by an agent session · session |
teamleaderleo
commented
Nov 3, 2026
teamleaderleo
left a comment
teamleaderleo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review (codex gpt-6-astra high, next-review, since=20261103T140023Z): SHIP at 092f271
SHIP at 092f271
Visual verdict: unchanged by this diff; supplied renders differ only in spinner animation phases.
Checked JSON validity, state keys, and baseline comparison logic; no correctness findings. Tests could not run because Bun is unavailable.
Follow-ups: none
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fixing the
gallery healthbase red on feat-cmux-next (latest base run 41643573386 at 5505bbd): the two Session Info (chat-inspector) Subagents states that #33773 left.What was red, and why
agent-pane.chat-inspector#subagents-open: shift 0.0542 vs a row of 0, on the click of the "40 done · 1 failed" row.agent-pane.chat-inspector#subagents-busy-more: shift 0.0785 vs a row of 0.00791, on the click of "Show 12 more".Both scores are the same in every theme and attempt of both base runs, and the box tracker scores 0 for both. The score comes from the browser's layout-shift entries. Their sources in the run's
results.jsonare[dx dy dw dh], and each one is exactly minus its previous rect. So each node's current rect is empty: Chromium reports that for a node pushed fully out of the viewport.section.acpmux-session-info-sectionat y 633 (Background tasks) and at y 813 (Sources), plus a text node at y 801. All of them sit below the opened Subagents list and are pushed past the 900px viewport.Nothing above the list moves, and nothing moves up or sideways. The before and after captures show the head, Context, Usage and the first rows in place, and the list growing down. Only the rows after the control move down, which the box tracker (
shift.ts) exempts on purpose ("a box after the target in document order that moves straight down: the expansion pushes it").Culprit: #32850, "Session Info: the machine, Context, what it runs, then Sources by default". It follows Leo's order: "1. Machines showing up so I know if it's cloud or not 2. context 3. Subagents/background tasks running 4. Sources". Before it, Subagents sat in the last block, with Changes, Sources and Outputs above it. So when the rows were seeded (#30256), little or nothing visible sat under the Subagents list. Now Background tasks and Sources sit directly under it, inside the viewport, so opening the list pushes them. That is a deliberate layout change, so the old rows were wrong for the new layout.
Fix
This follows #33753, which did the same for the sibling states
#tasks-finished,#workflow-finishedand#workflow-agent-failed. It raises the two shift-baseline rows to the measured scores (0.05424, 0.07845) and changes no component.I did not do the runner change #33753 suggested (dropping browser entries for rows after the target that move straight down). Here every source moves out of the viewport, and Chromium then reports an empty current rect, which can't tell down from up. So the runner change would need a DOM read per source plus a whole-gallery comparison, which is more than this base-red fix.
Risk
Gallery-only: two rows in
scripts/gallery-matrix/shift-baseline.json, no shipped code. A real regression in these two states would have to more than add to this push-down to fail them now.Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Updates two chat-inspector Subagents layout-shift baseline rows for the new section order.
Opening the Subagents list now pushes Background tasks and Sources past the viewport, since #32850 moved Subagents above them. The baseline rows were seeded when those sections sat below the list, so they no longer match. Raises
#subagents-openand#subagents-busy-moreto the measured scores, as #33753 did for the sibling states. Gallery-only change; no shipped code.Written for commit 092f271. Summary will update on new commits.