Repository navigation
gallery health: received-row plays open "Received N messages"; a sender's mark centres on its line - #33752
Merged
Conversation
…rk centres on its line #32720 gathers received lines next to each other into one closed "Received N messages" row, so plays that waited for .cv-received lines timed out (incoming-message files, files-elsewhere, minimal-open, minimal-fade-count, minimal-inline-name; agent-message-row folded-run-opened). They now open that row first, as #32820 does for the disclosure entry. The row's head draws the one sender's mark (SenderMark) in the tool icon slot; its glyph sat in nested inline spans on a text baseline, 2px above the line's centre (center-line, row received:user-N in message-preview and folded-run). The wrappers now centre the glyph, in the head and in a received line's mark. agent-message-row#both-directions-opened's shift row follows the opened lines' current geometry (0.02068 -> 0.0265). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 96eb1b9 to compare; do not merge until green; see lane-rules Shipped in:
|
Collaborator
Author
|
Owned by an agent session · session |
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 3, 2026 11:56 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Found 8 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
…Received N messages" row The plays open #32720's gathered row before they open its lines, so the rows under it move once more; rows set to this PR's measured worst (run 41631275437), as #32820 does for the disclosure entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 3, 2026 12:38 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This was referenced Nov 3, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base red:
gallery healthon feat-cmux-next (run 41623839244 at f504928). This PR fixes the cluster for received and agent-message rows.What was red, and the cause
Broken: "play: waitFor did not hold within 5000 ms"
agent-pane.incoming-message#files,#files-elsewhere,#minimal-open,#minimal-fade-count,#minimal-inline-nameagent-pane.agent-message-row#folded-run-openedCulprit: #32720 ("Transcript: a turn's inbox notices and received lines are one "Received N messages" row"). That was a deliberate design change. Leo, 2026-11-02: "can't we simply just display most of these as recieved x messages and all of them get revealed then we can expand the messages". Received lines that sit next to each other now gather in one closed "Received N messages" row. These plays waited for
.cv-receivedlines that only show once that row is open.Fix: the plays follow the design. They open the row first, as #32820 does for
IncomingMessageDisclosure.gallery.ts(that file is not touched here) and #32823 did for the message-preview browser test. InIncomingMessageCard.gallery.ts,openAllLinesandlinesDrawncall a newopenReceivedRow.AgentMessageRow.gallery.ts#folded-run-openedopens the row before it opens each line. The comments and notes that still said several received lines "never fold into one" now describe the row.Geometry
[center-line]: "row received:user-N: its icon centres -2 px off its first line"agent-pane.message-preview#baseline-fade,#full-cards-no-fade,#one-line,#cards-no-fadeagent-pane.agent-message-row#folded-run(row received:user-76)Culprit: #32720 again, which made these states' received lines into a "Received N messages" head with the row key
received:<first id>. The head has one sender, so it draws that sender's mark (SenderMark, in the head since #30652). The mark nests its glyph in inline spans:AgentIdentity's wrapper, then the tone span. An inline svg sits on a text baseline, so the glyph drew 2px above the line's centre. The individual received lines had the same 2px miss before:invariant-baseline.jsonlists them ascenter-line:row user-1/user-2. Under the new key, the miss is a new red.Fix (CSS): the mark's wrappers centre the glyph (
inline-flex,align-items: center, and the svg/imgdisplay: block). This applies in the group head (MessageGroupHead.css) and in a received line's mark (conversation.css, where only the direct child span was centred). The Chief's text avatar keeps its own box. This follows the design rule the invariant cites (chat-transcript.md "glyph centered": a row's leading icon centres on its first line).Layout shift past baseline
agent-pane.agent-message-row#both-directions-opened: shift 0.0265 vs baseline 0.02068 (light theme only, on all three attempts). The play opens the sent line, then the received line. Each opened panel pushes the rows under it down. That move is the variant's purpose and is no regression of its own.The shift row is raised to 0.0265 so it matches the opened lines' geometry today. Exact culprit: not pinned from the artifacts. The run lists no moving rows, and several deliberate row changes since the row was written (#30256) touch these lines: #32867 puts the chevron after the label, #32574 shows the reply's Copy footer at rest under the turn, and #32742 changes received-row spacing. This is the one baseline row raised, and only by the measured amount. The dark theme of the same state stays under the old row.
Shift rows for the plays that now open the row. Opening the gathered row adds one more step, and the rows under it move one more time. This PR's first gallery run (41631275437) showed every play passing and every received
center-linemiss gone. It also put these states past their old shift rows. Each row is set to that run's measured worst, the same thing #32820 does for the disclosure entry:Risk
Low. The gallery plays and notes change only fixtures. The CSS changes only how a sender's mark centres inside its 16px slot: the glyph moves at most 2px down onto the line's centre, and the row's size does not change. This PR's own
gallery healthrun is the check.Agent session: agent session
🤖 Generated with Claude Code