Repository navigation
ci(owned-pool rescue): watch the NEXT signed-host check - #32114
Conversation
#28223 adds .github/workflows/nightly-next-cua-signed-host.yml on feat-cmux-next; its Mac job can take the owned side lane, and the guard reads main's watch list, so list it here first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-63f0bcf9b78ecec06a14
|
All contributors have signed the CLA ✍️ ✅ |
|
Owned by an agent session · session |
|
Review (subagent claude-opus-5-5, correctness): SHIP at 97ae778 The entry matches its siblings (same Follow-ups:
|
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Register signed-host workflow scripts/ci/owned_pool_rescue.py |
SIDE_WORKFLOW_PATHS now includes .github/workflows/nightly-next-cua-signed-host.yml. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Feature
Possibly related issues
- CI fast guards is red on main #30131: This change adds a workflow to the same side-workflow watch list referenced by the issue.
- [RFC] CI routing: one ownership map, derived everywhere — four silent-skip failures in one day #13807: This change adds coverage for one workflow omission, but does not unify workflow ownership and enforcement data.
- ci: CI_LINUX_GATE_OWNED_RUNNER follow-ups (kill switch, rescue coverage) #30453: This change adds another workflow to the owned-pool rescue coverage mechanism.
- ci(rescue): follow-ups to the nightly signing-stall coverage (#26534) #26576: This change adds rescue watch coverage for a signed-host workflow, but does not change watch expiry handling.
Possibly related PRs
- manaflow-ai/cmux#30343: Both changes add a side-lane workflow to
SIDE_WORKFLOW_PATHS. - manaflow-ai/cmux#29343: Both changes register a side-lane workflow in
SIDE_WORKFLOW_PATHS. - manaflow-ai/cmux#28471: This change adds a workflow path used by the queued-run watch.
Suggested reviewers: lawrencecchen
Merge Risk: 
97ae7
-
The workflow registration presents no identified merge-blocking risk. Merge after normal CI checks pass.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: updating owned-pool rescue to watch the NEXT signed-host check. Description check The description is mostly complete. It explains the problem, resulting behavior, branch-specific context, test command, observed result, and unrun Mac/app builds. It omits the Proof and Checklist sect… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Cmux Cloud Persistent Session And Early Input PASS. The pull request changes only the SIDE_WORKFLOW_PATHSwatch list inscripts/ci/owned_pool_rescue.py. It does not change Cloud terminal creation, cmux-tui transport, manual panes, input routi…Cmux Swift Actor Isolation The pull request changes only scripts/ci/owned_pool_rescue.py. The diff adds one workflow path toSIDE_WORKFLOW_PATHSand contains no Swift files or Swift production code. The Swift actor isolatio…Cmux Swift Blocking Runtime The pull request changes only scripts/ci/owned_pool_rescue.py. The diff adds one workflow-path string toSIDE_WORKFLOW_PATHSand introduces no Swift code or blocking runtime behavior.Cmux Browser Automation Off-Main PASS. The pull request changes only scripts/ci/owned_pool_rescue.pyand adds one workflow path toSIDE_WORKFLOW_PATHS. It does not changebrowser.*commands,ControlCommandExecutionPolicy, `so…Cmux Expensive Synchronous Load The pull request changes only scripts/ci/owned_pool_rescue.py. It adds one workflow path to the PythonSIDE_WORKFLOW_PATHSset. The diff contains no Swift code and no synchronous agent-history loa…Cmux Cache Substitution Correctness PASS. The PR changes only one Python CI constant in scripts/ci/owned_pool_rescue.py: it adds a workflow path toSIDE_WORKFLOW_PATHS. It does not change production Swift, TypeScript, or JavaScript …Cmux No Hacky Sleeps PASS. The pull request adds only one workflow-path string to SIDE_WORKFLOW_PATHSinscripts/ci/owned_pool_rescue.py. It does not introduce or expand sleeps, timers, polling, fixed backoff, or wall…Cmux Algorithmic Complexity PASS. The PR adds one string literal to the existing SIDE_WORKFLOW_PATHSfrozensetinscripts/ci/owned_pool_rescue.py. It adds no loop, collection scan, sort, filter, join, or hot-path algorithm…Cmux Swift Concurrency PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. The diff adds one workflow path toSIDE_WORKFLOW_PATHSand changes no Swift files or Swift concurrency behavior.Cmux Swift @ConcurrentPASS: The pull request changes only scripts/ci/owned_pool_rescue.pyby adding one workflow path. It contains no Swift files or Swift concurrency changes, so the@concurrentcheck is not applicable…Cmux Swift Package Boundaries The pull request changes only the Python CI file scripts/ci/owned_pool_rescue.py. It adds one workflow path toSIDE_WORKFLOW_PATHSand introduces no production Swift code or package-boundary chang…Cmux Swiftpm Lockfiles PASS: The PR changes only scripts/ci/owned_pool_rescue.pyby adding a workflow path toSIDE_WORKFLOW_PATHS. It does not change a.gitignore,Package.swift,Package.resolved, or `cmux.xcodepr…Cmux Swift Logging PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. The diff adds one workflow path toSIDE_WORKFLOW_PATHSand adds no Swift or runtime logging code. Thecmux Swift loggingfail…Cmux User-Facing Error Privacy PASS. The diff adds only a workflow path to SIDE_WORKFLOW_PATHSinscripts/ci/owned_pool_rescue.py. The surrounding code andci-owned-pool-rescue.ymlshow an internal CI rescue and operator poll…Cmux Full Internationalization The PR changes only the operational Python set SIDE_WORKFLOW_PATHSby adding the literal workflow path.github/workflows/nightly-next-cua-signed-host.yml. The path is used for CI run discovery and…Cmux Swiftui State Layout The pull request changes only scripts/ci/owned_pool_rescue.pyby adding one workflow path toSIDE_WORKFLOW_PATHS. It introduces no SwiftUI code, state,GeometryReader, lazy/list rows, or render-…Cmux Architecture Rethink PASS: The pull request changes only the Python constant SIDE_WORKFLOW_PATHSinscripts/ci/owned_pool_rescue.py. It adds one workflow path and introduces no Swift code, lifecycle ownership, timing …Cmux Swift Auxiliary Window Close Shortcuts PASS: The pull request changes only scripts/ci/owned_pool_rescue.pyby adding one workflow path. It contains no Swift or window code, so the auxiliary-window close-shortcut rule does not apply.Cmux Source Artifacts The pull request changes only scripts/ci/owned_pool_rescue.py. The diff adds one workflow path to the hand-writtenSIDE_WORKFLOW_PATHSconfiguration. It is not a local/generated artifact or a scra…Cmux No Test Or Debug Seam In Production Source The pull request changes only scripts/ci/owned_pool_rescue.py. The diff adds one workflow path to a Python set and contains no Swift files under a productionSources/path. The custom check is the…Full details: Description check
-
Explanation
The description is mostly complete. It explains the problem, resulting behavior, branch-specific context, test command, observed result, and unrun Mac/app builds. It omits the Proof and Checklist sections, but these omissions are non-critical for this CI-only one-line change.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Full details: Cmux Cloud Persistent Session And Early Input
-
Explanation
PASS. The pull request changes only the
SIDE_WORKFLOW_PATHSwatch list inscripts/ci/owned_pool_rescue.py. It does not change Cloud terminal creation, cmux-tui transport, manual panes, input routing, authentication, idempotency, revisions, or leases. The persistent-session and early-input rule is therefore not applicable.
Full details: Cmux Swift Actor Isolation
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. The diff adds one workflow path toSIDE_WORKFLOW_PATHSand contains no Swift files or Swift production code. The Swift actor isolation check does not apply.
Full details: Cmux Browser Automation Off-Main
-
Explanation
PASS. The pull request changes only
scripts/ci/owned_pool_rescue.pyand adds one workflow path toSIDE_WORKFLOW_PATHS. It does not changebrowser.*commands,ControlCommandExecutionPolicy,socketWorkerMethods, worker routing, WebKit/AppKit access, or policy tests. The browser automation rule therefore does not apply.
Full details: Cmux Expensive Synchronous Load
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. It adds one workflow path to the PythonSIDE_WORKFLOW_PATHSset. The diff contains no Swift code and no synchronous agent-history load or interactive-path behavior.
Full details: Cmux Cache Substitution Correctness
-
Explanation
PASS. The PR changes only one Python CI constant in
scripts/ci/owned_pool_rescue.py: it adds a workflow path toSIDE_WORKFLOW_PATHS. It does not change production Swift, TypeScript, or JavaScript code, and it does not substitute a cached value for an authoritative read in a persistence, history, undo, or snapshot path.
Full details: Cmux No Hacky Sleeps
-
Explanation
PASS. The pull request adds only one workflow-path string to
SIDE_WORKFLOW_PATHSinscripts/ci/owned_pool_rescue.py. It does not introduce or expand sleeps, timers, polling, fixed backoff, or wall-clock synchronization. GitHub Actions YAML is also out of scope under the referenced rule.
Full details: Cmux Algorithmic Complexity
-
Explanation
PASS. The PR adds one string literal to the existing
SIDE_WORKFLOW_PATHSfrozensetinscripts/ci/owned_pool_rescue.py. It adds no loop, collection scan, sort, filter, join, or hot-path algorithm. The change does not trigger any failure condition in.github/review-bot-rules/algorithmic-complexity.md.
Full details: Cmux Swift `@Concurrent`
-
Explanation
PASS: The pull request changes only
scripts/ci/owned_pool_rescue.pyby adding one workflow path. It contains no Swift files or Swift concurrency changes, so the@concurrentcheck is not applicable.
Full details: Cmux Swift Package Boundaries
-
Explanation
The pull request changes only the Python CI file
scripts/ci/owned_pool_rescue.py. It adds one workflow path toSIDE_WORKFLOW_PATHSand introduces no production Swift code or package-boundary change.
Full details: Cmux Swiftpm Lockfiles
-
Explanation
PASS: The PR changes only
scripts/ci/owned_pool_rescue.pyby adding a workflow path toSIDE_WORKFLOW_PATHS. It does not change a.gitignore,Package.swift,Package.resolved, orcmux.xcodeprojpackage references. No SwiftPM lockfile requirement is triggered.
Full details: Cmux Swift Logging
-
Explanation
PASS: The pull request changes only
scripts/ci/owned_pool_rescue.py. The diff adds one workflow path toSIDE_WORKFLOW_PATHSand adds no Swift or runtime logging code. Thecmux Swift loggingfailure conditions are not applicable.
Full details: Cmux User-Facing Error Privacy
-
Explanation
PASS. The diff adds only a workflow path to
SIDE_WORKFLOW_PATHSinscripts/ci/owned_pool_rescue.py. The surrounding code andci-owned-pool-rescue.ymlshow an internal CI rescue and operator polling path. The change adds no user-facing error, alert, command output, API body, or recovery text, and no concrete path to a cmux end user exists.
Full details: Cmux Full Internationalization
-
Explanation
The PR changes only the operational Python set
SIDE_WORKFLOW_PATHSby adding the literal workflow path.github/workflows/nightly-next-cua-signed-host.yml. The path is used for CI run discovery and rescue, not user-facing text. No Swift UI, catalog, web message, API response, markdown, or changelog content is changed.
Full details: Cmux Swiftui State Layout
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.pyby adding one workflow path toSIDE_WORKFLOW_PATHS. It introduces no SwiftUI code, state,GeometryReader, lazy/list rows, or render-time mutation.
Full details: Cmux Architecture Rethink
-
Explanation
PASS: The pull request changes only the Python constant
SIDE_WORKFLOW_PATHSinscripts/ci/owned_pool_rescue.py. It adds one workflow path and introduces no Swift code, lifecycle ownership, timing repair, synchronization, observer, side channel, or duplicate UI wiring. The Swift architectural rethink check is therefore not applicable.
Full details: Cmux Source Artifacts
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. The diff adds one workflow path to the hand-writtenSIDE_WORKFLOW_PATHSconfiguration. It is not a local/generated artifact or a scratch directory, so it satisfies the source-control-artifacts rule.
Full details: Cmux No Test Or Debug Seam In Production Source
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. The diff adds one workflow path to a Python set and contains no Swift files under a productionSources/path. The custom check is therefore not applicable.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Merge receipt for |
Adds
.github/workflows/nightly-next-cua-signed-host.ymltoSIDE_WORKFLOW_PATHSinscripts/ci/owned_pool_rescue.py, marked feat-cmux-next only.#28223 adds that workflow on feat-cmux-next. Its Mac job takes the owned side lane through
side_lane_placement.py, the same waynightly-next-launch-smoke.ymldoes.tests/test_ci_owned_pool_sources.pyreads main's watch list, so this entry has to land on main before #28223 can pass its guard group. A feat-only entry on main is fine: the test treats an entry with no workflow on a branch as watching nothing there.Changelog
none
Observed / Not run
python3 tests/test_ci_owned_pool_sources.pypasses here, and with this entry it also passes on carry of #27690: verify signed Computer Use hosts #28223's tree.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds
.github/workflows/nightly-next-cua-signed-host.ymlto the owned-pool rescue watch list so the guard can track it onfeat-cmux-nextbefore the workflow lands via #28223.Written for commit 97ae778. Summary will update on new commits.
Summary by CodeRabbit