Repository navigation
ci(owned-pool rescue): watch cmux-next-web.yml - #30343
Conversation
feat-cmux-next's cmux-next-web.yml calls ci-web.yml, whose small jobs now read the Linux pool (vars.RUNNER_POOLS) in #30277. test_ci_owned_pool_sources fails that PR until main's rescue watches the caller: 'these workflows can take an owned pool but main's scripts/ci/owned_pool_rescue.py does not watch them'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-03502a1773135ae74238
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Extend the watched workflow set scripts/ci/owned_pool_rescue.py |
Adds .github/workflows/cmux-next-web.yml to SIDE_WORKFLOW_PATHS. |
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Possibly related issues
manaflow-ai/cmux#30199— This issue describes a discovery gap for in-progress side runs; this change adds a side-lane workflow to the rescue watch set.manaflow-ai/cmux#13807— This issue describes mismatches between workflow declarations and CI ownership maps; this change adds a workflow to the rescue classification.
Possibly related PRs
- manaflow-ai/cmux#27129 — This PR introduces and reconciles the
RUNNER_POOLSvariable used by the reusable web CI path covered by this rescue classification. - manaflow-ai/cmux#29343 — This PR adds another side-lane workflow to
SIDE_WORKFLOW_PATHS.
Suggested reviewers: lawrencecchen
Merge Risk: 
954e9
-
The change extends owned-pool rescue coverage to the next-web workflow. No concrete merge-blocking risk is identified; it is mergeable subject to normal checks.
Pre-merge checks: 
-
Check name Status Explanation Title check The title names the change: it adds cmux-next-web.yml to the owned-pool rescue watch list. The diff adds one path to SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py, which matches the title. Th… Description check The description follows the repository template in substance. It has a Summary that states the problem (the guard test fails because cmux-next-web.yml calls ci-web.yml, which reads vars.RUNNER_POOLS) … Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Cmux Cloud Persistent Session And Early Input The pull request changes only scripts/ci/owned_pool_rescue.pyby adding.github/workflows/cmux-next-web.ymltoSIDE_WORKFLOW_PATHS. It does not change Cloud terminal creation, cmux-tui transport…Cmux Swift Actor Isolation The pull request changes only scripts/ci/owned_pool_rescue.py. The diff adds a workflow path and comment. It contains no Swift production changes, so it cannot introduce or worsen Swift 6 actor isol…Cmux Swift Blocking Runtime The pull request changes only scripts/ci/owned_pool_rescue.py. It adds a workflow path and a comment toSIDE_WORKFLOW_PATHS. The diff contains no Swift files and introduces no blocking or timing-b…Cmux Browser Automation Off-Main PASS: The pull request changes only scripts/ci/owned_pool_rescue.pyby adding.github/workflows/cmux-next-web.ymltoSIDE_WORKFLOW_PATHS. It changes no browser socket commands, WebKit/AppKit acc…Cmux Expensive Synchronous Load The pull request changes only scripts/ci/owned_pool_rescue.py. The diff adds one workflow path and a comment toSIDE_WORKFLOW_PATHS. It adds or moves no Swift code and no synchronous agent-history…Cmux Cache Substitution Correctness PASS: The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI script. The diff adds a workflow path and comment toSIDE_WORKFLOW_PATHS; it does not change production Swift, Type…Cmux No Hacky Sleeps PASS. The pull request changes only scripts/ci/owned_pool_rescue.pyby adding a workflow path and comment toSIDE_WORKFLOW_PATHS. It introduces no sleep, timer, polling, delayed dispatch, retry de…Cmux Algorithmic Complexity The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI script outside the check's production Swift, TypeScript, JavaScript, shell, and runtime-code scope. The added `SIDE_WORKFLO…Cmux Swift Concurrency PASS: The pull request changes only scripts/ci/owned_pool_rescue.py, adding a workflow path and comment. The reviewed diff contains no Swift files and introduces no Swift concurrency patterns.Cmux Swift @ConcurrentThe pull request changes only scripts/ci/owned_pool_rescue.py. The diff contains no Swift files or Swift functions, so the@concurrentrules do not apply.Cmux Swift Package Boundaries The pull request changes only scripts/ci/owned_pool_rescue.py. It adds.github/workflows/cmux-next-web.ymlto a Python workflow path set. The diff contains no production Swift changes, so the Swif…Cmux Swiftpm Lockfiles PASS: The PR changes only scripts/ci/owned_pool_rescue.pyby adding a workflow path toSIDE_WORKFLOW_PATHS. It does not change a SwiftPM package,Package.swift,.gitignore, Xcode package refer…Cmux Swift Logging The pull request changes only scripts/ci/owned_pool_rescue.py. It adds a workflow path and comment. It adds no Swift code or logging, so the Swift logging rules do not apply.Cmux User-Facing Error Privacy The diff only adds .github/workflows/cmux-next-web.ymlto the internal CISIDE_WORKFLOW_PATHSset and adds an internal comment. It does not add or change cmux user-facing errors, alerts, command o…Cmux Full Internationalization The pull request changes only scripts/ci/owned_pool_rescue.py. It adds a CI workflow path and a developer-facing comment toSIDE_WORKFLOW_PATHS. It does not add or modify user-facing Swift text, w…Cmux Swiftui State Layout PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. It adds.github/workflows/cmux-next-web.ymltoSIDE_WORKFLOW_PATHS. The diff contains no Swift or SwiftUI files, so the Swift…Cmux Architecture Rethink The PR changes only scripts/ci/owned_pool_rescue.py. It adds a workflow path and comment toSIDE_WORKFLOW_PATHS. The diff contains no Swift, UI lifecycle, timing, synchronization, observer, or sta…Cmux Swift Auxiliary Window Close Shortcuts PASS: The reviewed diff changes only scripts/ci/owned_pool_rescue.pyand adds.github/workflows/cmux-next-web.ymltoSIDE_WORKFLOW_PATHS. It contains no Swift, NSWindow, NSPanel, NSWindowControl…Cmux Source Artifacts The PR changes only scripts/ci/owned_pool_rescue.py. The diff adds a hand-written workflow-path entry and comment toSIDE_WORKFLOW_PATHS; it adds no logs, screenshots, recordings, temp directories…Cmux No Test Or Debug Seam In Production Source PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. It adds a workflow path toSIDE_WORKFLOW_PATHSand changes no Swift file under a productionSources/path. The specified test…Full details: Title check
-
Explanation
The title names the change: it adds cmux-next-web.yml to the owned-pool rescue watch list. The diff adds one path to SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py, which matches the title. The title is short and specific, and it uses the scope prefix ci(owned-pool rescue), which fits a CI-only change.
Full details: Description check
-
Explanation
The description follows the repository template in substance. It has a Summary that states the problem (the guard test fails because cmux-next-web.yml calls ci-web.yml, which reads vars.RUNNER_POOLS) and the resulting behavior (the caller is added to SIDE_WORKFLOW_PATHS). It has a Changelog section set to none, which fits an internal CI change. It has an Observed / Not run section that names the commands run, the test counts, and the check that could not run before merge. The Proof section is absent, and the template's checklist is absent. Those omissions are acceptable for a CI-only change with no user-visible effect, but the description does not say why Proof is not needed. The Summary does not link the issue or PR
#30277in a form that states the closing relationship, and the template does not require that. The description does not state whether the relay authorization or localization items apply; these do not apply to a workflow path list change.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Full details: Cmux Cloud Persistent Session And Early Input
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.pyby adding.github/workflows/cmux-next-web.ymltoSIDE_WORKFLOW_PATHS. It does not change Cloud terminal creation, cmux-tui transport, manual renderer admission, input routing, snapshots, authentication, idempotency, revision fences, or leases. No stated failure condition applies.
Full details: Cmux Swift Actor Isolation
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. The diff adds a workflow path and comment. It contains no Swift production changes, so it cannot introduce or worsen Swift 6 actor isolation mistakes.
Full details: Cmux Swift Blocking Runtime
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. It adds a workflow path and a comment toSIDE_WORKFLOW_PATHS. The diff contains no Swift files and introduces no blocking or timing-based synchronization.
Full details: Cmux Browser Automation Off-Main
-
Explanation
PASS: The pull request changes only
scripts/ci/owned_pool_rescue.pyby adding.github/workflows/cmux-next-web.ymltoSIDE_WORKFLOW_PATHS. It changes no browser socket commands, WebKit/AppKit access, worker routing, or policy tests. Therefore it does not introduce or worsen the failures covered by the browser automation rule.
Full details: Cmux Expensive Synchronous Load
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. The diff adds one workflow path and a comment toSIDE_WORKFLOW_PATHS. It adds or moves no Swift code and no synchronous agent-history load.
Full details: Cmux Cache Substitution Correctness
-
Explanation
PASS: The pull request changes only
scripts/ci/owned_pool_rescue.py, a Python CI script. The diff adds a workflow path and comment toSIDE_WORKFLOW_PATHS; it does not change production Swift, TypeScript, or JavaScript, and it does not substitute any cached value for an authoritative read.
Full details: Cmux No Hacky Sleeps
-
Explanation
PASS. The pull request changes only
scripts/ci/owned_pool_rescue.pyby adding a workflow path and comment toSIDE_WORKFLOW_PATHS. It introduces no sleep, timer, polling, delayed dispatch, retry delay, or wall-clock wait. The runtime-no-hacky-sleeps rule is not violated.
Full details: Cmux Algorithmic Complexity
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py, a Python CI script outside the check's production Swift, TypeScript, JavaScript, shell, and runtime-code scope. The addedSIDE_WORKFLOW_PATHSentry is a constant set member and does not introduce any collection scan, rescan, repeated sorting/filtering, in-memory join, or slower algorithm.
Full details: Cmux Swift Package Boundaries
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. It adds.github/workflows/cmux-next-web.ymlto a Python workflow path set. The diff contains no production Swift changes, so the Swift package boundary rule does not apply.
Full details: Cmux Swiftpm Lockfiles
-
Explanation
PASS: The PR changes only
scripts/ci/owned_pool_rescue.pyby adding a workflow path toSIDE_WORKFLOW_PATHS. It does not change a SwiftPM package,Package.swift,.gitignore, Xcode package references, dependency pins, or anyPackage.resolvedfile. The SwiftPM lockfile conditions do not apply.
Full details: Cmux User-Facing Error Privacy
-
Explanation
The diff only adds
.github/workflows/cmux-next-web.ymlto the internal CISIDE_WORKFLOW_PATHSset and adds an internal comment. It does not add or change cmux user-facing errors, alerts, command output, API bodies, or recovery copy. No concrete path to a cmux end user exists.
Full details: Cmux Full Internationalization
-
Explanation
The pull request changes only
scripts/ci/owned_pool_rescue.py. It adds a CI workflow path and a developer-facing comment toSIDE_WORKFLOW_PATHS. It does not add or modify user-facing Swift text, web UI, metadata, API responses, rendered markdown, changelog content, or locale resources.
Full details: Cmux Swiftui State Layout
-
Explanation
PASS: The pull request changes only
scripts/ci/owned_pool_rescue.py. It adds.github/workflows/cmux-next-web.ymltoSIDE_WORKFLOW_PATHS. The diff contains no Swift or SwiftUI files, so the SwiftUI state-layout conditions do not apply.
Full details: Cmux Architecture Rethink
-
Explanation
The PR changes only
scripts/ci/owned_pool_rescue.py. It adds a workflow path and comment toSIDE_WORKFLOW_PATHS. The diff contains no Swift, UI lifecycle, timing, synchronization, observer, or state-ownership changes. The Swift architectural check is not applicable.
Full details: Cmux Swift Auxiliary Window Close Shortcuts
-
Explanation
PASS: The reviewed diff changes only
scripts/ci/owned_pool_rescue.pyand adds.github/workflows/cmux-next-web.ymltoSIDE_WORKFLOW_PATHS. It contains no Swift, NSWindow, NSPanel, NSWindowController, SwiftUIWindow, orWindowGroupchanges. The auxiliary-window close-shortcut rule is therefore not applicable.
Full details: Cmux Source Artifacts
-
Explanation
The PR changes only
scripts/ci/owned_pool_rescue.py. The diff adds a hand-written workflow-path entry and comment toSIDE_WORKFLOW_PATHS; it adds no logs, screenshots, recordings, temp directories, caches, build output, dependency checkout, or other artifact path. This is intentional CI configuration and matches the rule's pass category for source and config files.
Full details: Cmux No Test Or Debug Seam In Production Source
-
Explanation
PASS: The pull request changes only
scripts/ci/owned_pool_rescue.py. It adds a workflow path toSIDE_WORKFLOW_PATHSand changes no Swift file under a productionSources/path. The specified test/debug seam condition is not applicable.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
Review (subagent claude-opus-5-5 medium): SHIP at 954e984 No blocking findings. Follow-ups:
|
|
All contributors have signed the CLA ✍️ ✅ |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Merge receipt for
Labeled |
github-actions
Bot
added
the
merged-unverified
feat-cmux-next's
cmux-next-web.ymlcallsci-web.yml. In #30277, ci-web's six small jobs move offvars.LINUX_RUNNER's single 32 vCPU size, where a job of #30220 sat unassigned for over 20 minutes, onto the Linux poolfromJSON(vars.RUNNER_POOLS).linux.RUNNER_POOLScounts as an owned-pool variable, so #30277'scmux-next CI guard groupfailstest_every_owned_workflow_is_watched: "these workflows can take an owned pool but main's scripts/ci/owned_pool_rescue.py does not watch them ... .github/workflows/cmux-next-web.yml: calls ci-web.yml, whose job react-apps-check reads vars.RUNNER_POOLS".This PR adds the caller to
SIDE_WORKFLOW_PATHS, as the test asks ("a feat-cmux-next-only one too").Changelog
none
Observed / Not run
python3 -I tests/test_ci_owned_pool_sources.pypasses (9 tests, including the stale-entry check), andtests/test_ci_owned_pool_rescue.pypasses (448 tests). test_ci_late_placement and test_ci_classify_failures pass too.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds
cmux-next-web.ymlto the watched side workflows inscripts/ci/owned_pool_rescue.py. This workflow callsci-web.yml, whose small jobs read the Linux pool (vars.RUNNER_POOLS), so without this change the owned-pool watch test fails for the feat-cmux-next PR that moves those jobs off the 32 vCPU runner.Written for commit 954e984. Summary will update on new commits.
Summary by CodeRabbit