Repository navigation
Cloud: read current chat-start grant without opening another VM link (W2-15) - #30800
Closed
teamleaderleo wants to merge 3 commits into
Closed
teamleaderleo wants to merge 3 commits into
teamleaderleo wants to merge 3 commits into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
Owned by an agent session · session |
Collaborator
Author
|
Closing: this classic /api/vm work belongs in cmux-platform, not cmux. Continue it there if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W2-15 — backend prerequisite for delegated-chat revocation
Tracks HQ #5944 W2-15 and the source-backed finding on team-machine owner issue #5353. Classic backend owner prior art: merged #29217. Draft / no production deployment or merge requested.
Why
A teammate's NEXT Mac link keeps its attach-time
vmKind: ownerafter the creator deletes their chat grant. App code needs a current authorization answer before attempting another delegated chat start. ReusingPOST /api/vm/:id/attach-endpointto check that permission is wrong: the attach path can wake a VM, provision an endpoint, write a lease and record an attach event.Change
GET /api/vm/:id/chat-start-accesson the existing authenticated, billing/team-scoped classic VM route. Response:{"chatStart":"owner"|"granted"|"none"}for the requesting person only, withCache-Control: no-store.Review and deployment order
No cross-owner branches modified, no migrations, no permission expansion, no VM activity or production changes.
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds a read-only
GET /api/vm/:id/chat-start-accessendpoint so the Cloud app can check current chat-start authority before delegating another chat start, instead of trusting the stale attach-timeownerlabel on an existing link.owner,granted, ornonefor the requesting user only, withCache-Control: no-store.none.Written for commit 6c3fc56. Summary will update on new commits.