Repository navigation
NEXT: recheck delegated Cloud chat permission before new starts (W2-15) - #30805
Closed
teamleaderleo wants to merge 9 commits into
Closed
teamleaderleo wants to merge 9 commits into
teamleaderleo wants to merge 9 commits into
Conversation
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 1, 2026 10:54 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 1, 2026 10:55 — with
GitHub Actions
Inactive
|
Found 9 test failures on Blacksmith runners: Failures
|
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 3154610 to compare; do not merge until green; see lane-rules |
Collaborator
Author
|
Owned by an agent session · session |
Collaborator
Author
|
Closing: this classic /api/vm work belongs in cmux-platform, not cmux. Continue it there if still needed. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
W2-15 — fence stale delegated starts on an existing Cloud link
Dependent on backend cmux #30800, which must deploy before this Mac client change lands. Canonical finding: HQ #5353, and W2-15 full result. Draft; no merge/deploy requested.
User failure
Alice grants Bob chat-start permission on a team Cloud VM. Bob attaches: the link stores
vmKind: "owner". Alice revokes him. While his original link stays connected, Bob's NEXT app can still initiate a new cmux-managed chat using that stale answer. The existing Rust host gate only sees the answer carried by the old link.Slice
CloudAPIClient.chatStartAccess(id)performs read-only GET of the new backend's/api/vm/:id/chat-start-access(returns the caller'sowner | granted | none). It does not mint attach tokens or wake the machine.agent-session-start; an unavailable permission read fails closed. The original Cloud link's generation/owner check remains in place.ownerLink+ fresh denied grant sends no start, unreadable permission check sends no start, current grant still permits one start, and API client checks GET path / response without an attach.Limits / required proof
This closes the ordinary NEXT Mac's post-revoke new-start path only. The grant is still separately checked from the daemon's command admission, so revocation can race a just-authorized command, and CLI/other clients using a previously elevated link need a remote-server-validated, revocable action capability for complete fencing. Do not advertise instantaneous all clients revocation based on this slice alone. Team members also retain their separate shared-VM shell access.
Before review/merge: land/deploy #30800; run exact-head Swift tests (
AgentTabRemoteStartTests,CloudMachineShareTests) and an Alice/Bob two-identity runtime probe: grant, Bob attach/start A, Alice revoke, Bob start B without reconnect (must refuse), then Bob reconnect (must refuse), with network-read outage and account switch. Local full Mac test environment unavailable here; CI/runtime evidence still pending.No other owner's branch was overwritten and no production token, permission, spend or VM change was made.