Repository navigation
ci(web): run session info check in warn branch - #30333
teamleaderleo wants to merge 1 commit into
Conversation
|
Review (subagent): SHIP at 4b1a8c4 |
|
Review (subagent): SHIP at 4b1a8c4\n\nThe workflow-only diff adds the existing |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 7e1e768; does not block |
|
Closed as a duplicate of #30261, which fixes the same ci-web Session Info warn-branch red. |
|
Found 2 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
HOLD: duplicate of #30261; do not land.
The feat-cmux-next checks job was red because the webviews warn branch skipped the newly added
check:session-info-namespackage check. This left the aggregate structure test red even though the check could not run on the warn path.This wires
check:session-info-namesinto the existing warn-only loop. It keeps the samebun run ... || warningbehavior as the other style checks, while preserving the fail path for non-feat branches.Leo's standing rule is that display tests gate nothing; this repair is CI structure only and does not change display coverage.
Prior art: #29921 introduced
check:session-info-names; #24438 established thecheck:piecesand warn-branch split; #29666 and #28511 preserve the existing webview gate structure.Validation:
tests.test_cmux_next_checks_workflow.WebviewsWarnSplitCoversCheck.test_every_part_of_bun_run_check_runs_in_the_warn_branchpasses locally.Risk: CI workflow only; no product behavior or permissions change.
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
feat-cmux-nextchecks job by running thecheck:session-info-namescheck in the webviews warn branch, so the aggregate structure test no longer stays red when the check can't run on that path.The check joins the existing warn-only loop with the same
bun run ... || warningbehavior as the other style checks, while preserving the fail path for non-feat branches. Display tests still gate nothing; this is CI structure only.Written for commit 4b1a8c4. Summary will update on new commits.