Skip to content

ci(web): run session info check in warn branch - #30333

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
lane/stranded-checks-session-info-fix
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
lane/stranded-checks-session-info-fix

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

HOLD: duplicate of #30261; do not land.

The feat-cmux-next checks job was red because the webviews warn branch skipped the newly added check:session-info-names package check. This left the aggregate structure test red even though the check could not run on the warn path.

This wires check:session-info-names into the existing warn-only loop. It keeps the same bun run ... || warning behavior as the other style checks, while preserving the fail path for non-feat branches.

Leo's standing rule is that display tests gate nothing; this repair is CI structure only and does not change display coverage.

Prior art: #29921 introduced check:session-info-names; #24438 established the check:pieces and warn-branch split; #29666 and #28511 preserve the existing webview gate structure.

Validation:

  • tests.test_cmux_next_checks_workflow.WebviewsWarnSplitCoversCheck.test_every_part_of_bun_run_check_runs_in_the_warn_branch passes locally.
  • Fleet focused check will run on this PR.

Risk: CI workflow only; no product behavior or permissions change.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the feat-cmux-next checks job by running the check:session-info-names check in the webviews warn branch, so the aggregate structure test no longer stays red when the check can't run on that path.

The check joins the existing warn-only loop with the same bun run ... || warning behavior as the other style checks, while preserving the fail path for non-feat branches. Display tests still gate nothing; this is CI structure only.

Written for commit 4b1a8c4. Summary will update on new commits.

View guided diff Turn on auto-fix

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent): SHIP at 4b1a8c4

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent): SHIP at 4b1a8c4\n\nThe workflow-only diff adds the existing check:session-info-names script to the feat-cmux-next warn loop, preserving warning semantics and the non-feat fail path. The focused structure test passes.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 4b1a8c4: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr30333 -f ref=lane/stranded-checks-session-info-fix -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 7e1e768; does not block
red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / Web tests (1/4); no finished base run on 7e1e768 to compare; do not merge until green; see lane-rules

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closed as a duplicate of #30261, which fixes the same ci-web Session Info warn-branch red.

@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
nightly must build and hand off the macOS 26 helper and Xcode 26.5 app before publishin
g/
nightly must build and hand off the macOS 26 helper and Xcode 26.5 app before publishin
g
View Logs
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)/
test_the_nightly_is_covered (main.NightlyStepCoverageTests.test_the_nightly_is_cove
red)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 4b1a8c4b Deployed Nov 1, 2026 by teamleaderleo via wait for same-key tree publisher #94309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant