Skip to content

base red: ci-web's warn branch runs check:session-info-names (carry #29995) - #30261

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/warn-branch-session-info-names
Nov 1, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/warn-branch-session-info-names

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Base red: cmux-next checks (god files, concurrency, crash safety, l10n) fails on feat-cmux-next (push run 41276350825):

FAIL: test_every_part_of_bun_run_check_runs_in_the_warn_branch (WebviewsWarnSplitCoversCheck)
AssertionError: bun run check:session-info-names from webviews/package.json check does not run when CMUX_NEXT_STYLE_GUARDS=warn

#29921 added check:session-info-names to webviews' check:pieces but not to ci-web's warn-branch loop. This adds it to the loop beside check:switch-fetches. It carries #29995, which makes the same one-line change but now conflicts with base (base has since added check:surface-roles to that line, and this PR keeps it). #29995's owner lane has not answered the conflict note.

Check: python3 tests/test_cmux_next_checks_workflow.py gives failures=0 with this change and failures=1 on base. Both runs also show 14 KeyError: 'run' errors that come from this VM's environment.

Risk: low. One warn-only check is added to a loop whose failures only warn.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Adds check:session-info-names to ci-web's warn-branch loop so the check runs when CMUX_NEXT_STYLE_GUARDS=warn, fixing the failing WebviewsWarnSplitCoversCheck test on feat-cmux-next. The loop's failures only warn, so risk is low. This carries the one-line change from #29995 while keeping check:surface-roles that base added to the same line.

Written for commit dcb7c56. Summary will update on new commits.

View guided diff Turn on auto-fix

#29921 added check:session-info-names to webviews' check:pieces but not to
ci-web's warn-branch loop, so WebviewsWarnSplitCoversCheck fails on
feat-cmux-next. Keeps base's check:surface-roles in the same line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-5fdf0c7ee997e9834656
@cursor

cursor Bot commented Nov 1, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review dcb7c56: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr30261 -f ref=lane/warn-branch-session-info-names -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 6293c80; does not block

Shipped in:

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at 70c01ac

One-line change to ci-web's warn-branch loop in step webviews-check. check:session-info-names exists in webviews/package.json and resolves from webviews/ (it exits 0). No base check is dropped (check:surface-roles is kept). WebviewsWarnSplitCoversCheck passes. Findings: none.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over.


I found #30333 duplicated this exact fix. I have added a HOLD and will close the duplicate; #30261 remains the canonical repair. Its existing SHIP receipt and focused test cover the one-line warn-loop addition.

@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026

Copy link
Copy Markdown

Found 8 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpfavvyn_i/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpoimouiyw/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_cmux_next_follows_the_committed_target_graph (main.FocusedTestMap.test_cmux_ne
xt_follows_the_committed_target_graph)/
test_cmux_next_follows_the_committed_target_graph (main.FocusedTestMap.test_cmux_ne
xt_follows_the_committed_target_graph)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit 9a835ec into feat-cmux-next Nov 1, 2026
163 of 172 checks passed
@teamleaderleo
teamleaderleo deleted the lane/warn-branch-session-info-names branch November 1, 2026 07:37

This branch was previously deployed

1 inactive deployment
ci-routing-agent — dcb7c560 Deployed Nov 1, 2026 by cmux-bot[bot] via wait for same-key tree publisher #94210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant