Repository navigation
ci(web): webview tests run in 8 shards (about -10 min on every webview PR's gate) - #29666
Conversation
…er files On 16 vCPU each react-apps-check shard ran its ~100 dev-server files 4 at a time, 18-26 min of Test webviews per shard, the long pole for a webview fix from ask to merge. The base replay matches the head's 8 shards; merge-guard reads the declared matrix, and the durations and verdict jobs glob shards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
Owned by an agent session · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Review (codex gpt-6-astra high, router-review): BLOCK at 99498da BLOCK at 99498da Visual verdict: no images; Leo tries the build
|
…es them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
|
Review (codex, router-review): SHIP at 2a6d342 Reviewer: codex gpt-6-astra high, fast tier. SHIP at 2a6d342 Visual verdict: no images; Leo tries the build No correctness findings. Head/base matrices match, and artifact aggregation supports eight shards. All 53 focused Python tests passed. CI performance remains unverified locally. Follow-ups: none |
Leo (2026-10-31): "IF YOU DONT MERGE STUFF LIKE THAT WITHIN THE DAY THERE'D BETTER BE AN EXTREMELY GOOD REASON ... WITHIN 3 HOURS IF NEEDS CHANGES / WITHIN THE HOUR IF STRAIGHTFORWARD".
Why
Today's webview PRs spent most of their ask-to-merge time waiting on
web / react-apps-check (N). The webview verdict gate (react-apps-base-check) can't run until every head shard finishes. On 16 vCPU (#29033), each shard's "Test webviews" step runs its ~100 Vite dev-server files 4 at a time. That took 18-26 min per shard. For #29614 (removing the PR chip row), it was 29 of the 51 minutes from Leo's ask to the merge.What
react-apps-check-shardruns as 8 shards instead of 4, still on Blacksmith 16 vCPU, with the same 32 vCPU overflow.react-apps-base-checkuses the same 8 shards, one per head shard's results artifact.webviews-test-durationsand thereact-apps-checkverdict glob or aggregate whatever shards exist.webviews_test_shards.pytakes any count.Performance
web / react-apps-checkverdictThe head shards cost about the same in total, because dev-server files dominate and the per-shard setup is small. The base replay adds 4 short jobs (about 1.5 to 2 min each).
Warm sources: unchanged. Each shard restores the bun and Playwright caches, and the shard split reads the shared durations manifest.
Changelog
none
Observed / Not run
webview_expected_shards, the durations merge, the verdict aggregator).risk: CI-only (workflow matrix).
Agent session: agent session
🤖 Generated with Claude Code