Skip to content

fix(next): stabilize Settings numbers and action labels - #28487

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/aiforui-numbers-settings
Nov 1, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/aiforui-numbers-settings

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Leo's words (2026-10-29): "bro surely there are more takeaways than just ONE DRAFT PR — AND WHAT ABOUT THE OTHER RESEARCH????????? EVERY SINGLE OTHER THING ABOUT THE APP THE ASSOCIATED THINGS THE MORNING ISSUES/PRS ACROSS REPOS".

What changed

  • Apply font-variant-numeric: tabular-nums to changing Settings counts, durations, storage/phone totals, and editable numeric tokens.
  • Add a shared StableLabel wrapper that reserves the widest translated action label, keeping Check/Checking and Add/Added controls stable.
  • Add Settings gallery fixtures for idle, busy, and completed action states.

Course rule: the aiforui polish loop says counts use tabular numbers and a button keeps its width when its label changes, so nothing shifts. This implements that rule for the Settings surface.

Supersedes adopted Settings draft #27640; close that draft after this PR lands.

Captures

Gallery pages.settings at f9eff60 (before 6b830488 → after f9eff60c), scrolled to the changed controls.

variant theme before after
agents-stable-check-idle light
agents-stable-check-idle dark
agents-stable-check-busy light
agents-stable-check-busy dark
agents-stable-added light
agents-stable-added dark

Review

  • Independent exact-head code review at f9eff60: SHIP, no P1/P2/P3 findings.
  • Independent visual review at f9eff60 (aiforui-course; viewed after images: yes): ship it. On base, 'Check' at rest is narrower than 'Checking…', so Icon… and Remove jump when a check starts; here both hold one width and nothing moves. On base, 'Add' is narrower than 'Added'; here 'Add' already holds the 'Added' width.

Overlap

Existing Settings PRs #26770 and #25592 touch nearby files; this change is additive and does not edit their branches. Recent merged work in the same files: #28264, #26083 and the custom harness icon change.

Validation

  • Web lint and the focused Settings gallery test: not yet verified at this head.
  • CI: cmux-next swift test was killed twice (exit 143). The tests that failed in both runs are all native Swift suites this webview-only PR doesn't touch; a fleet run of those suites at this head and at base is in progress. web/react-apps-base-check has not finished.

agent session: agent session

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 352892a: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr28487 -f ref=lane/aiforui-numbers-settings -f platform=macos -f backend_mode=local

Gallery before/after for 352892a: 16 states rendered, 6 images differ, 318 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41219864038 -R manaflow-ai/cmux -n gallery-advisory-28487-352892a6b1d58a6b551f1a318ab19c67e33d4e06 (then read gallery-review.json)

States
State Theme Status Diff Picked by
pages.settings/agents-stable-check-idle Apple System Colors Light new 0% own AgentHarnesses.tsx
pages.settings/agents-stable-check-idle Apple System Colors new 0% own AgentHarnesses.tsx
pages.settings/agents-stable-check-busy Apple System Colors Light new 0% own AgentHarnesses.tsx
pages.settings/agents-stable-check-busy Apple System Colors new 0% own AgentHarnesses.tsx
pages.settings/agents-stable-added Apple System Colors Light new 0% own AgentHarnesses.tsx
pages.settings/agents-stable-added Apple System Colors new 0% own AgentHarnesses.tsx
pages.settings/general Apple System Colors Light unchanged 0% own AgentHarnesses.tsx
pages.settings/general Apple System Colors unchanged 0% own AgentHarnesses.tsx
pages.settings/general-customized Apple System Colors Light unchanged 0% own AgentHarnesses.tsx
pages.settings/general-customized Apple System Colors unchanged 0% own AgentHarnesses.tsx
pages.settings/general-group-1 Apple System Colors Light unchanged 0% own AgentHarnesses.tsx
pages.settings/general-group-1 Apple System Colors unchanged 0% own AgentHarnesses.tsx
pages.settings/general-group-2 Apple System Colors Light unchanged 0% own AgentHarnesses.tsx
pages.settings/general-group-2 Apple System Colors unchanged 0% own AgentHarnesses.tsx
pages.settings/general-group-3 Apple System Colors Light unchanged 0% own AgentHarnesses.tsx
pages.settings/general-group-3 Apple System Colors unchanged 0% own AgentHarnesses.tsx
agent-pane.send-scroll-setting/settings-on Apple System Colors Light unchanged 0% imports layout.css (2 hops)
agent-pane.send-scroll-setting/settings-on Apple System Colors unchanged 0% imports layout.css (2 hops)
agent-pane.send-scroll-setting/composer-off Apple System Colors Light unchanged 0% imports layout.css (2 hops)
agent-pane.send-scroll-setting/composer-off Apple System Colors unchanged 0% imports layout.css (2 hops)
agent-pane.send-scroll-setting/settings-and-composer Apple System Colors Light unchanged 0% imports layout.css (2 hops)
agent-pane.send-scroll-setting/settings-and-composer Apple System Colors unchanged 0% imports layout.css (2 hops)
agent-pane.send-scroll-setting/settings-off Apple System Colors Light unchanged 0% imports layout.css (2 hops)
agent-pane.send-scroll-setting/settings-off Apple System Colors unchanged 0% imports layout.css (2 hops)
pages.settings.choice-or-url/hosted Apple System Colors Light unchanged 0% imports layout.css (2 hops)
pages.settings.choice-or-url/hosted Apple System Colors unchanged 0% imports layout.css (2 hops)
pages.settings.choice-or-url/self-hosted Apple System Colors Light unchanged 0% imports layout.css (2 hops)
pages.settings.choice-or-url/self-hosted Apple System Colors unchanged 0% imports layout.css (2 hops)
pages.settings.choice-or-url/refused Apple System Colors Light unchanged 0% imports layout.css (2 hops)
pages.settings.choice-or-url/refused Apple System Colors unchanged 0% imports layout.css (2 hops)
pages.settings.choice-or-url/disabled Apple System Colors Light unchanged 0% imports layout.css (2 hops)
pages.settings.choice-or-url/disabled Apple System Colors unchanged 0% imports layout.css (2 hops)

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at f9eff60

No blocking findings. The label wrapper preserves accessible names and reserves space for both states; numeric styling is narrowly scoped.

Review was limited to the supplied diff and source files; tests and gallery captures were not run.

cmux-bot[bot]
cmux-bot Bot previously approved these changes Oct 30, 2026

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves f9eff60: an independent review passed this exact head (next-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@cmux-bot
cmux-bot Bot dismissed their stale review October 30, 2026 23:20

A newer verdict blocks f9eff60 (a HOLD line in the body).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Orphaned: no activity for 15 h, and no lane holds a lease on it. The orphan sweep could not merge feat-cmux-next in: conflicts in webviews/src/pages/settings/styles.css. Listed for a lane to resolve.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at 352892a

SHIP at 352892a

Visual verdict: supplied light/dark before/after captures inspected; no visible regression.

Follow-ups: none

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 352892a: an independent review passed this exact head (next-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo
teamleaderleo merged commit 4085357 into feat-cmux-next Nov 1, 2026
192 checks passed
@teamleaderleo
teamleaderleo deleted the lane/aiforui-numbers-settings branch November 1, 2026 02:36

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 352892a6 Deployed Oct 31, 2026 by teamleaderleo via cmux-tui tree preflight #90544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant