Repository navigation
fix(next): stabilize Settings numbers and action labels - #28487
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
|
Review (codex gpt-6-astra high, next-review): SHIP at f9eff60 No blocking findings. The label wrapper preserves accessible names and reserves space for both states; numeric styling is narrowly scoped. Review was limited to the supplied diff and source files; tests and gallery captures were not run. |
A newer verdict blocks f9eff60 (a HOLD line in the body).
|
Orphaned: no activity for 15 h, and no lane holds a lease on it. The orphan sweep could not merge |
Leo's words (2026-10-29): "bro surely there are more takeaways than just ONE DRAFT PR — AND WHAT ABOUT THE OTHER RESEARCH????????? EVERY SINGLE OTHER THING ABOUT THE APP THE ASSOCIATED THINGS THE MORNING ISSUES/PRS ACROSS REPOS".
What changed
font-variant-numeric: tabular-numsto changing Settings counts, durations, storage/phone totals, and editable numeric tokens.StableLabelwrapper that reserves the widest translated action label, keeping Check/Checking and Add/Added controls stable.Course rule: the aiforui polish loop says counts use tabular numbers and a button keeps its width when its label changes, so nothing shifts. This implements that rule for the Settings surface.
Supersedes adopted Settings draft #27640; close that draft after this PR lands.
Captures
Gallery
pages.settingsat f9eff60 (before6b830488→ afterf9eff60c), scrolled to the changed controls.agents-stable-check-idleagents-stable-check-idleagents-stable-check-busyagents-stable-check-busyagents-stable-addedagents-stable-addedReview
Overlap
Existing Settings PRs #26770 and #25592 touch nearby files; this change is additive and does not edit their branches. Recent merged work in the same files: #28264, #26083 and the custom harness icon change.
Validation
cmux-next swift testwas killed twice (exit 143). The tests that failed in both runs are all native Swift suites this webview-only PR doesn't touch; a fleet run of those suites at this head and at base is in progress. web/react-apps-base-check has not finished.agent session: agent session