Repository navigation
fix(settings): keep row content in shared main layout - #28264
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for web and size checks: green |
|
Found 2 test failures on Blacksmith runners: Failures
|
|
Review (codex gpt-6-astra high, next-review): BLOCK at 40a1bd5
|
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (codex gpt-6-astra high, next-review): BLOCK at 232bf01
|
232bf01 to
abb0d96
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
abb0d96 to
aa8cd3d
Compare
|
Review (codex gpt-6-astra high, next-review): SHIP at aa8cd3d No blocking findings. |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Gallery: pages.settings/machines-row-shape, pages.settings/cloud-environments-row-shape
Keep Settings rows structurally consistent by placing environment labels and controls, plus the machine color control, inside the shared
.row-mainwrapper. Machine VM-host content remains in the row's below slot so it stays a full-width secondary line, while preserving the grid owner's geometry contract indesign/grid.md.Leo, 2026-10-28: “I feel like you guys could be doing more audits of the app. Like there's some amount of, like, satisfying and pretty stuff that can happen that we're not quite taking full advantage of.”
Visual evidence: gallery advisory runs the focused machines-row-shape and cloud-environments-row-shape variants capture the before/after rows at 2x in light and dark.
Before / after
Gallery fixtures
pages.settings/machines-row-shapeandpages.settings/cloud-environments-row-shape, Chromium, 2x. Before is base 49c648c plus only the fixture commit (gallery run 41101102001); after is head aa8cd3d (gallery run 41096877026).Before, the machine colour swatch and Automatic button fell to their own line under the label, away from the status dot, and the Cloud Environments Build and Delete buttons dropped below the log toggle. After, both sit on the label's line like every other Settings row, and the VM toggle stays a full-width lower row.
Viewed after image: yes
Visual verdict: Yes, both rows now read like the rest of Settings with controls on the label's line and no clipping or overflow in either theme, so Leo would accept them next to ChatGPT/Claude.
Validation: git diff --check passed. Independent review (gpt-6-astra, high): SHIP at aa8cd3d.
Risk: contained to shared Settings row structure; no inset or gap values changed.
Agent session: agent session