Skip to content

Keep webview counts and numeric settings on tabular figures - #27640

Closed
teamleaderleo wants to merge 4 commits into
feat-cmux-nextfrom
lane/aiforui-numeric-layout
Closed

teamleaderleo wants to merge 4 commits into
feat-cmux-nextfrom
lane/aiforui-numeric-layout

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Numeric values in Home, the inspector, settings and rejected-change summaries now request tabular figures, so equal-length values keep consistent digit widths. Settings inputs and their hidden sizing copies use the same feature.

Leo, 2026-10-29:

"I think you guys should just keep going indefinitely. Like just, there's so much random nonsense that you can probably associate every single one of his pointers to one of our situations."

Earlier:

"https://aiforui.dev/learn ... you guys should be taking this course and then reading into how it goes."

Course rule per change: item 10, stable layout — counts, timers and numeric totals use tabular numbers. Design grid rule 8 says the same for counts and timers.

Audit

File:line Rule Before After
webviews/src/agent-session/acpmux/styles.css:375 Course 10 Home ages inherit proportional figures Tabular figures
webviews/src/agent-session/acpmux/inspector/inspector.css:934 Course 10 Collapsed group counts inherit proportional figures Tabular figures after the font shorthand
webviews/src/agent-session/acpmux/inspector/inspector.css:960 Course 10 Ended-subagent summary counts inherit proportional figures Tabular figures scoped to the inspector
webviews/src/agent-session/acpmux/inspector/WorkflowTasks.css:8 Course 10 Mixed workflow group counts inherit proportional figures Tabular figures
webviews/src/pages/settings/styles.css:440 Course 10 Numeric input and hidden sizing copy inherit proportional figures Both request matching tabular figures
webviews/src/pages/settings/layout.css:525 Course 10 Token contrast ratio inherits proportional figures Tabular figures
webviews/src/pages/settings/layout.css:753 Course 10 Theme result count inherits proportional figures Tabular figures
webviews/src/agent-session/acpmux/changes/changes.css:102 Course 10 Rejected-change count inherits proportional figures Tabular figures

Validation

  • Local full web lint and pre-push checks pass.
  • Regression committed before the fix. The manual browser script renders actual gallery screens in light/dark at 480/1000px, verifies the computed feature (including the hidden sizer) and measures an input through equal-length edits. It adds no CI job or gate.
  • Remote validation blocked: the broker returned busy: another call on the cmux-ci job records is still running; nothing was done, retry shortly. No test run was created. Red/green, screenshots, UI inspection, and independent review remain pending; this PR stays draft.
  • Published head: ac1b94d42688dbb3416c3414a59149222b0f4449.

UI review

Verdict: blocked pending rendered before/after inspection.

Blockers: remote gallery evidence pending.
Should fix: none identified in the source audit.
Nits: none.
Needs a device: none; webview-only numeric typography.

Risk

Normal: numeric glyph widths can change in fonts whose default figures are proportional. Values that gain a digit still need more room; this change does not reserve arbitrary maximum counts.

Changelog

Changed: Keep numeric values visually stable in Home, the inspector, settings and rejected-change summaries.

Agent session: agent session

Manual browser regression committed before the numeric style fix. Remote red/green execution follows after the draft PR is pushed. Local webviews bun run check passes.

Agent-Session: https://cmux.com/deeplink/agent?id=aid-d8b8981392645c33e484
Apply course stable-layout rule to Home ages, inspector counts, rejected changes, and settings numeric controls. The input and its hidden sizer share the same numeric feature. Local web lint passes; remote gallery red/green follows on the draft PR.

Agent-Session: https://cmux.com/deeplink/agent?id=aid-d8b8981392645c33e484
@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on e7ab659 to compare; do not merge until green; see lane-rules

@blacksmith-sh

blacksmith-sh Bot commented Oct 29, 2026

Copy link
Copy Markdown

Found 7 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpj_usovk5/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmprbfxz049/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing: superseded by #28487, which carried this Settings tabular-figures work and merged.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — ac1b94d4 Deployed Oct 29, 2026 by teamleaderleo via cmux-tui tree preflight #78614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant