Repository navigation
Keep webview counts and numeric settings on tabular figures - #27640
Closed
teamleaderleo wants to merge 4 commits into
Closed
teamleaderleo wants to merge 4 commits into
teamleaderleo wants to merge 4 commits into
Conversation
Manual browser regression committed before the numeric style fix. Remote red/green execution follows after the draft PR is pushed. Local webviews bun run check passes. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d8b8981392645c33e484
Apply course stable-layout rule to Home ages, inspector counts, rejected changes, and settings numeric controls. The input and its hidden sizer share the same numeric feature. Local web lint passes; remote gallery red/green follows on the draft PR. Agent-Session: https://cmux.com/deeplink/agent?id=aid-d8b8981392645c33e484
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on e7ab659 to compare; do not merge until green; see lane-rules |
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 29, 2026 22:27 — with
GitHub Actions
Inactive
|
Found 7 test failures on Blacksmith runners: Failures
|
Collaborator
Author
|
Closing: superseded by #28487, which carried this Settings tabular-figures work and merged. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Numeric values in Home, the inspector, settings and rejected-change summaries now request tabular figures, so equal-length values keep consistent digit widths. Settings inputs and their hidden sizing copies use the same feature.
Leo, 2026-10-29:
Earlier:
Course rule per change: item 10, stable layout — counts, timers and numeric totals use tabular numbers. Design grid rule 8 says the same for counts and timers.
Audit
webviews/src/agent-session/acpmux/styles.css:375webviews/src/agent-session/acpmux/inspector/inspector.css:934webviews/src/agent-session/acpmux/inspector/inspector.css:960webviews/src/agent-session/acpmux/inspector/WorkflowTasks.css:8webviews/src/pages/settings/styles.css:440webviews/src/pages/settings/layout.css:525webviews/src/pages/settings/layout.css:753webviews/src/agent-session/acpmux/changes/changes.css:102Validation
busy: another call on the cmux-ci job records is still running; nothing was done, retry shortly. No test run was created. Red/green, screenshots, UI inspection, and independent review remain pending; this PR stays draft.ac1b94d42688dbb3416c3414a59149222b0f4449.UI review
Verdict: blocked pending rendered before/after inspection.
Blockers: remote gallery evidence pending.
Should fix: none identified in the source audit.
Nits: none.
Needs a device: none; webview-only numeric typography.
Risk
Normal: numeric glyph widths can change in fonts whose default figures are proportional. Values that gain a digit still need more room; this change does not reserve arbitrary maximum counts.
Changelog
Changed: Keep numeric values visually stable in Home, the inspector, settings and rejected-change summaries.
Agent session: agent session