Repository navigation
acpmux: add opt-in managed Codex runtime - #28211
Conversation
|
Found 3 test failures on Blacksmith runners: Failures
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green Shipped in:
|
|
Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at d4dec32 BLOCK
|
|
Owned by an agent session · session |
…x runtime Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9a907b0826c8a21d4de9
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9a907b0826c8a21d4de9
|
Review (codex-review-box/gpt-6-astra high, lane-place): BLOCK at b75bfb4 BLOCK
Build verification was unavailable because |
|
Review (codex-review-box/gpt-6-astra high, lane-place on a fleet lane host; posted by the research overseer because the box host could not write to GitHub): BLOCK at 4971b29 BLOCK
|
…d probe the managed binary Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9a907b0826c8a21d4de9
|
Review (codex-review-box/gpt-6-astra high, lane-place on a fleet lane host; posted by the research overseer because the box host could not write to GitHub): BLOCK at f37049c BLOCK
|
…ck in discovery Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-9a907b0826c8a21d4de9
|
Review (codex-review-box/gpt-6-astra high, lane-place on a fleet lane host; posted by the research overseer because the box host could not write to GitHub): SHIP at dcb9017 SHIP at dcb9017 Visual verdict: no images; Leo tries the build No findings. Static review completed; manifests parse successfully. Rust tests could not run because Rust tooling is unavailable. Follow-ups: none |
|
Review (codex gpt-6-astra high, next-review): SHIP at f300541 SHIP at f300541 Visual verdict: no images; Leo tries the build No correctness findings. Reviewed installation, activation, cleanup, discovery precedence, and launch integration. TOML validation passed. Rust tests and release downloads could not be verified: Cargo and network access were unavailable. Follow-ups: none |
A newer verdict blocks 2a9a230 (no independent SHIP at the head).
|
Review (next-review patch-id; carried): SHIP at 2a9a230 The independent SHIP at f300541 carries to this head: the PR's own change ( |
…d-codex-runtime-min
|
Review (next-review patch-id; carried): SHIP at a7b2154 The independent SHIP at f300541 carries to this head: the PR's own change ( |
…d-codex-runtime-min
|
Review (codex-review-box/gpt-6-astra high, lane-place on a fleet lane host; posted by the research overseer because the box host could not write to GitHub): SHIP at d9e7a7e SHIP at d9e7a7e Visual verdict: no images; Leo tries the build No findings. Static review completed; TOML parsing and pinned-value consistency checks passed. Rust tests were unavailable because the box has no Rust toolchain. Follow-ups: none |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Adds the first opt-in managed Codex runtime slice for NEXT. Harnesses can explicitly run
cmux harness codex-runtime installorstatus; the installer downloads the official v0.156.1 macOS archive, verifies the SHA-256 pinned beside the Codex harness manifest, stages and atomically activates a versioned binary under acpmux support storage, and discovery falls back to it only when nocodexis on PATH. Existing profiles and PATH installations remain authoritative.Prior art reviewed: #26333 (harness fixtures), #21568 (selected installation remains stable during Bun updates), #21439 (trusted Settings agent updates), and #3624 (cmux harness add/list/doctor/reload). Nearby Codex PRs #24428, #24490, #21278, #856, #4048, #18302 and #26106 do not bundle or manage a Codex runtime.
This slice deliberately excludes app bundling, signing/notarization, update/removal, and profile migration; those follow-up concerns need release packaging work.
Agent-Session: deeplink/agent?id=aid-eb216cbafc54de38a870
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Adds an opt-in managed Codex runtime for acpmux.
cmux harness codex-runtime installdownloads the official Codex v0.156.1 macOS archive, verifies its SHA-256 against the hashes pinned in the Codex harness manifest, and atomically activates it by swapping acurrentsymlink with one rename, so the runtime path stays valid at every instant and a crash leaves either the old or the new install. A successful install tells a running daemon to read its profiles again, andcmux harness codex-runtime statusprints the runtime state. Activation is Unix-only, and install directories are pruned only when nothing names them and they are over an hour old, so a concurrent install is never removed mid-swap.The managed binary is used only when a readiness marker records the same pinned version and archive hash, so an interrupted or stale install never activates. It never overrides a
codexalready on PATH, so existing PATH installations, profiles, and explicit configuration stay authoritative. App bundling, signing/notarization, update/removal, and profile migration are deliberately excluded and will follow in release packaging work.Written for commit d9e7a7e. Summary will update on new commits.