Repository navigation
fix(next): contain project and environment dropdowns - #26945
teamleaderleo wants to merge 58 commits into
Conversation
|
Bead |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; base red: the same failure on the base 3a7653b; does not block Gallery before/after for
States
Pick other states with a |
|
Found 33 test failures on Blacksmith runners: Failures
...and 23 more test failures. View all on Blacksmith
|
|
Review (codex gpt-6-astra high, next-review): BLOCK at cb669ab
|
|
Orphaned: no activity for 14 h, and no lane holds a lease on it. The orphan sweep could not merge |
|
Owned by an agent session · session |
|
Closing as superseded. #26536 (0b6bb12) already landed the pinned actions and in-menu scrollbars, and #27146 (59fa54b) landed the down-first location menus this PR describes. This branch would also undo work that has since landed: #26739 (question card styles), #26874 (paused Cloud machine banner), #26551 (New Tab footer and its refit test), #26850 (FolderPopover tooltip), and the deliberatelyHighlighted handling from #26536. Anything still wanted (current environment and project first, the scratch-folder filter, the monogram badge) should be a fresh small PR off feat-cmux-next, on top of the composer-context-top preferred-side work. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Project and environment dropdown containment
Follow-up replacement for #26636's project/environment menu containment work. Menus use shared down-first placement, flip above only when below truly lacks room, and keep folder/project result viewports inside their popup in short windows. Project galleries keep 3/8/15 rows visibly distinct with bounded scrolling; environment and folder lists remain reachable. Model-picker behavior is unchanged.
The implementation preserves the existing pinned-action keyboard collection and scrollbar behavior. It uses flex
min-height: 0and bounded nested viewports so popup bounds, not intrinsic list height, control layout.Leo's direction: “For these left two dropdowns, we want to make it not cover the, you know, not open upwards, right? Like if you see the other dropdowns, you'll note that they open downwards, aka away from the chat. They don't hide the chat.”
Gallery/design work from #26636 is retained in
design/composer-menus.md, with aligned, airy and quiet-icon variants.Base:
feat-cmux-nextHead:
cb669ab23044eb3d8f8ac240164bbbc836593a04Validation pending on the exact head: focused containment tests and web check through cmux-ci. Native captures are not required for this webview-only change.
Changelog
Changed: keep project and environment dropdowns contained and down-first while preserving keyboard and scrollbar behavior.
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Changes the composer's project and environment dropdowns to open downward, away from the chat, instead of upward, and keeps their result lists contained inside the popup in short windows. Placement flips above only when the space below is too small.
Written for commit cb669ab. Summary will update on new commits.