Repository navigation
fix(next): prefer below placement for location pickers - #27146
Merged
Merged
Conversation
Use the shared below-when-room rule for composer and New Tab location menus, with coverage for both the no-room fallback and the case where both sides fit. Agent-Session: https://cmux.com/deeplink/agent?id=aid-473709fdc57414b4a54b
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a |
Collaborator
Author
|
Bead |
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Location pickers now prefer opening below their trigger whenever the full menu fits, flipping above only when below has no room or less available space. The chosen side remains fixed while rows filter or refresh.
Adds a gallery regression for both sides fitting, while retaining the existing no-room-above side-stability coverage.
Changelog
Changed
Validation:
git diff --checkpassed. Managed Chromium gallery execution completed for the exact head; local Chromium was not run.Lawrence: “context menus should show below if possible”.
Managed Chromium capture (exact head)
Receipt: gallery advisory run 40795863363, artifact
gallery-advisory-27146-efcb2d1533e146e1866f26c37a15295e7119390c. The artifact contains the exact light/dark before/after paths below (Chromium, narrow component width):base/agent-pane.composer-context-side--filter-keeps-side--en--Apple_System_Colors_Light--w400-chromium.png; light after:head/agent-pane.composer-context-side--filter-keeps-side--en--Apple_System_Colors_Light--w400-chromium.png.base/agent-pane.composer-context-side--filter-keeps-side--en--Apple_System_Colors--w400-chromium.png; dark after:head/agent-pane.composer-context-side--filter-keeps-side--en--Apple_System_Colors--w400-chromium.png.head/agent-pane.composer-context-side--below-when-room--en--Apple_System_Colors_Light--w400-chromium.png; dark:head/agent-pane.composer-context-side--below-when-room--en--Apple_System_Colors--w400-chromium.png.Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Location pickers in the composer and New Tab now prefer opening below their trigger whenever the full menu fits, flipping above only when below has no room or less available space. The chosen side stays fixed while rows filter or refresh.
Written for commit efcb2d1. Summary will update on new commits.