test(dev): every DEV publisher job takes no concurrency group by teamleaderleo · Pull Request #26030 · manaflow-ai/cmux

teamleaderleo · 2026-10-27T07:44:19Z

On main, tests/test_nightly_delivery_concurrency.py already fails if publish or the tip jobs in cmux-next-dev-daily.yml get a concurrency group. But sign, runner, verify and rcodesign-dmg were not listed, so nothing stopped a group from coming back on them. A group evicts the older pending run, and that is how nothing published from 00:13Z for over six hours on 2026-10-26. This PR lists every job in the workflow. None has a group today, so the test passes; adding one to any of them now fails it.

The companion PR #26027 removes the two groups still left in feat-cmux-next's copy of the workflow.

Test-only change. Risk: none.

Agent session: agent session

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by CodeRabbit

Tests
- Expanded automated checks for nightly delivery workflows to verify that additional jobs do not run with concurrency groups configured. This strengthens coverage of delivery pipeline behavior; no user-facing functionality changed.

The guard listed only publish and the tip jobs; sign, runner, verify and rcodesign-dmg had no group but nothing kept one from coming back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cc8bff1c3ddb4ec353c5

cursor · 2026-10-27T07:44:24Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

github-actions · 2026-10-27T07:44:30Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

teamleaderleo · 2026-10-27T07:44:59Z

Owned by an agent session · session

blacksmith-sh · 2026-10-27T07:47:12Z

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
`test_every_owned_workflow_is_watched (main.OwnedPoolSources.test_every_owned_workfl` `ow_is_watched) (tree='origin/feat-cmux-next')`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

cmux-bot · 2026-10-27T07:47:24Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Probably yours: CI fast guards failed: a guard step failed, FAIL 10.7s workflow-guard-tests / ci: Validate that the persistent-pool rescue watches every owned-p....

CI failed on 42c3180534 (run 40468923957 attempt 1): 1 code.

Job	Verdict	Why
CI fast guards	code	a guard step failed

Matched log lines

CI fast guards: FAIL   10.7s  workflow-guard-tests / ci: Validate that the persistent-pool rescue watches every owned-pool workflow

Not re-run automatically: CI fast guards is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

CI fast guards failed on 42c3180534 (https://github.com/manaflow-ai/cmux/actions/runs/40468923957). It does not block the merge; a red guard merged into main breaks it for every open PR.

`Validate that the persistent-pool rescue watches every owned-pool workflow` (red on main too, not this PR)

Main has failed this step since #25913 by @teamleaderleo (self-merged) (#25921). Merge main again once the fix lands there.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

Merge receipt for 42c3180534, merged 2026-10-27 07:50:23 UTC

Not verified at merge: ci-status (failure), CI fast guards (failure)
Verified: backend migrations applied, CI timing, Fast static checks, guards (7), merge freeze, plan, web-validation
Skipped by policy: apply-production, apply-staging, browser, Claude wrapper regressions, close lapsed freezes, Dogfood build #${{ github.event.pull_request.number }}, GhosttyKit release check, linux-preflight, macos, macOS admission gate, remote-daemon, suite-coverage, and 5 more
Full suite: runs on main after merge.

Labeled merged-unverified: if main breaks near this merge, look here first.

coderabbitai · 2026-10-27T07:48:08Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: manaflow-ai/cmux
Branch: dev-daily-no-groups-main
File: .coderabbit.yaml
Commit: 42c3180
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: f1edc0eb-6e2c-4e1d-b800-cd3212087625

Commits

Reviewing files that changed from the base of the PR and between cd52518 and 42c3180.

Files selected for processing: 1

tests/test_nightly_delivery_concurrency.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

The nightly delivery concurrency test now checks that sign, runner, verify, and rcodesign-dmg have no concurrency groups.

Changes: Nightly delivery concurrency checks

Layer / File(s)	Summary
Expand the no-group check `tests/test_nightly_delivery_concurrency.py`	The `NO_CONCURRENCY_GROUP` list now includes `sign`, `runner`, `verify`, and `rcodesign-dmg` for `cmux-next-dev-daily.yml`.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related issues

Issue 25056: The issue describes cancellation of nightly delivery stages, including signing and verification. This change adds checks for those jobs.

Possibly related PRs

manaflow-ai/cmux#25552: Introduced the NO_CONCURRENCY_GROUP mapping and its test.
manaflow-ai/cmux#25673: Extended the same check to the tip-dmg job.
manaflow-ai/cmux#25371: Removed the concurrency group from the sign job, which this change now checks.

Merge Risk: Minimal · up to 42c31

This test-only change is safe to merge.

Pre-merge checks: 24 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description explains the problem, implementation, scope, and reported risk, but it omits the required Summary, Testing, Changelog, Proof, and Checklist sections. It also does not name a test comma…	Add the required template sections. Include the exact test command and result, state the changelog entry as an internal test change or none, add a Proof line explaining why screenshots are not applicable, and complete or justify the checkli…

Passed checks: 24 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: extending the test to require no concurrency group for every DEV publisher job.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input		The pull request changes only `tests/test_nightly_delivery_concurrency.py`. It adds four workflow job names to `NO_CONCURRENCY_GROUP` and updates its comment. It does not change Cloud terminal creatio…
Cmux Swift Actor Isolation		PASS: The pull request changes only the Python test file `tests/test_nightly_delivery_concurrency.py`. It introduces no production Swift changes and therefore no Swift actor-isolation mistake.
Cmux Swift Blocking Runtime		PASS: The pull request changes only `tests/test_nightly_delivery_concurrency.py`. It adds job names to a Python test list and introduces no production Swift code or blocking/timing synchronization.
Cmux Browser Automation Off-Main		The pull request changes only tests/test_nightly_delivery_concurrency.py. It adds workflow job names to NO_CONCURRENCY_GROUP and changes no browser socket automation code, routing, WebKit/AppKit acces…
Cmux Expensive Synchronous Load		PASS: The pull request changes only `tests/test_nightly_delivery_concurrency.py`, a Python test. It adds job names to `NO_CONCURRENCY_GROUP` and does not modify production Swift or add an expensive sy…
Cmux Cache Substitution Correctness		The pull request changes only `tests/test_nightly_delivery_concurrency.py`. It adds job names to a Python test constant and does not change production Swift, TypeScript, or JavaScript code, persistenc…
Cmux No Hacky Sleeps		PASS: The PR changes only the Python test `tests/test_nightly_delivery_concurrency.py`. It adds job names and comments to `NO_CONCURRENCY_GROUP`; it introduces no sleep, timer, polling, fixed delay, o…
Cmux Algorithmic Complexity		The pull request changes only `tests/test_nightly_delivery_concurrency.py`. The added entries extend a test fixture tuple and do not modify production Swift, TypeScript, JavaScript, shell, or runtime …
Cmux Swift Concurrency		The pull request changes only `tests/test_nightly_delivery_concurrency.py`, a Python test. It adds job names and comments to `NO_CONCURRENCY_GROUP`; it introduces no cmux-owned Swift code or legacy Sw…
Cmux Swift `@Concurrent`		PASS: The pull request changes only the Python test file `tests/test_nightly_delivery_concurrency.py`. The diff contains no Swift or Objective-C++ files and introduces no Swift async functions or `@co…
Cmux Swift Package Boundaries		The pull request changes only `tests/test_nightly_delivery_concurrency.py`. It adds test coverage for workflow job names and introduces no production Swift or SwiftPM boundary change.
Cmux Swiftpm Lockfiles		PASS: The PR changes only `tests/test_nightly_delivery_concurrency.py`. It does not change a SwiftPM package, Xcode project, `.gitignore`, workflow, or dependency declaration. The SwiftPM lockfile pol…
Cmux Swift Logging		The diff changes only `tests/test_nightly_delivery_concurrency.py`, a Python test. It adds job names and a test comment. It adds no Swift code or logging statements, and the logging rule explicitly al…
Cmux User-Facing Error Privacy		The pull request changes only `tests/test_nightly_delivery_concurrency.py`. It adds test coverage for four workflow jobs and does not change production user-facing errors or recovery copy. The custom …
Cmux Full Internationalization		The pull request changes only `tests/test_nightly_delivery_concurrency.py`. It adds test coverage for workflow job names and a developer-only comment. The diff adds no production UI text, localization…
Cmux Swiftui State Layout		The pull request changes only tests/test_nightly_delivery_concurrency.py, a Python test. It introduces no SwiftUI code, ObservableObject or `@Published` state, GeometryReader measurement, lazy/list row …
Cmux Architecture Rethink		PASS: The PR changes only the Python test `tests/test_nightly_delivery_concurrency.py`. It adds job names to `NO_CONCURRENCY_GROUP` and does not introduce Swift code, timing repairs, mutable state, ob…
Cmux Swift Auxiliary Window Close Shortcuts		PASS: The pull request changes only `tests/test_nightly_delivery_concurrency.py`, a Python test. It adds job names to `NO_CONCURRENCY_GROUP` and adds no Swift or cmux-owned window code. The auxiliary-…
Cmux Source Artifacts		The only changed path is `tests/test_nightly_delivery_concurrency.py`. The diff adds test coverage and comments to an existing hand-written test file. It does not add local output, generated artifacts…
Cmux No Test Or Debug Seam In Production Source		The pull request changes only `tests/test_nightly_delivery_concurrency.py`, a Python test file. It changes the `NO_CONCURRENCY_GROUP` test data and adds no Swift file or production `Sources/` change. …

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Full details: Cmux Cloud Persistent Session And Early Input

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py. It adds four workflow job names to NO_CONCURRENCY_GROUP and updates its comment. It does not change Cloud terminal creation, cmux-tui transport, manual panes, runtime admission, input routing, authentication, idempotency, revision fences, or leases. The custom check is therefore not triggered.

Full details: Cmux Browser Automation Off-Main

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py. It adds workflow job names to NO_CONCURRENCY_GROUP and changes no browser socket automation code, routing, WebKit/AppKit access, or policy tests. The browser automation rule therefore has no applicable failure condition.

Full details: Cmux Expensive Synchronous Load

Explanation

PASS: The pull request changes only tests/test_nightly_delivery_concurrency.py, a Python test. It adds job names to NO_CONCURRENCY_GROUP and does not modify production Swift or add an expensive synchronous agent-history load.

Full details: Cmux Cache Substitution Correctness

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py. It adds job names to a Python test constant and does not change production Swift, TypeScript, or JavaScript code, persistence, history, undo, or snapshot reads. The cache-substitution condition does not apply.

Full details: Cmux No Hacky Sleeps

Explanation

PASS: The PR changes only the Python test tests/test_nightly_delivery_concurrency.py. It adds job names and comments to NO_CONCURRENCY_GROUP; it introduces no sleep, timer, polling, fixed delay, or wall-clock wait. The custom check targets covered production TypeScript, JavaScript, shell, and non-Swift build/runtime changes, and explicitly allows deterministic test scaffolding.

Full details: Cmux Algorithmic Complexity

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py. The added entries extend a test fixture tuple and do not modify production Swift, TypeScript, JavaScript, shell, or runtime code. The algorithmic-complexity rule explicitly passes test-only scaffolding.

Full details: Cmux Swift Concurrency

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py, a Python test. It adds job names and comments to NO_CONCURRENCY_GROUP; it introduces no cmux-owned Swift code or legacy Swift async pattern.

Full details: Cmux Swift `@Concurrent`

Explanation

PASS: The pull request changes only the Python test file tests/test_nightly_delivery_concurrency.py. The diff contains no Swift or Objective-C++ files and introduces no Swift async functions or @concurrent annotations. The Swift concurrency check is therefore not applicable.

Full details: Cmux Swiftpm Lockfiles

Explanation

PASS: The PR changes only tests/test_nightly_delivery_concurrency.py. It does not change a SwiftPM package, Xcode project, .gitignore, workflow, or dependency declaration. The SwiftPM lockfile policy therefore has no applicable failure condition.

Full details: Cmux Swift Logging

Explanation

The diff changes only tests/test_nightly_delivery_concurrency.py, a Python test. It adds job names and a test comment. It adds no Swift code or logging statements, and the logging rule explicitly allows tests.

Full details: Cmux User-Facing Error Privacy

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py. It adds test coverage for four workflow jobs and does not change production user-facing errors or recovery copy. The custom check explicitly passes test-only changes.

Full details: Cmux Full Internationalization

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py. It adds test coverage for workflow job names and a developer-only comment. The diff adds no production UI text, localization keys, metadata, API responses, web messages, or user-facing data.

Full details: Cmux Swiftui State Layout

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py, a Python test. It introduces no SwiftUI code, ObservableObject or @Published state, GeometryReader measurement, lazy/list row store reference, or render-time state mutation.

Full details: Cmux Architecture Rethink

Explanation

PASS: The PR changes only the Python test tests/test_nightly_delivery_concurrency.py. It adds job names to NO_CONCURRENCY_GROUP and does not introduce Swift code, timing repairs, mutable state, observers, duplicate wiring, or split UI lifecycle ownership. The Swift architectural rethink rule is not applicable.

Full details: Cmux Swift Auxiliary Window Close Shortcuts

Explanation

PASS: The pull request changes only tests/test_nightly_delivery_concurrency.py, a Python test. It adds job names to NO_CONCURRENCY_GROUP and adds no Swift or cmux-owned window code. The auxiliary-window close-shortcut rule is therefore inapplicable.

Full details: Cmux Source Artifacts

Explanation

The only changed path is tests/test_nightly_delivery_concurrency.py. The diff adds test coverage and comments to an existing hand-written test file. It does not add local output, generated artifacts, caches, build output, scratch directories, or copied files.

Full details: Cmux No Test Or Debug Seam In Production Source

Explanation

The pull request changes only tests/test_nightly_delivery_concurrency.py, a Python test file. It changes the NO_CONCURRENCY_GROUP test data and adds no Swift file or production Sources/ change. The custom failure condition is therefore not applicable.

Full details: Description check

Explanation

The description explains the problem, implementation, scope, and reported risk, but it omits the required Summary, Testing, Changelog, Proof, and Checklist sections. It also does not name a test command or provide explicit test results.

Resolution

Add the required template sections. Include the exact test command and result, state the changelog entry as an internal test change or none, add a Proof line explaining why screenshots are not applicable, and complete or justify the checklist items.

Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

teamleaderleo merged commit 9d4fac7 into main Oct 27, 2026
51 of 53 checks passed

teamleaderleo deleted the dev-daily-no-groups-main branch October 27, 2026 07:50

github-actions Bot added the merged-unverified A judging check was not green at merge; see the merge receipt comment label Oct 27, 2026

austinywang mentioned this pull request Oct 27, 2026

ci: sync the release-notary and app-host-execution guards with #26001 and #26008 (main red) #26043

Merged

coderabbitai Bot mentioned this pull request Oct 27, 2026

ci(delivery): no fixed concurrency group drops a queued delivery run #26401

Merged

Navigation Menu

Repository navigation

test(dev): every DEV publisher job takes no concurrency group - #26030

test(dev): every DEV publisher job takes no concurrency group#26030
teamleaderleo merged 1 commit into
mainfrom
dev-daily-no-groups-main

teamleaderleo commented Oct 27, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

cursor Bot commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

teamleaderleo commented Oct 27, 2026

Uh oh!

blacksmith-sh Bot commented Oct 27, 2026

Uh oh!

cmux-bot Bot commented Oct 27, 2026 •

edited by github-actions Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

cursor Bot commented Oct 27, 2026

Bugbot needs on-demand usage enabled

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

teamleaderleo commented Oct 27, 2026

Uh oh!

blacksmith-sh Bot commented Oct 27, 2026

Failure

Uh oh!

cmux-bot Bot commented Oct 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Validate that the persistent-pool rescue watches every owned-pool workflow (red on main too, not this PR)

Uh oh!

coderabbitai Bot commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 27, 2026 •

edited by coderabbitai Bot

Loading

cmux-bot Bot commented Oct 27, 2026 •

edited by github-actions Bot

Loading

`Validate that the persistent-pool rescue watches every owned-pool workflow` (red on main too, not this PR)