Skip to content

cmux NEXT: link the Cloud start-session highlight to docs - #25839

Merged
cmux-bot[bot] merged 25 commits into
feat-cmux-nextfrom
feat-cmux-next-highlight-docs-link
Oct 30, 2026
Merged

cmux-bot[bot] merged 25 commits into
feat-cmux-nextfrom
feat-cmux-next-highlight-docs-link

Conversation

@austinywang

@austinywang austinywang commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Add the Cloud documentation link to the “An agent can start a Cloud machine from its chat” highlight. The existing New Cloud Workspace Try it action remains available alongside the docs link.

The latest feat-cmux-next already contains the other highlight and nightly-test fixes previously carried by this PR. The conflict resolution retains those upstream implementations, including the stronger Sparkle signing-script checks and current Linux runner expectation. The net diff is one metadata line.

The branch was rebased, then its old published tip was retained as a merge parent so the update could be pushed without force.

Testing

Validation is being refreshed for the updated head; earlier check results cover superseded commits.

Observed / Not run

  • Observed: the final diff adds only docs: https://cmux.com/docs/cloud; the highlight retains its existing action. The docs route exists, and the parser and validator accept both fields.
  • Not run: native app and Rust builds; this change only adds release-note metadata.

Changelog

Changed: the Cloud start-session highlight links to the Cloud documentation.

…-notary red on base)

test_the_repository_highlights_validate fails on every feat-cmux-next PR: the
highlight from #25625 has no tryIt action or docs link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@austinywang

Copy link
Copy Markdown
Contributor Author

Correctness review (subagent): the docs line matches the highlight format in release-notes/next/WRITING.md and the https-URL rule in scripts/whats-new/validate.py, and every highlight now has a docs or action line. No findings.

Review (subagent): SHIP at b95fa53

@austinywang austinywang added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Oct 27, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Bead cx-3iqr2 created for this PR by the cmux coordinator.

@austinywang

Copy link
Copy Markdown
Contributor Author

Review (claude-subagent correctness review): SHIP at b95fa53

This reposts the subagent review from #25839 (comment) with the receipt on the first line, so next-autoland can read it. The head is unchanged.

The PR adds one line, docs: https://cmux.com/docs/cloud. It matches the format the four other Cloud highlights on feat-cmux-next already use, and it meets scripts/whats-new/validate.py's rule that an entry has either a try-it action or an https docs URL.

The base red this fixes (test_the_repository_highlights_validate in release-notary) blocks every feat-cmux-next PR, for example #25689.

No findings.

@austinywang austinywang added ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds and removed ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds labels Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review e8009bd: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr25839 -f ref=feat-cmux-next-highlight-docs-link -f platform=macos -f backend_mode=local

web and size checks: green

@austinywang

Copy link
Copy Markdown
Contributor Author

Review (claude-subagent correctness re-review): SHIP at 7f164b4

Re-review after Leo's plain merge of feat-cmux-next. The net diff is still the single line docs: https://cmux.com/docs/cloud in release-notes/next/highlights/cloud-start-session-chat-link.md.

  • The line passes scripts/whats-new/validate.py, which requires a highlight to have either a tryIt action or a docs link matching ^https://\S+$. It uses the same format as the example in release-notes/next/WRITING.md.
  • /docs/cloud is a real page: web/app/[locale]/(landing)/docs/cloud/page.tsx.
  • No other highlight on the base lacks both an action: and a docs: line, so this change should clear the base's Guard status failure.
  • There are no findings to resolve.

Previous review: #25839 (comment)

@austinywang austinywang added ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds and removed ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds labels Oct 27, 2026
…s inline

#25879 moved "Generate the old feed's
appcast" into scripts/ci/nightly-steps/legacy-identity-appcast.sh, so
test_the_appcast_comes_from_the_tested_plist no longer found its commands in
nightly.yml (ValueError: substring not found) and release-notary went red on
feat-cmux-next. Read the workflow through nightly_workflow_text.nightly_text(),
as the other nightly workflow tests do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pre-commit hook registered two base tests that this PR does not touch;
keep this PR to the two red fixes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@austinywang austinywang changed the title cmux NEXT: the Cloud start-session highlight links its docs (base red) cmux NEXT: fix the two release-notary base reds (highlight docs link, legacy appcast test) Oct 27, 2026
@austinywang

Copy link
Copy Markdown
Contributor Author

Review (claude-subagent correctness review): SHIP at 055d9a6

The net diff is two files: the highlight docs: line, which is unchanged from the previous review, and tests/test_nightly_legacy_publish_linux.py, which now reads nightly.yml through nightly_workflow_text.nightly_text().

  • The fix works. test_the_appcast_comes_from_the_tested_plist no longer raises ValueError: substring not found. The five commands it looks for appear in the inlined legacy-identity-appcast.sh in the order the test expects.
  • The import resolves. It is the same import tests/test_nightly_next_ring.py:13 uses. CI runs the file as python3 tests/test_nightly_legacy_publish_linux.py (ci-guards.yml, release-notary), so tests/ is on sys.path.
  • No check got weaker. The expansion only adds the moved scripts' bodies. Positive assertions can only find more text, and the negative ones (test_publish_uses_no_apple_tool and the environment:|secrets\. check) now also cover the inlined scripts.
  • One local failure, not caused by this change. In the reviewer's local run, test_openssl_verifies_a_file_signature failed. That Mac's /usr/bin/openssl is LibreSSL 3.3.6 without Ed25519 -rawin, and the test doesn't read the workflow text, so this change can't affect it. In CI on the previous head (run https://github.com/manaflow-ai/cmux/actions/runs/40462024247), the same file reported only the appcast error (..E.....), so the OpenSSL test passes on the Linux runner.
  • No findings to resolve.

Earlier reviews: #25839 (comment) and #25839 (comment) (both superseded by this push).

@austinywang austinywang added ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds and removed ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds labels Oct 27, 2026
@github-actions github-actions Bot added risk:low Risk tier (docs/ci/risk-tiers.md) and removed risk:high Risk tier (docs/ci/risk-tiers.md) labels Oct 27, 2026
…e paths itself

#26248 made ci-target-graph.py ignore .git, .claude and .codex paths a test
names, so the one-literal form no longer routes CmuxNextAppTests on the
repository's settings file. Back to the base's line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@austinywang

Copy link
Copy Markdown
Contributor Author

Review (claude-subagent correctness re-review): SHIP at 2db12da

Changes since d66d8d5:

Reviews:

  • ba6a684: FIX. The only finding was the merge conflict with acpmux: prompt_uploads test fixture names no literal state root (fixes the state-roots base red) #26278, fixed by 62ec615.
  • 018a91e: SHIP, with the advisory note above, resolved by 2db12da.
  • 2db12da: SHIP.
    1. Scope: exactly 6 files. Four highlights each gain an action or docs line, and tests/test_nightly_legacy_publish_linux.py and tests/test_nightly_sparkle_key.sh now read nightly_text(). git merge-tree with the base exits 0.
    2. Each change is still needed on the current base:
      • Those four are the only highlights there with neither an action nor a docs link.
      • The two tests, run from the base tree, fail: the sparkle-key test with "must derive the embedded key", and the legacy test errors in test_the_appcast_comes_from_the_tested_plist.
    3. Test results:
      • test_digest.py: 5/5 OK
      • test_validate.py: OK
      • test_nightly_sparkle_key.sh: PASS
      • test_nightly_legacy_publish_linux.py: 7/8. The failure is test_openssl_verifies_a_file_signature, a known LibreSSL problem on macOS only.
      • test_cmux_next_route.py: 57/57 OK

@austinywang austinywang added ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds and removed ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds labels Oct 27, 2026
@austinywang austinywang changed the title cmux NEXT: fix the base reds in release-notary and cmux-next checks (highlights, nightly tests, routing, state roots) cmux NEXT: fix the release-notary base reds (four highlight links, two nightly workflow tests) Oct 27, 2026
@austinywang

Copy link
Copy Markdown
Contributor Author

Review (claude-subagent correctness re-review): SHIP at 92932a4

Autoland reported "stale after 3 dispatches, waits for a push", so 92932a4 is a plain merge of feat-cmux-next on top of the reviewed 2db12da.

An independent subagent reviewed the exact head and found no defects.

  1. Scope. The net diff is the same 6 files, +12/-2: four highlight action/docs lines, and the two nightly tests reading nightly_text().
  2. Every change is still needed.
    • On the base, exactly these four highlights lack both an action and a docs link (validate.py:192-193).
    • The base copies of both tests fail when run on the base tree: the sparkle key test with "must derive the embedded key", and the legacy test with an error in test_the_appcast_comes_from_the_tested_plist.
  3. Tests.
    • test_digest.py: 5/5 OK.
    • test_nightly_sparkle_key.sh: PASS.
    • test_nightly_legacy_publish_linux.py: 7/8. The failure is test_openssl_verifies_a_file_signature, a known LibreSSL limitation on macOS; it fails on the base too.

Resolution: nothing to change.

@austinywang austinywang added ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds and removed ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds labels Oct 27, 2026
@austinywang austinywang removed the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Oct 29, 2026
austinywang and others added 2 commits October 29, 2026 15:09
…-notary red on base)

test_the_repository_highlights_validate fails on every feat-cmux-next PR: the
highlight from #25625 has no tryIt action or docs link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
austinywang and others added 5 commits October 29, 2026 17:09
…e action

feat-cmux-next's inline-pr-pills and inspector-error-colours highlights have
no action or docs line, so scripts/whats-new/test_digest.py
(release-notary) fails on the base. Use existing palette actions rather than
https://cmux.com/docs/agents, which returns 404.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e-notary red on base since 93ff53c)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@austinywang

Copy link
Copy Markdown
Contributor Author

Review (claude-subagent correctness re-review): SHIP at e8009bd

Changes since b1ca703

  • b1ca703 merged the old published head, so its merge base with feat-cmux-next was 9b2372c. Against that base, GitHub counted more than 3,000 files (risk evidence) and 18 changed defaults (defaults guard) that this PR never touched. Plain merges of feat-cmux-next (up to 93ff53c) fix that. The net diff against the base is now four highlight files, one line each.
  • release-notary (scripts/whats-new/test_digest.py) was red because of base highlights that have neither an action nor a docs link: inline-pr-pills, inspector-error-colours, and since 93ff53c, chat-find-keeps-place. Each now gets an action that the app's What's New allows (PageDescriptor.changelogTryItActions): palette.newAgentChat | New Agent Chat for the two chat entries, and openSettings | Open Settings for the Inspector theme colours.

Findings and resolution

  1. FIX on 628cf56 (never pushed): the first draft used docs: https://cmux.com/docs/agents, which returns 404. The 18 existing highlights that use this URL, and the example in release-notes/next/WRITING.md, point at the same dead page; that is outside this PR. Fixed: I replaced the link with the live actions above, so this PR adds no dead link.
  2. Not blocking: cloud-start-session-chat-link's action: newCloudWorkspace is not in changelogTryItActions, so the app drops that action and the docs: https://cmux.com/docs/cloud link (200) is the entry's only working affordance. Kept as is.

Overlap: #27657 adds docs: https://cmux.com/docs/agents to inspector-error-colours.md. That is the same 404, and it touches the same line as this PR.

Tests: scripts/whats-new/test_digest.py (5 OK), scripts/whats-new/test_validate.py (15 OK), scripts/cmux-next/media/whats-new-clips.py check (exit 0), and curl on the docs URLs.

Visual: I didn't run a visual review. This PR only changes release-note data; no UI code changed. The new buttons render through the What's New controls that the same action strings already use in 11 and 17 shipped highlights.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This branch was previously deployed

3 inactive (2 outdated) deployments
ci-routing-agent — e8009bd9 Deployed Oct 30, 2026 by austinywang via cmux-tui tree preflight #79280
artifacts — ba6a684c Deployed Oct 27, 2026 by austinywang via publish to R2 #65952
sentry-dsyms — ba6a684c Deployed Oct 27, 2026 by austinywang via upload cmux-tui dSYMs to Sentry #65952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants