Skip to content

Fix Inspector highlight digest validation - #27657

Closed
teamleaderleo wants to merge 6 commits into
feat-cmux-nextfrom
lane/aiforui-inspector-highlight-docs
Closed

teamleaderleo wants to merge 6 commits into
feat-cmux-nextfrom
lane/aiforui-inspector-highlight-docs

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

The Inspector highlight added by #27613 failed digest validation because it had neither a documentation link nor a try-it action. Add the live nightly agent documentation link so the digest accepts it.

Validation: digest.entry_problems reports needs a tryIt action/deeplink or a docs link before and no problems after. The link is https://cmux.com/docs/next/agents, confirmed by independent review as the existing nightly route. Remote red/green validation passed at 40e46ac; the metadata-only URL correction is lint-clean and pre-push-clean at 21c23b9. Only release-note metadata changes; no product UI changes.

Open and merged PR search for the exact highlight found only #27613. The pre-push overlap hook ran but its broker API form is unsupported.

Agent session: agent session

@teamleaderleo
teamleaderleo marked this pull request as ready for review October 29, 2026 22:56
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 18b3a7a: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr27657 -f ref=lane/aiforui-inspector-highlight-docs -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 29, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at 21c23b9

No blocking findings. The diff only adds the documentation URL to the highlight metadata, consistent with the stated fix. Repository validation was unavailable because tool access was denied.

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 21c23b9: an independent review passed this exact head (next-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo
teamleaderleo force-pushed the lane/aiforui-inspector-highlight-docs branch from 21c23b9 to 0e98166 Compare October 30, 2026 08:48
@cursor

cursor Bot commented Oct 30, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, next-review): SHIP at 18b3a7a

No blocking findings. The patch only replaces the invalid action metadata with a docs link, consistent with the described digest validation fix.

cmux-bot[bot]
cmux-bot Bot previously approved these changes Oct 30, 2026

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 18b3a7a: an independent review passed this exact head (next-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@cmux-bot cmux-bot Bot removed the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@cmux-bot
cmux-bot Bot dismissed their stale review October 30, 2026 22:12

A newer verdict blocks 9acd428 (no independent SHIP at the head).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent review (gpt-6.1-sol high) at 9acd428: SHIP.

@cmux-bot cmux-bot Bot removed the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent review (gpt-6.1-sol high) at 358ed32: SHIP.

@cmux-bot cmux-bot Bot removed the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent review (gpt-6.1-sol high) at 78099ac: SHIP.

@cmux-bot cmux-bot Bot removed the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 30, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing as superseded: feat-cmux-next already fixed this highlight's digest problem. #25839 gave inspector-error-colours.md a try-it action (action: openSettings | Open Settings), so the digest accepts it. This PR would now replace that action with a docs link, which risk evidence holds as a take-back of #25839.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 78099ac4 Deployed Oct 30, 2026 by teamleaderleo via cmux-tui tree preflight #85763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant