Repository navigation
acpmux: prompt_uploads test fixture names no literal state root (fixes the state-roots base red) - #26278
Merged
Conversation
check-state-roots (baseline 0) flags the fixture path /home/me/.acpmux/uploads/... added by #25840. The test checks that a link names its upload by the parent folder on any platform; the root's name plays no part (upload_ids reads the second-to-last path segment), so a neutral root keeps the test's intent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-6ccd4e4ea4a1d1f1ddd4
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Collaborator
Author
|
Owned by an agent session · session |
teamleaderleo
temporarily deployed
to
ci-routing-agent
October 27, 2026 16:30 — with
GitHub Actions
Inactive
Collaborator
Author
|
Bead |
|
Found 2 test failures on Blacksmith runners: Failures
|
teamleaderleo
temporarily deployed
to
artifacts
October 27, 2026 16:54 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
sentry-dsyms
October 27, 2026 16:54 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 27, 2026 17:00 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 27, 2026 17:00 — with
GitHub Actions
Inactive
teamleaderleo
temporarily deployed
to
artifacts
October 27, 2026 17:05 — with
GitHub Actions
Inactive
This was referenced Oct 27, 2026
Contributor
|
Shipped in:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red fix. Since about 08:38Z, "No literal state roots" (
scripts/cmux-next/check-state-roots.sh, baseline 0) has been red on feat-cmux-next. It flags a test fixture that #25840 (30d0e84) added incmux-tui/crates/acpmux/src/prompt_uploads.rs:a_link_names_its_upload_on_any_platformchecks thatupload_idsfinds an upload by the folder holding the file, on Unix and Windows paths alike.upload_idsreads the second-to-last path segment, so the root's name plays no part. The fixture now uses/home/me/state/uploads/chat/{id}/a.png, which keeps the test's intent and names no state root.check-state-roots.shfails on base and passes here.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
check-state-rootsCI failure onfeat-cmux-nextby changing the fixture path inacpmux'sprompt_uploads.rstest from/home/me/.acpmux/uploads/to/home/me/state/uploads/, keeping the path clear of literal state roots. The test's intent is unchanged:upload_idsreads only the second-to-last path segment, so the root's name plays no part. One-line, test-only change;check-state-roots.shnow passes on base.Written for commit 1223f78. Summary will update on new commits.