Skip to content

acpmux: prompt_uploads test fixture names no literal state root (fixes the state-roots base red) - #26278

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
ci-waste/state-roots-fixture
Oct 27, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
ci-waste/state-roots-fixture

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Base red fix. Since about 08:38Z, "No literal state roots" (scripts/cmux-next/check-state-roots.sh, baseline 0) has been red on feat-cmux-next. It flags a test fixture that #25840 (30d0e84) added in cmux-tui/crates/acpmux/src/prompt_uploads.rs:

cmux-tui/crates/acpmux/src/prompt_uploads.rs:345:            link(format!("/home/me/.acpmux/uploads/chat/{id}/a.png")),

a_link_names_its_upload_on_any_platform checks that upload_ids finds an upload by the folder holding the file, on Unix and Windows paths alike. upload_ids reads the second-to-last path segment, so the root's name plays no part. The fixture now uses /home/me/state/uploads/chat/{id}/a.png, which keeps the test's intent and names no state root.

  • check-state-roots.sh fails on base and passes here.
  • One line, test only. No product code changes.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the check-state-roots CI failure on feat-cmux-next by changing the fixture path in acpmux's prompt_uploads.rs test from /home/me/.acpmux/uploads/ to /home/me/state/uploads/, keeping the path clear of literal state roots. The test's intent is unchanged: upload_ids reads only the second-to-last path segment, so the root's name plays no part. One-line, test-only change; check-state-roots.sh now passes on base.

Written for commit 1223f78. Summary will update on new commits.

View guided diff Turn on auto-fix

check-state-roots (baseline 0) flags the fixture path /home/me/.acpmux/uploads/... added by #25840. The
test checks that a link names its upload by the parent folder on any platform; the root's name plays no
part (upload_ids reads the second-to-last path segment), so a neutral root keeps the test's intent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-6ccd4e4ea4a1d1f1ddd4
@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 1223f78: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr26278 -f ref=ci-waste/state-roots-fixture -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-hb8m0e created for this PR by the cmux coordinator.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 27, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
nightly.yml must derive the embedded key and sign every appcast through the helper/
nightly.yml must derive the embedded key and sign every appcast through the helper
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit c1d8951 into feat-cmux-next Oct 27, 2026
178 of 189 checks passed
@teamleaderleo
teamleaderleo deleted the ci-waste/state-roots-fixture branch October 27, 2026 16:55
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

3 inactive deployments
artifacts — 1223f785 Deployed Oct 27, 2026 by teamleaderleo via add the Windows daemon to the tree #65898
sentry-dsyms — 1223f785 Deployed Oct 27, 2026 by teamleaderleo via upload cmux-tui dSYMs to Sentry #65898
ci-routing-agent — 1223f785 Deployed Oct 27, 2026 by teamleaderleo via wait for same-key tree publisher #65898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant