Repository navigation
ci: refuse untrusted cmux-tui pin publishers - #25313
Conversation
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Bead |
|
|
|
Found 9 test failures on Blacksmith runners: Failures
|
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (Codex subagent review_safe_pin_advice, correctness first): SHIP at 4d33d8b Independent current-runtime review found no remaining actionable defects after repairing the inaccurate fleet-publication guidance and the pin-dispatch retry selector. Verified 81 security tests, the publication-order and Windows-fetch regressions, three actual jq selection cases, shell syntax, and diff whitespace. The five batch review-gate failures also reproduce with base implementation 522db45. Primary inspection confirms the focused diff. The separately requested acpmux xhigh session is waiting on the cmux NEXT folder-trust prompt; this receipt does not claim that session completed. The repository ruleset and GH013 refusal are primary-agent operational evidence, not independently re-queried by this reviewer. Provider audit and owner-claim reconciliation remain pending the controller owner. |
|
|
|
|
|
|
|
The reported aggregate red was isolated from run |
|
Review (Codex xhigh via acpmux nx-ci-final-xhigh-review): SHIP at 4d33d8b Postmerge audit of the complete pinned diff (merged as A real postmerge same-tree job ( Exposure clarification: run |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Problem
The
same-tree cmux-tuifailure in #25251 recommended pushing a PR merge commit tocmux-tui-pin-*. That promotes PR-controlled workflow code to a privileged push context. Run40267752094reproduced the path on #22883's merge SHA: preflight obtained an OIDC-authenticated tree claim before cancellation.Change
Remove the push advice and helper-ref creation. Refuse pin refs before preflight, build, or publication; stop retrying pin publishers; and stop the batch controller from creating them. The recovery guidance now says to land the reviewed change, then wait for trusted
feat-cmux-nextpublication. Fleet app builds can bundle their own daemon, but cannot publish an unmerged PR tree.Repository ruleset 25855210 is already active: creation and updates of
refs/heads/cmux-tui-pin-*are restricted with no bypass actors. A probe push of the guarded head was rejected by GH013; no ref was created. This also blocks old commits that lack the workflow guard.Validation
bc9700cb91ddbfails on the unsafe advice; fixed head passes.python3 -m unittest discover -s tests -p test_tui_publish_workflow_security.py: 81 passed.python3 tests/test_cmux_tui_artifacts_retry.py: 8 passed.python3 tests/test_cmux_tui_feat_publish_order.py: passed, including pin push/dispatch refusal.pin-cmux-tui-dispatch.test.sh,pin-cmux-tui-probe.test.sh,pin-cmux-tui-windows-fetch.test.sh, andpin-cmux-tui-run-check.test.sh: passed.test_next_batch.py/test_next_batch_groups.py: 155/160 passed; the same five review-gate failures reproduce with base implementation522db45a7a35.Observed / Not run
Observed on
4d33d8bd8478753062b9a119678fecf92ad8a2c4: focused portable checks above. Run40267752094completed/cancelled; all R2 publish jobs had zero steps, while preflight returnedowner=40267752094 granted=true. Provider audit and claim-state reconciliation are pending the controller owner; no credentials have been rotated.Not run: native builds/tests locally. An attempted fleet build for #22883 was not submitted: the deleted merge ref has no branch, and source ingest refused this host's fleet identity. It would only bundle a local daemon, not publish the PR tree.
Changelog
none
Related: #25251, #22883
Agent session: agent session