Repository navigation
fix(acpmux): open remote launches in local sidebar groups - #25251
Conversation
Use the mirrored session ID in the existing local agent-open path. Accept unnamed group launches and retain the stable workspace key on named reuse. Add remote CLI and host argument regressions. Fleet tests blocked before dispatch: cmux-ci test requires an unavailable HQ checkout. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a175f4-bc59-7291-9892-c2cc8b5a3103&host=gcp-codex-lane-10
|
Bead |
|
Found 11 test failures on Blacksmith runners: Failures
...and 1 more test failures. View all on Blacksmith
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
web and size checks: green |
|
|
Use a distinct capture file for every remote-group launch so a failed cmux invocation cannot reuse stale arguments. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a175f4-bc59-7291-9892-c2cc8b5a3103&host=gcp-codex-lane-10
|
|
The live app check confirms grouping, while focus behavior remains unverified. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a175f4-bc59-7291-9892-c2cc8b5a3103&host=gcp-codex-lane-10
|
|
Regression for review of PR #25251: unnamed peer sessions with the same generated name must not opt into title-based workspace reuse. Test execution is blocked before cmux-ci dispatch because the guarded HQ installer cannot authenticate its private remote. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a17629-be6f-7510-a1bb-ee99d21a1764&host=gcp-codex-lane-11
Omit the optional workspace title for unnamed launches, bypassing title-based predecessor reuse when independent peers generate the same session name. Explicit names keep their existing reuse behavior. Added a regression with matching names on two peer hubs; cmux-ci execution is blocked before dispatch by private HQ authentication. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a17629-be6f-7510-a1bb-ee99d21a1764&host=gcp-codex-lane-11
Match remote_new_hints: the fake harness exposes normal and strict asking modes, which the remote-create guard must know before starting it. Fleet Linux reproduced the prior head failing with remote.mode_not_asking; the area owner will rerun the focused fleet test on this commit. No local tests run. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a17629-be6f-7510-a1bb-ee99d21a1764&host=gcp-codex-lane-11
|
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Remote grouped launches were rejected before session creation. This lets
acpmux new --host H --group Guse the returned mirrored session ID with the existing localcmux agent openpath. It also accepts an unnamed launch, soacpmux new --host H -m codex --group "Remote demo" -d "say hi"works without an extra naming flag.Leo: "this + more i was talking to workspace-218 i wanted them to help work on ergonomics too" and "these issues and such all need to be addressed".
--reuseretains the stable workspace key. Unnamed launches deliberately create a new session each time and omit the optional workspace name, so equal generated names on different peers cannot trigger title-based predecessor-row reuse.agent.openSessionTab --hostsupport already landed in cmux NEXT: agent.openSessionTab --host <peer> opens that machine's chat (as this Mac's acpmux mirrors it) #25027. Added a regression for both CLI spellings; no duplicate Swift fix.--groupin the remote create and open the returned ID on the controller Mac afterward. That avoids a reverse callback and controller credentials on the execution host. The lane-place owner is fanout-infra; its implementation is not changed by this PR.Risk: a CLI and app pointed at different local acpmux daemons cannot resolve the same mirrored ID. Documentation names that prerequisite. Opening the workspace may move focus: the area owner's cosmic-gray check returned
focused:true; thefocuses=falsemetadata drift is owned by ergo-help.Live check (area owner, cosmic-gray, current NIGHTLY):
cmux agent open <mirrored id of gcp-codex-lane-2/demo-remote-gcp-codex-lane-2> --name … --key … --group 'Remote demo'created the group 'Remote demo' and the workspace joined it; screenshot pending (screen locked).Validation:
b449447e52f54ff9c6352b752be3496eb6765015: the 168 CLI tests passed;remote_group_clifailed because its fake harness had no reviewed asking mode. Head8692e30d2d1336845dc8dbaf82fef3ff0e100f17configureswebAskingModesforfakeasnormalandstrict, matchingremote_new_hints. Fleet rerun is pending with the area owner. Static prepush gate andgit diff --checkpass.git diff --checkandpython3 scripts/cmux-next/prepush-gate.pypassed../scripts/localize-changes --base origin/feat-cmux-nextfound zero changed translation keys; its global validator failed on existing catalog debt (43,243 parity errors).rustfmton changed Rust files;git diff --check: pass.python3 scripts/cmux-next/prepush-gate.pyon committed head: pass, no new violations.python3 scripts/verify-local.pypassed all selected checks except existing localization debt; no localization files changed.b449447e52f54ff9c6352b752be3496eb6765015,cmux-ci test -- cargo test --manifest-path cmux-tui/Cargo.toml -p acpmux --test remote_group_cliwas blocked before dispatch: the guarded HQ installer could not authenticate the private HQ remote. No tests ran.reachhas no registry origin for this lane.cmux-ci captureneeds the unavailable HQ checkout. No screenshots claimed.glaeda-ghservice is absent and its supported restart failed.pr-overlapwas attempted but could not read through the tokenless broker; bounded broker searches found fix(acpmux): guard sidebar group labels and empty groups #24581 and the already-merged cmux NEXT: agent.openSessionTab --host <peer> opens that machine's chat (as this Mac's acpmux mirrors it) #25027.8692e30d2d1336845dc8dbaf82fef3ff0e100f17: SHIP, no correctness findings (review session01a17641-7313-7b22-b3ac-c34906f8e78a). It verified the remote-start gate and fake-agent modes against the peer fixtures; fleet rerun remains pending. The parent had a full correctness review.Review (gpt-6.1-sol xhigh): SHIP at 8692e30
Changelog
Agent session: gcp-codex-lane-10