Repository navigation
cmux-next: retire tabs.newTabWidgets.modeSwitch (the New Tab Search | Ask switch is gone) - #22883
Conversation
|
owner: 01a15c41-0d06-7430-b24d-a6d55b9be1d4 |
|
Human approval: Leo (teamleaderleo) approved this PR in the coordinator chat on 2026-10-20 ("i approve all 22612 22874 22883 22777"), at head Agent session: cosmic-gray |
|
Not merging at 563072c, the head Leo approved: it can't land as it is.
Plan: once #22674 and #22816 merge, I'll merge the base in once, review the result, wait for a green Swift compile on that head, and post the new head here for a new approval. |
|
Owned by nx-settings on big-red |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 3ad1a6b to compare; do not merge until green; see lane-rules |
|
Bead |
|
Found 11 test failures on Blacksmith runners: Failures
...and 1 more test failures. View all on Blacksmith
|
|
Review (subagent, correctness first): SHIP at cb7ada1
|
|
|
|
|
|
Review (subagent, correctness first): SHIP at 1fd5baa
|
|
Review (subagent, correctness first): SHIP at 59cf72e
|
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Orphaned: no activity for 73 h, and no lane holds a lease on it. The orphan sweep could not merge |
724b5ea to
6c0d887
Compare
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
|
|
|
|
Base-red attribution at source head The release-notary guard job fails on the release-note try-it requirement and existing nightly background-step/step-coverage/resolve guards. I reproduced those four Python test failures locally. Their workflows, scripts, release notes and test inputs are byte-identical to the base ( The settings source-stamp failure is this branch's and is being repaired through managed Mac autofix run 40262535390, with one condition wait active. I will apply its generated artifact and obtain a fresh exact-head review before landing. |
Generated by managed Mac PR autofix run 40262535390. Agent-Session: https://cmux.com/deeplink/agent?harness=codex&session=01a16c64-6e4c-75c1-88cb-d2d1dfe2ae1e&host=big-red
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (independent Codex /root/review_22883_final, xhigh): SHIP at db508d9
Independent final-head review found no blocking findings. The full delta is four files: the retired-key JSON, generated Swift map, focused NewTabWidgetSettingsTests regression, and the official one-line source-stamp artifact from managed Mac autofix run 40262535390. Source-stamp verification, generated-source verification, generated-output drift, JSON parsing and diff checks passed independently. The final repair changes only the generated stamp relative to the previously reviewed source head.
Validation limit: this was a read-only/static review; native Swift builds/tests were not run locally. I also inspected the final diff and clean worktree as the primary owner. Final-head PR checks remain in one condition wait.
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Base-red attribution for live head
The PR's complete base-to-head diff remains four settings files only (retired-key source, generated Swift, focused regression, and source stamp), so neither red is caused by this PR. I made no unrelated fix. |
teamleaderleo
left a comment
There was a problem hiding this comment.
Review (independent Codex /root/review_22883_final, xhigh): SHIP at 302a7cd
The final base-to-head diff is exactly the four intended settings files (19 insertions, 1 deletion). defaults_guard.py check-stamp --base 3ad1a6bb71993c13e4ff9bd776d4fabd73ca41f3, source-stamp parity, gen-settings-sources.py --check, generated-output drift, JSON parsing, and git diff --check all pass. No new findings.
The reported Script and Package dependency reds touch no changed path and reproduce unchanged on base, so they are inherited/base-owned. Validation was read-only/static; no native Swift builds or tests were run locally.
|
Final exact-head merge evidence for
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
New Tab's Search | Ask switch and its widget were already removed by #22674 and #22816. This PR finishes the config migration by retiring
tabs.newTabWidgets.modeSwitch: an old file loads quietly, reports the retired key, and cannot expose it through Settings or agent writes.The branch is current on
feat-cmux-nextbase3ad1a6bb71993c13e4ff9bd776d4fabd73ca41f3. Its complete base-to-head diff at302a7cd279864cc2c2c87d70c138b6596c31cd2bis four settings files: retired-key source, generated Swift map, focused regression, and regenerated source stamp. Existing New Tab behavior and unrelated base changes are preserved.Observed / Not run
python3 scripts/cmux-next/gen-settings-sources.py --check: passed.python3 scripts/cmux-next/prepush-gate.py: passed for the own commits.python3 scripts/ci/defaults_guard.py check-stamp --base 3ad1a6bb71993c13e4ff9bd776d4fabd73ca41f3: passed.git diff --check: passed.Script tests (pin-cmux-tui, embed-cef, ensure-cef store)is base-red:bash scripts/cmux-next/tests/release-compile-derived-data.test.shreproduces the benchOTHER_SWIFT_FLAGSfailure on the untouched base worktree.Package dependency lists sortedis base-red:python3 scripts/cmux-next/check-package-dependency-lists.pyreproduces the missingCmuxNextChiefMemorydependency on the untouched base worktree.302a7cd279864cc2c2c87d70c138b6596c31cd2b.No capture: this changes retired config-key handling only, with no layout or styling change.
Agent session: big-red