You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(next): return the computed pane header height - #24755
Restores the feature tip app compile after #24729 (cd148a3bb8ab0d0cc6cacf1c5b30ff04f7f5f7aa). Its new conditional return made paneHeaderHeight a multi-statement getter, so the final height expression now needs an explicit return.
Leo asked, “still failed checks? wtf?” about the tip. The exact Linux pool app compile receipt for 422e7b6efb2f9ef0f47babb50fc5702c1ca78ce5, job 665fbb793a817f249b040323, reports ok:false after 96.9 seconds with one distinct compiler error: PaneContentView.swift:215:9: missing return in getter expected to return CGFloat. This PR changes that one line. The same cmux-ci compile-check --ref SHA --app --timeout 900 --queue-timeout 900 command passed on final head 2692a4bedb5ec58e3c1fa42da9e07a01a3433913: job 59ba1cc87c796adf6c018e53, ok:true, 61.3 seconds, zero compiler errors. Both receipts use toolchain swift-6.3.3-cmux+Xcode_26.6/736c824e5bb154f0. Receipt SHA-256: d8cd0b80e1ee5354bb459e339395d5d6dbdb757c088105d1d98ac6a1c1bd643a.
Independent Codex cross-review before opening: SHIP at exact head 2692a4bedb5ec58e3c1fa42da9e07a01a3433913, no P1/P2/P3 findings. git diff --check passes. No parser-only check is being presented as compile proof.
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 38b678f to compare; do not merge until green; see lane-rules
Tour of 2692a4bedb (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output. Both apps run cmux-tui from 2a9f788 (tree 6aeeaa31d2ad): the merge base's own tree fd718f0f9fda was not published yet.
Independent Codex cross-review before PR creation: SHIP at exact head 2692a4bedb5ec58e3c1fa42da9e07a01a3433913, no P1/P2/P3 findings. Separate red_concurrency session verified the one-line return restores the getter result after its preceding conditional return.
Exact app compile is now green: cmux-ci compile-check --ref 2692a4bedb5ec58e3c1fa42da9e07a01a3433913 --app --timeout 900 --queue-timeout 900, job 59ba1cc87c796adf6c018e53, ok:true, 61.3s. Before (same source/toolchain/command), job 665fbb793a817f249b040323 failed after 96.9s with the missing-return compiler error. This is app compile proof, beyond syntax parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the feature tip app compile after #24729 (
cd148a3bb8ab0d0cc6cacf1c5b30ff04f7f5f7aa). Its new conditional return madepaneHeaderHeighta multi-statement getter, so the final height expression now needs an explicitreturn.Leo asked, “still failed checks? wtf?” about the tip. The exact Linux pool app compile receipt for
422e7b6efb2f9ef0f47babb50fc5702c1ca78ce5, job665fbb793a817f249b040323, reportsok:falseafter 96.9 seconds with one distinct compiler error:PaneContentView.swift:215:9: missing return in getter expected to return CGFloat. This PR changes that one line. The samecmux-ci compile-check --ref SHA --app --timeout 900 --queue-timeout 900command passed on final head2692a4bedb5ec58e3c1fa42da9e07a01a3433913: job59ba1cc87c796adf6c018e53,ok:true, 61.3 seconds, zero compiler errors. Both receipts use toolchainswift-6.3.3-cmux+Xcode_26.6/736c824e5bb154f0. Receipt SHA-256:d8cd0b80e1ee5354bb459e339395d5d6dbdb757c088105d1d98ac6a1c1bd643a.Independent Codex cross-review before opening: SHIP at exact head
2692a4bedb5ec58e3c1fa42da9e07a01a3433913, no P1/P2/P3 findings.git diff --checkpasses. No parser-only check is being presented as compile proof.Changelog
none
Agent session: big-red