Skip to content

fix(next): return the computed pane header height - #24755

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cx3-base-red-pane-return
Oct 24, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cx3-base-red-pane-return

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Restores the feature tip app compile after #24729 (cd148a3bb8ab0d0cc6cacf1c5b30ff04f7f5f7aa). Its new conditional return made paneHeaderHeight a multi-statement getter, so the final height expression now needs an explicit return.

Leo asked, “still failed checks? wtf?” about the tip. The exact Linux pool app compile receipt for 422e7b6efb2f9ef0f47babb50fc5702c1ca78ce5, job 665fbb793a817f249b040323, reports ok:false after 96.9 seconds with one distinct compiler error: PaneContentView.swift:215:9: missing return in getter expected to return CGFloat. This PR changes that one line. The same cmux-ci compile-check --ref SHA --app --timeout 900 --queue-timeout 900 command passed on final head 2692a4bedb5ec58e3c1fa42da9e07a01a3433913: job 59ba1cc87c796adf6c018e53, ok:true, 61.3 seconds, zero compiler errors. Both receipts use toolchain swift-6.3.3-cmux+Xcode_26.6/736c824e5bb154f0. Receipt SHA-256: d8cd0b80e1ee5354bb459e339395d5d6dbdb757c088105d1d98ac6a1c1bd643a.

Independent Codex cross-review before opening: SHIP at exact head 2692a4bedb5ec58e3c1fa42da9e07a01a3433913, no P1/P2/P3 findings. git diff --check passes. No parser-only check is being presented as compile proof.

Changelog

none

Agent session: big-red

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 2692a4b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24755 -f ref=cx3-base-red-pane-return -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 38b678f to compare; do not merge until green; see lane-rules

Tour of 2692a4bedb (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output. Both apps run cmux-tui from 2a9f788 (tree 6aeeaa31d2ad): the merge base's own tree fd718f0f9fda was not published yet.

@teamleaderleo
teamleaderleo merged commit 40ef2ff into feat-cmux-next Oct 24, 2026
107 of 117 checks passed
@teamleaderleo
teamleaderleo deleted the cx3-base-red-pane-return branch October 24, 2026 04:14
@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 24, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent Codex cross-review before PR creation: SHIP at exact head 2692a4bedb5ec58e3c1fa42da9e07a01a3433913, no P1/P2/P3 findings. Separate red_concurrency session verified the one-line return restores the getter result after its preceding conditional return.

Exact app compile is now green: cmux-ci compile-check --ref 2692a4bedb5ec58e3c1fa42da9e07a01a3433913 --app --timeout 900 --queue-timeout 900, job 59ba1cc87c796adf6c018e53, ok:true, 61.3s. Before (same source/toolchain/command), job 665fbb793a817f249b040323 failed after 96.9s with the missing-return compiler error. This is app compile proof, beyond syntax parsing.

Agent session: big-red

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 2692a4be Deployed Oct 24, 2026 by teamleaderleo via namespace autofix #2300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant