Repository navigation
cmux NEXT: keep agent chrome lines and tool actions clear - #24729
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 043edc6; does not block Tour of Gallery before/after for
States
Pick other states with a |
|
Found 44 test failures on Blacksmith runners: Failures
...and 34 more test failures. View all on Blacksmith: run 40057622953, run 40060372674, run 40057623096
|
|
Bead |
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40060430002 at cd148a3 failed: cmux-next Release compile (Xcode 26). |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fix the two agent-chat chrome polish issues Austin reported: remove the focused pane hairline above a hidden-tab-bar chat header, keep the header strip centered in its native chrome band, and reserve a real action slot so a tool row's duration, Copy, and expand controls never overlap at narrow widths.
Leo asked: "also did we alr fix these? but we're just waiting on nightly?"
Austin reported: "^ do you see that there are an extra line here on top? not sure if this is intentional but I hope not at least haha.. could you fix this?" and "And then make sure it's vertically centered". He also reported: "In this case, the copy button and then expand icon are overlapping with each other as well..."
The native fix treats the hidden agent chat's webview strip as a chrome band for PaneOverlayView, so the focus ring starts below it. The webview fix marks rows that own the floating transcript Copy button, reserves the action slot before the chevron, and leaves Shell card actions in flow.
Design references matched:
cmux-design-references/topics/tabs-and-panels.md(one centered pane chrome rhythm) andtopics/status-and-progress.md(status actions stay readable at the trailing edge).Before / after captures
Gallery captures on the leased capture mini (cropped to the gallery content area; light and dark, narrow and wide):
Each raw link returned HTTP 200.
Verification
bun test ./test/transcript-copy.test.tsx ./test/transcript-codex-turn.test.tsx(11 pass)bun run typecheck(2564 files, no type errors)python3 scripts/verify-local.py --repo .(11/11 selected checks passed; native compile/test deferred to fleet)python3 scripts/cmux-next/prepush-gate.py(no new violations)scripts/web-lint.shran; existing base reds remain in design-token baseline/text-focus and existing lint warnings. No new changed-file failure remained after formatting.AgentHiddenHeaderChromeTests.hiddenAgentHeaderIsAChromeBand(fleet validation required by repository policy).Observed / Not run
Native macOS build/test remains a managed capture-mini step; the
media-tourlabel requests the head tour. This checkout never builds native code on Big Red.agent-identity footer
Agent session: big-red