Skip to content

cmux NEXT: keep agent chrome lines and tool actions clear - #24729

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/austin-agent-polish
Oct 24, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
codex/austin-agent-polish

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Fix the two agent-chat chrome polish issues Austin reported: remove the focused pane hairline above a hidden-tab-bar chat header, keep the header strip centered in its native chrome band, and reserve a real action slot so a tool row's duration, Copy, and expand controls never overlap at narrow widths.

Leo asked: "also did we alr fix these? but we're just waiting on nightly?"
Austin reported: "^ do you see that there are an extra line here on top? not sure if this is intentional but I hope not at least haha.. could you fix this?" and "And then make sure it's vertically centered". He also reported: "In this case, the copy button and then expand icon are overlapping with each other as well..."

The native fix treats the hidden agent chat's webview strip as a chrome band for PaneOverlayView, so the focus ring starts below it. The webview fix marks rows that own the floating transcript Copy button, reserves the action slot before the chevron, and leaves Shell card actions in flow.

Design references matched: cmux-design-references/topics/tabs-and-panels.md (one centered pane chrome rhythm) and topics/status-and-progress.md (status actions stay readable at the trailing edge).

Before / after captures

Gallery captures on the leased capture mini (cropped to the gallery content area; light and dark, narrow and wide):

Case Before After
Dark, narrow tool row before after
Light, narrow tool row before after
Dark, wide agent pane before after
Light, wide agent pane before after

Each raw link returned HTTP 200.

Verification

  • bun test ./test/transcript-copy.test.tsx ./test/transcript-codex-turn.test.tsx (11 pass)
  • bun run typecheck (2564 files, no type errors)
  • python3 scripts/verify-local.py --repo . (11/11 selected checks passed; native compile/test deferred to fleet)
  • python3 scripts/cmux-next/prepush-gate.py (no new violations)
  • scripts/web-lint.sh ran; existing base reds remain in design-token baseline/text-focus and existing lint warnings. No new changed-file failure remained after formatting.
  • Native regression test: AgentHiddenHeaderChromeTests.hiddenAgentHeaderIsAChromeBand (fleet validation required by repository policy).

Observed / Not run

Native macOS build/test remains a managed capture-mini step; the media-tour label requests the head tour. This checkout never builds native code on Big Red.

agent-identity footer
Agent session: big-red

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 61830d1: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24729 -f ref=codex/austin-agent-polish -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on 61830d14f9 (run 40060372674 attempt 1): 1 code, 1 unknown.
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped.

Job Verdict Why
web / react-apps-check (2) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs agent-pane-agents-pill.test.ts by default the running agents sit in the tray above the composer, not in the transcript: failed (job)
  • seen on other PRs agent-pane-background-tasks.test.ts the summary card lists the chat's background tasks: running ones first, the finished folded: failed (job)
  • seen on other PRs agent-pane-older-rows-fade.test.ts Reduce Motion draws rows of an older page in full ink at once: failed (job)
  • seen on other PRs chat-palette-actions.test.ts (unnamed): failed (job)
  • seen on other PRs composer-paste-instant.test.tsx a pasted screenshot shows a chip in the paste's own frame, before its bytes are read: failed (job)
  • seen on other PRs composer-paste-instant.test.tsx two screenshots pasted at once show two chips at once: failed (job)
  • seen on other PRs composer-paste-instant.test.tsx a prompt sent while its screenshot is still being read goes once the chip is ready, with it: failed (job)
  • seen on other PRs composer-paste-instant.test.tsx a prompt held for its screenshot never goes to the chat the composer moved to: failed (job)
Matched log lines
web / react-apps-check (2): (fail) by default the running agents sit in the tray above the composer, not in the transcript [1602.77ms]

Not re-run automatically: web / react-apps-check (2), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 043edc6; does not block
red: web / Web status; NEW: green on the base 043edc6; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 043edc6 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on 043edc6 to compare; do not merge until green; see lane-rules

Tour of 61830d14f9 (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

Gallery before/after for 61830d1: 16 states rendered, 1 images differ, 1001 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 40057622840 -R manaflow-ai/cmux -n gallery-advisory-24729-61830d14f9e06e5d8076bc75bbf4f0a02d949fac (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.chat-find-bar/empty Apple System Colors Light unchanged 0% own conversation.css
agent-pane.chat-find-bar/empty Apple System Colors unchanged 0% own conversation.css
agent-pane.chat-find-bar/matches Apple System Colors Light unchanged 0% own conversation.css
agent-pane.chat-find-bar/matches Apple System Colors unchanged 0% own conversation.css
agent-pane.chat-find-bar/next-match Apple System Colors Light unchanged 0% own conversation.css
agent-pane.chat-find-bar/next-match Apple System Colors unchanged 0% own conversation.css
agent-pane.chat-find-bar/no-results Apple System Colors Light unchanged 0% own conversation.css
agent-pane.chat-find-bar/no-results Apple System Colors unchanged 0% own conversation.css
agent-pane.chat-width/standard Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/standard Apple System Colors unchanged 0% own App.tsx
agent-pane.chat-width/wide Apple System Colors changed 23.4% own App.tsx
agent-pane.chat-width/wide Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/wide-blocks Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/wide-blocks Apple System Colors unchanged 0% own App.tsx
agent-pane.coderouter-offer/claude-key Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/claude-key Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/deepseek-key Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/deepseek-key Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/sign-in Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/sign-in Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/rate-limited Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/rate-limited Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/on-coderouter Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/on-coderouter Apple System Colors unchanged 0% own conversation.css
agent-pane.coderouter-offer/moving Apple System Colors Light unchanged 0% own conversation.css
agent-pane.coderouter-offer/moving Apple System Colors unchanged 0% own conversation.css
agent-pane.composer-floats/scrolled-to-end Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-floats/scrolled-to-end Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-floats/composer-grown Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-floats/composer-grown Apple System Colors unchanged 0% own App.tsx
agent-pane.diff-panel/last-turn Apple System Colors Light unchanged 0% own conversation.css
agent-pane.diff-panel/last-turn Apple System Colors unchanged 0% own conversation.css

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 24, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Found 44 test failures on Blacksmith runners:

Failures

Test View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
---/--- View Logs
/tmp/tmpf7ggkghj/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmps9z6ojn8/summary-missing.json (live):/summary-missing.json (live): View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs

...and 34 more test failures. View all on Blacksmith: run 40057622953, run 40060372674, run 40057623096

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-q8uy6 created for this PR by the cmux coordinator.

@teamleaderleo teamleaderleo added the media-tour Run the cmux-next UI tour (cmux-next-media.yml) on every push label Oct 24, 2026
@teamleaderleo
teamleaderleo merged commit cd148a3 into feat-cmux-next Oct 24, 2026
206 of 239 checks passed
@teamleaderleo
teamleaderleo deleted the codex/austin-agent-polish branch October 24, 2026 03:57
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/40060430002 at cd148a3 failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at a514ee6. This pull request is one of 2 merged since: #24741, #24729.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 61830d14 Deployed Oct 24, 2026 by teamleaderleo via namespace autofix #2281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

media-tour Run the cmux-next UI tour (cmux-next-media.yml) on every push risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant