[teamleaderleo]

Restores the Crash safety check on the feature tip. Leo asked, “still failed checks? wtf?” about push run 40058806451.

The check had four over-budget crate/module rows plus two banned Swift sites. This removes the redundant unwraps introduced by #24652 (upload paths and batch tokens) and #24606 (dispatch JSON), replaces #24607's unreachable! with an exhaustive optional result, and records the existing main-thread guard around the inspector deinit introduced by #24707's follow-up 274ef5c1a5e73135f8b39d2ef871758710879596.

Before/after from the same scripts/cmux-next/check-crash-safety.sh command:

Count	Before	After
acpmux unwraps	141 (budget 139)	139
cmux-tui panic macros	34 (budget 33)	33
App assumeIsolated hits	1 (budget 0)	0
App force unwraps	1 (budget 0)	0
Guard exit	1	0

No baseline was raised. The inspector annotation names the immediately preceding Thread.isMainThread guard; no runtime behavior changes there. Rust formatting (edition 2024) and git diff --check pass. The authored head Linux app compile later exposed the inherited #24729 missing-return error (ok:false, 96.9s, job 665fbb793a817f249b040323); the separate one-word fix #24755 passed the same compile command at its exact head (ok:true, 61.3s, job 59ba1cc87c796adf6c018e53). This PR does not claim its earlier authored head compiled green. Independent Codex source review returned SHIP after an external merge had already occurred; the exact merged diff review is posted in the PR comments. Hosted full Rust tests were not used as a green receipt.

Changelog

none

Agent session: big-red

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 422e7b6: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24747 -f ref=cx3-base-red-crash-swiftui -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 28edaad to compare; do not merge until green; see lane-rules

Tour of 422e7b6efb (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

[blacksmith-sh]

Found 17 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmpe08335u4/summary-missing.json (live):/summary-missing.json (live):	View Logs
/tmp/tmpsqwyunbp/summary-fail.json (live):/summary-fail.json (live):	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs
bundle-map.json does not require CEF's LICENSE.txt/ bundle-map.json does not require CEF's LICENSE.txt	View Logs
convention violations found (ERROR lines above)./ convention violations found (ERROR lines above).	View Logs
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_ inputs_still_rewrites_them) (job='repair')/ test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_ inputs_still_rewrites_them) (job='repair')	View Logs
test_base_passes (main.NoticesPairTests.test_base_passes)/ test_base_passes (main.NoticesPairTests.test_base_passes)	View Logs

...and 7 more test failures. View all on Blacksmith: run 40060871371, run 40060870993

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

Independent Codex cross-review of exact head 422e7b6efb2f9ef0f47babb50fc5702c1ca78ce5 (422e7b6^..422e7b6): SHIP, no P1/P2/P3 findings.

Reviewer: separate red_concurrency Codex session. Reviewed the batch token, thread-guarded inspector cleanup, typed JSON map, parent-path error, and optional model selector. Full scripts/cmux-next/check-crash-safety.sh Packages/macOS/CmuxNext passed independently.

Timing: GitHub reported this PR merged at 2026-10-24T04:05:04Z before this cross-review returned; I did not invoke that merge. The reviewer inspected the exact merged source delta and found no fix-forward work.

Agent session: big-red