Skip to content

Fix flaky browser download activity accounting - #246

Merged
austinywang merged 2 commits into
mainfrom
cmux/fix-flaky-download-image-linked-file
Feb 21, 2026
Merged

austinywang merged 2 commits into
mainfrom
cmux/fix-flaky-download-image-linked-file

Conversation

@austinywang

@austinywang austinywang commented Feb 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • remove temporary debug instrumentation from this branch
  • keep the functional fix that starts download activity at WKDownload start instead of early policy detection
  • remove duplicate early increment path (onDownloadDetected) to avoid mismatched begin/end activity transitions

Validation

  • ./scripts/reload.sh --tag download-manu
  • Debug build succeeded

@cmux-agent

cmux-agent Bot commented Feb 21, 2026 •

Copy link
Copy Markdown
Contributor
Older manaflow preview screenshots (latest comment is below)

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit ad6f1f3.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.


Generated by manaflow preview system

@vercel

vercel Bot commented Feb 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Feb 21, 2026 6:13am

@cmux-agent

cmux-agent Bot commented Feb 21, 2026 •

Copy link
Copy Markdown
Contributor

Preview Videos and Screenshots

Open Workspace (1 hr expiry) · Open Dev Browser (1 hr expiry) · Open Diff Heatmap

Failed to capture screenshots for commit 92de6b0.

Claude Code native binary not found at /root/.bun/bin/claude. Please ensure Claude Code is installed via native installer or specify a valid path with options.pathToClaudeCodeExecutable.


Generated by manaflow preview system

@austinywang austinywang changed the title Add debug tracing for flaky context-menu downloads Fix flaky browser download activity accounting Feb 21, 2026
@austinywang
austinywang merged commit 3c0e3a7 into main Feb 21, 2026
5 checks passed
bn-l pushed a commit to bn-l/cmux that referenced this pull request Apr 3, 2026
* Add debug tracing for context-menu download flow

* Remove temporary download debug instrumentation
teamleaderleo added a commit that referenced this pull request Sep 26, 2026
Point vendor/bonsplit at manaflow-ai/bonsplit#252 (4e40d03), which re-lands
the nearest-pane directional focus fix on bonsplit main. The old pointer
(001ba86) was on a branch cut from an older bonsplit, so merging it would
have rolled back bonsplit #245, #246, and #248.

Co-authored-by: Austin Wang <austinwang115@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lawrencecchen added a commit that referenced this pull request Oct 2, 2026
Bump the ghostty submodule from b1a49b601 to 257a40956, the merge of
manaflow-ai/ghostty#252. That PR adds the offscreen embedded platform
(GHOSTTY_PLATFORM_OFFSCREEN = 6, CPU frame and Linux dmabuf callbacks,
app-thread draw) behind -Dembedded-offscreen, so the cross-platform GPUI
and cmux-browser clients can render daemon terminals offscreen on Linux
and Windows from the same fork. The default macOS GhosttyKit build does
not change, and cmux-next does not use the new platform.

feat-cmux-next now tracks fork main (coordinator decision), so the bump
also brings the fork-main merges between the old pin and the #252 base
dcb1d6965: #242 (PTY tee after the parser, under the renderer mutex),
#243, #245, #247, #250 (prompt line and replay fixes), #246, #248, #249
(VT replay blank cells keep the default style) and #251 (config API
window padding, whose fix commit was the old pin).

scripts/ghosttykit-checksums.txt pins the published 257a409 GhosttyKit
archive (build-ghosttykit.yml run 36989929300), which every cmux-next CI
job downloads. docs/ghostty-fork.md documents the offscreen platform, #242 and a map of
every merge in the range, with conflict notes. The cmux main pin's
local-only binding flag (324c02738) is not on fork main; cmux-next does
not use it.

This branch was successfully deployed

1 active deployment
Preview — 92de6b08 Deployed Feb 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant