Skip to content

Fix flaky browser download activity accounting #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinywang merged 2 commits into from
Feb 21, 2026
Merged

Fix flaky browser download activity accounting #246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad6f1f3
Add debug tracing for context-menu download flow
austinywang Feb 21, 2026
92de6b0
Remove temporary download debug instrumentation
austinywang Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions Sources/Panels/BrowserPanel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,15 +1164,13 @@ final class BrowserPanel: Panel, ObservableObject {
navDelegate.handleBlockedInsecureHTTPNavigation = { [weak self] request, intent in
self?.presentInsecureHTTPAlert(for: request, intent: intent, recordTypedNavigation: false)
}
navDelegate.onDownloadDetected = { [weak self] _ in
self?.beginDownloadActivity()
}
// Set up download delegate for navigation-based downloads.
// Downloads save to a temp file synchronously (no NSSavePanel during WebKit
// callbacks), then show NSSavePanel after the download completes.
let dlDelegate = BrowserDownloadDelegate()
// Download activity is already started at policy-detection time.
dlDelegate.onDownloadStarted = { _ in }
dlDelegate.onDownloadStarted = { [weak self] _ in
self?.beginDownloadActivity()
}
dlDelegate.onDownloadReadyToSave = { [weak self] in
self?.endDownloadActivity()
}
Expand Down Expand Up @@ -2277,8 +2275,6 @@ private class BrowserNavigationDelegate: NSObject, WKNavigationDelegate {
var openInNewTab: ((URL) -> Void)?
var shouldBlockInsecureHTTPNavigation: ((URL) -> Bool)?
var handleBlockedInsecureHTTPNavigation: ((URLRequest, BrowserInsecureHTTPNavigationIntent) -> Void)?
/// Called when navigation response policy decides to route to WKDownload.
var onDownloadDetected: ((String?) -> Void)?
/// Direct reference to the download delegate — must be set synchronously in didBecome callbacks.
var downloadDelegate: WKDownloadDelegate?
/// The URL of the last navigation that was attempted. Used to preserve the omnibar URL
Expand Down Expand Up @@ -2477,7 +2473,6 @@ private class BrowserNavigationDelegate: NSObject, WKNavigationDelegate {
#if DEBUG
dlog("download.policy=download reason=content-disposition mime=\(mime)")
#endif
onDownloadDetected?(response.suggestedFilename)
decisionHandler(.download)
return
}
Expand All @@ -2488,7 +2483,6 @@ private class BrowserNavigationDelegate: NSObject, WKNavigationDelegate {
#if DEBUG
dlog("download.policy=download reason=cannotShowMIME mime=\(mime)")
#endif
onDownloadDetected?(navigationResponse.response.suggestedFilename)
decisionHandler(.download)
return
}
Expand Down