Repository navigation
cmux-next: an unfocused pane's tabs fade less on a focus change (strength 0.6 -> 0.4) - #23956
Conversation
Leo: the "unfocused" opacity shift is mildly jarring; keep it, make it less drastic. With the default focus indicator (tabs, no ring) and no Ghostty unfocused-split-opacity, the pane veil does not draw, so the shift a split shows on a focus change is the unfocused pane's tab fade. 0.4 keeps the selected pill at 0.6 of its fill (was 0.4) and still above the 0.35 that left the focused pane hard to tell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2d-622e-7433-aed6-f3c248542f5d&host=cosmic-gray
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 4ae5de4 to compare; do not merge until green; see lane-rules |
|
Found 12 test failures on Blacksmith runners: Failures
...and 2 more test failures. View all on Blacksmith
|
From review: the tabs.md table still gave the 0.6 numbers, and design-tokens.json described the fade's hover fill as alpha * (1 - strength) where the code uses (1 - strength / 2) and floors the pill at 0.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d2d-622e-7433-aed6-f3c248542f5d&host=cosmic-gray
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
|
|
Review (independent subagent): SHIP at 2af1116
|
… web-bundle fix) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Bead |
|
Review (independent subagent): SHIP at 0bd552f
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo: "and also the "unfoused" opacity shift is MILDLY jarring... i think it's actually ok but just make the opacity shift not as drastic"
Leo-ask: ask-35d63f0002 (opacity part)
Cause
An unfocused pane can be marked in three ways. In a default two-pane split only one of them draws:
panes.inactiveDimming, theme token 0.10, already softened from 0.14 in cmux-next: unfocused panes dim subtly (a theme token) and ease over 150 ms #22948) draws only withlayoutdimming on,appearance.bordersnone with the border indicator, or ringless floating panes with the border indicator. The defaultappearance.focusIndicatoristabs, so it does not draw. Over a glass window (Leo'sglass-clear) its fill is clear anyway.unfocused-split-opacitydim is off unless the user's Ghostty config sets it (cmux loads= 1first).ChromeEmphasis.fade,focus.inactiveTabStrength) does draw. cmux-next: an unfocused pane's tabs fade further, so the focused pane is plain to see #22987 raised it from 0.35 to 0.6 so the focused pane is easy to tell apart for Cmd-W. That made the shift on every focus change bigger.Change
focus.inactiveTabStrengthdefault: 0.6 -> 0.4 (Debug tunable; theLayoutStyleliteral matches). On a focus change, the selected pill of the unfocused pane now keeps 0.6 of its fill (was 0.4), and its labels mix 40% toward the page (was 60%). The contrast floors (3.5:1, 2.5:1, 2:1) and the 150 ms veil ease are unchanged.FocusedPaneTabCueTestsnow checks both sides: the unfocused pill keeps between half and two thirds of the focused fill, so the cue stays visible and the shift is not drastic. The label check (fainter than 0.6 of the focused contrast, still above the floors) is unchanged.Changelog
Changed: In cmux NEXT, an unfocused pane's tabs fade less when focus moves to another pane.
Observed / Not run
compile-check --appandFocusedPaneTabCueTests(fleet package-test lane) at the head: results are in a comment.FocusedPaneTabCueTestson the tokens it produces, and Leo can compare values live with the Debug Settings slider.Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Softens the dim on an unfocused pane's tabs so switching focus is less jarring, while keeping the cue readable.
The default
focus.inactiveTabStrengthdrops from 0.6 to 0.4. 0.6 made the shift on every focus change too drastic; 0.35 was too faint to tell which pane Cmd-W would close. 0.4 keeps the selected pill at 0.6 of its focused fill. The contrast floors and the veil fade are unchanged, and the strength stays tunable in Debug Settings.FocusedPaneTabCueTeststo check both sides: the unfocused pill keeps between half and two thirds of the focused fill; the label fade check is unchanged.LayoutStyleliteral and the focus/design-token docs, correcting per-style fade values and the hover fill formula (alpha × (1 − strength/2)) at strength 0.4.Written for commit 0bd552f. Summary will update on new commits.