Skip to content

cmux-next: unfocused panes dim subtly (a theme token) and ease over 150 ms - #22948

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
cmux/subtle-pane-dim
Oct 21, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
cmux/subtle-pane-dim

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Leo: the opacity drop on unfocused panes is mildly jarring. Keep the effect, much subtler (about 1.0 to 0.9), with a short ease (~150 ms), as a theme token.

Change

  • The veil over an unfocused pane is a theme token, ThemeTokens.inactivePaneDim (0.10, was a hardcoded 0.14 in LayoutStyle), read through Palette.inactivePaneDim. The Debug Settings tunable panes.inactiveDimming still overrides it.
  • The veil eases over its own fade token, MotionFade.paneDim (0.15 s at the default speed, through the feedback motion gate), instead of riding the focus ring's 0.1 s focus fade. The ring keeps its timing.
  • A Ghostty unfocused-split-opacity the person set still replaces the token, as before. Glass is untouched: over a see-through window Palette.paneFill is clear, so the veil adds nothing there.

Changelog

Changed: Unfocused panes in cmux NEXT dim more subtly and ease in and out when focus moves.

Observed / Not run

  • Red then green: SubtlePaneDimTests (commit 1 only adds the test; on base the veil is 0.14 and there is no paneDim fade). Fleet steps pd-red-7698e99f2b and pd-green-24f729a18b were still running at merge; results go in a comment.
  • Observed: fleet compile-check --app passed on the head 30cec50; independent review subagent found the code correct (its blocking findings were stale docs in plans/cmux-next/motion.md and design-tokens.json/.md, fixed in the last commit).
  • Not run: no capture of the new look.
  • The theme token is a fixed value on ThemeTokens (0.10 for every theme), so it is tuned in code or with the Debug Settings tunable panes.inactiveDimming, not by a theme file or user setting.

Agent session: huge-blue

🤖 Generated with Claude Code

teamleaderleo and others added 2 commits October 21, 2026 04:44
…t fade

Fails on base: the veil is 0.14 and the dim rides the 0.1 s focus fade.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
…over 150 ms

Leo 2026-10-21: the dim over unfocused panes was mildly jarring. The veil is
ThemeTokens.inactivePaneDim (0.10, was 0.14) read through Palette, and it
fades over its own MotionFade.paneDim (0.15 s) instead of the focus ring's
0.1 s. A Ghostty unfocused-split-opacity the person set still wins.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c78-27ca-7140-a6c7-95f0db83b18c

@teamleaderleo teamleaderleo added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 30cec50: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22948 -f ref=cmux/subtle-pane-dim -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 30cec505b5; ci-status is green without them.

CI passes on 30cec505b5 (run 39545881856 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-dy074 created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit c31d49f into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/subtle-pane-dim branch October 21, 2026 04:53
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Red then green for SubtlePaneDimTests (fleet, scripts/ci/package-test-lane.sh suite Packages/macOS/CmuxNext ...):

  • Red, 7698e99 (test only), step pd-red-7698e99f2b: fails as expected. MotionFade(rawValue: "paneDim") → nil; abs(dim.amount - 0.10) → 0.04 (the old 0.14 veil).
  • Green, 24f729a (fix; the merged head only adds docs), step pd-green-24f729a18b: SubtlePaneDimTests and GhosttyUnfocusedSplitTests pass.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant