Skip to content

ci: the agent pane page ships the Inspector's ContextSection.css (base red since #23789) - #23935

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
fix-agent-pane-context-css
Oct 22, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
fix-agent-pane-context-css

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

What

#23789 added webviews/src/agent-session/acpmux/inspector/ContextSection.css (imported by ContextSection.tsx) but scripts/cmux-next/build-agent-pane-web.sh does not inline it. The script's imported-sheets check then stops the web step of every fleet app build on feat-cmux-next:

error: the agent pane imports webviews/src/agent-session/acpmux/inspector/ContextSection.css but build-agent-pane-web.sh does not add it to the page's styles

(fleet build job c1b9e21094ac3bbb5c792890, a capture build for #23883). This adds the sheet beside inspector.css. With the sheet on the page, webviews/test/agent-pane-no-capsules.test.ts sees the context section's 6 px meter (.acpmux-chat-inspector-context__bar, 3 px radius) as a capsule; it is a progress bar like .acpmux-context-bar, so it joins that test's capsules-by-nature list.

Tests

Observed / Not run

  • Observed: on this branch scripts/cmux-next/build-agent-pane-web.sh --check prints "agent pane web bundle builds" (exit 0). The failure above is the same check on the base.
  • Observed: bun test test/agent-pane-no-capsules.test.ts passes after a local build-agent-pane-web.sh; scripts/web-lint.sh passes.
  • Not run: a full fleet app build at this head.

Changelog

none

🤖 Generated with Claude Code

Agent session: cmux16

…e red since #23789)

#23789 added webviews/src/agent-session/acpmux/inspector/ContextSection.css,
imported by ContextSection.tsx, but build-agent-pane-web.sh did not inline it,
so its imported-sheets check fails every fleet app build (and every capture).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-5b39-7e21-bc3d-02eb374c820c&host=cmux16
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 22, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by chief-fix-2 on cmux16 · session

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review a131859: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23935 -f ref=fix-agent-pane-context-css -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on a131859f97 (run 39704869393 attempt 1): 1 code, 1 unknown.

Job Verdict Why
web / react-apps-check (3) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs agent-pane-jump-latest-motion.test.ts webkit: a reply streaming in during Jump to latest's glide is followed to its latest row: failed (job)
  • seen on other PRs lit-glyph-css.test.ts a lit control's ink is the lit glyph, not the raw accent: failed (job)
Matched log lines
web / react-apps-check (3): (fail) webkit: a reply streaming in during Jump to latest's glide is followed to its latest row [4235.75ms]

Not re-run automatically: web / react-apps-check (3), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; base red: the same failure on the base 3dc887b; does not block
red: web / react-apps-check; base red: the same failure on the base 3dc887b; does not block
red: web / react-apps-check (3); NEW: step Test webviews (+4 more) passes on the base 3dc887b; do not merge until green; see lane-rules

Tour of a131859f97 (run): no media. The tour did not run: only webview code changed (1 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label, then re-add media-tour, to tour it on a Mac.

Gallery before/after for a131859: 16 states rendered, 8 images differ, 1508 more touched states not rendered. Images are in the run's artifact, not on this public PR.

gh run download 39704869357 -R manaflow-ai/cmux -n gallery-advisory-23935-a131859f97805ba5743ce6e3f06d888c95220f0f (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.add-project-panel/environment Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.add-project-panel/environment Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.add-project-panel/sources Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.add-project-panel/sources Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.add-project-panel/directory Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.add-project-panel/directory Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.add-project-panel/keyboard Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.add-project-panel/keyboard Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-message-row/sent Apple System Colors changed 0.017% everything build-agent-pane-web.sh
agent-pane.agent-message-row/sent Apple System Colors Light changed 0.0162% everything build-agent-pane-web.sh
agent-pane.agent-message-row/sent-opened Apple System Colors Light changed 0.017% everything build-agent-pane-web.sh
agent-pane.agent-message-row/sent-opened Apple System Colors changed 0.0159% everything build-agent-pane-web.sh
agent-pane.agent-message-row/both-directions Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-message-row/both-directions Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-message-row/both-directions-opened Apple System Colors Light changed 0.0017% everything build-agent-pane-web.sh
agent-pane.agent-message-row/both-directions-opened Apple System Colors changed 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/paused Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/paused Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/held-list Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/held-list Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/repeating Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/repeating Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/cap Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/cap Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/release-failed Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/release-failed Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/resumed Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.agent-pair-note/resumed Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.artifact-panel/closed Apple System Colors Light unchanged 0% everything build-agent-pane-web.sh
agent-pane.artifact-panel/closed Apple System Colors unchanged 0% everything build-agent-pane-web.sh
agent-pane.artifact-panel/markdown Apple System Colors Light changed 0% everything build-agent-pane-web.sh
agent-pane.artifact-panel/markdown Apple System Colors changed 0% everything build-agent-pane-web.sh

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 22, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Found 9 test failures on Blacksmith runners:

Failures

Test View Logs
---/--- View Logs
---/--- View Logs
nightly cmux-tui resolve/nightly cmux-tui resolve View Logs
test/agent-pane-jump-latest-motion.test.ts/agent-pane-jump-latest-motion.test View Logs
test/agent-pane-jump-latest-motion.test.ts/agent-pane-jump-latest-motion.test View Logs
test/lit-glyph-css.test.ts/lit-glyph-css.test View Logs
test/lit-glyph-css.test.ts/lit-glyph-css.test View Logs
test/lit-glyph-css.test.ts/lit-glyph-css.test View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

…ess bar)

With ContextSection.css on the page, agent-pane-no-capsules saw its
6 px bar with a 3 px radius; like .acpmux-context-bar it is a meter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-5b39-7e21-bc3d-02eb374c820c&host=cmux16
@cursor

cursor Bot commented Oct 22, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, correctness first): SHIP at a131859

  • build-agent-pane-web.sh: ContextSection.css has no @import, and its selectors don't collide with inspector.css. All 70 non-test CSS imports under agent-session are accounted for, and --check passes.
  • agent-pane-no-capsules: the exempted .acpmux-chat-inspector-context__bar is a non-interactive aria-hidden meter. The exemption matches that exact selector only.
  • The remaining red, nightly-guards / release-notary ("Test What's New highlights and release notes"), fails the same way on base push run 39703950507 at db5d0b0.

@teamleaderleo
teamleaderleo merged commit 651dd43 into feat-cmux-next Oct 22, 2026
@teamleaderleo
teamleaderleo deleted the fix-agent-pane-context-css branch October 22, 2026 01:24
teamleaderleo added a commit that referenced this pull request Oct 22, 2026
…t pane build fix, #23935)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Oct 22, 2026
…pane CSS fix #23935)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Oct 22, 2026
… web-bundle fix)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant