Repository navigation
gallery: agent-pane entries show the product again (renamed controls, raced plays, blank stages) - #23237
Conversation
…st show it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
Sidebar search is "Search chats" (#19895) and the sidebar fills its shell; the start folder's home row reads "~" (#22724); Revoke lives in the composer's access menu (#20303); the composer-context strip shows only before a chat's first send (#20869). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
… the stage Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
…ane's frame; local reply image gets its host answer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
…lery-agent-pane-plays
|
Owned by chief-pet-default-off on huge-blue · session |
1 similar comment
|
Owned by chief-pet-default-off on huge-blue · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Pending: CI is running on Last result: Probably yours: Written by web and size checks: green
Agents: Tour of |
|
Found 15 test failures on Blacksmith runners: Failures
...and 5 more test failures. View all on Blacksmith: run 39578218430, run 39578218159
|
|
Bead |
|
|
…he frame Review of #23237: the harness notice's dismissed and sudo-update states check no notice is drawn (and dismissed keeps its step checks), the empty home checks the home area has no rows. The local reply image's seeded fixture hid the usePathInfo bug, so it goes back and the product fix follows in its own PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
…el chip's offer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
|
codex-review: SHIP at 6204e3c
|
#23325) #23237 added test/gallery-agent-pane-entries.test.ts with frames that load every gallery entry while #23250 added the check:browser-lanes guard against that, so webviews' bun run check is red on feat-cmux-next. Every PR that touches webviews/ or scripts/cmux-next/ now fails the cmux-next fast gates' web lint on it. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Shipped in:
|
Fourteen agent-pane gallery states had stopped showing the product. Each play hit a missing element, or the stage went blank once its play ran. Gallery fixtures and plays only; no product code changes.
Controls renamed or moved (the product changed; the entries follow it)
session-sidebar#search-filtered,#search-clears: the search field is "Search chats" (cmux-next: chats lists say chats; no-match message once #19895). The sidebar now fills anacpmux-shelllike the pane's, so filtering no longer moves the rail.start-folder#home-question,#root-refused: the home row reads "~" (cmux-next project picker: worktrees fold under their repository; repo icons, avatars and language glyphs #22724); the play finds it by its title.permission-panel#allowance: Revoke moved to the composer's access menu in fix(cx-9ah60): sequence agent chat bottom stack without overlap #20303, so it was moved, not lost. The play asserts the old card is gone and that the revoke still reaches the host.bottom-stack#pr-queue: the composer-context strip shows only before a chat's first send (Composer: show the location strip only before a chat's first send #20869, fix(agent-pane): preserve composer slot after first send #21363). The play asserts it stays away.Plays that raced the stage
header-tools#pull-request-status,#pull-request-merge: wait for the PR chip before clicking it.dictation#hide: opens the button's menu with a real context menu.Stages that drew one part alone
harness-health-notice#dismissed,#sudo-update,file-search#escape,home-lists#empty: each draws the pane's frame with the real composer. Not Now, Escape or an empty home now leave the composer in view, not an empty stage. The notice's anchor is the composer.Test
webviews/test/gallery-agent-pane-entries.test.ts(Chromium on the gallery dev server). It runs each of the 13 states and checks that it reaches ready "1" with no page error and no play error. It also checks its anchors and layout shift. For the blank stages it checks the pane's frame is still there, and that the component drew what the variant is for: no notice after Not Now or for a sudo update, no list rows in an empty home. Long frames don't fail it.cd webviews && CMUX_BROWSER_TESTS=1 bun test test/gallery-agent-pane-entries.test.ts8e797b7aaf9with the test copied in: 0 pass, 14 fail (no element for input[aria-label="Search sessions"],no element for option "/\/Users\/you$/",no element for .acpmux-header-pr,no element for menuitem "Hide Dictation Button", blank stages)9aa00c6e20f: 13 passObserved / Not run
warmDevServer100 s limit; the rerun passed 13/13.prepush-gate.py: no new violations.scripts/web-lint.sh: everything passes except formatting insrc/agent-session/acpmux/App.tsx, which is a base red at9aa00c6e20f. This PR doesn't touch that file.session-sidebar#rail-keyboardtimes out after ArrowDown/End.session-sidebar#view-switching-animation-auditfinds no.acpmux-sidebar-activewhen projects are grouped.harness-health-notice#restart-after-turnlayout-shifts about 0.002 because Not Now moves when the main action appears.reply-image#localstays as it is. The React Compiler cachesusePathInfo's reads (chips/linkStore.ts) by path, so the host's answer never redraws a local image. Review found that seeding the fixture here hid that bug. The product fix and this entry follow in their own PR.accessibleName()fix.No capture: gallery fixtures only. The gallery advisory run shows these states.
Changelog
none
Agent session: huge-blue
🤖 Generated with Claude Code