Skip to content

gallery: agent-pane entries show the product again (renamed controls, raced plays, blank stages) - #23237

Merged
teamleaderleo merged 8 commits into
feat-cmux-nextfrom
cmux/gallery-agent-pane-plays
Oct 21, 2026
Merged

teamleaderleo merged 8 commits into
feat-cmux-nextfrom
cmux/gallery-agent-pane-plays

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fourteen agent-pane gallery states had stopped showing the product. Each play hit a missing element, or the stage went blank once its play ran. Gallery fixtures and plays only; no product code changes.

Controls renamed or moved (the product changed; the entries follow it)

Plays that raced the stage

  • header-tools#pull-request-status, #pull-request-merge: wait for the PR chip before clicking it.
  • dictation#hide: opens the button's menu with a real context menu.

Stages that drew one part alone

  • harness-health-notice#dismissed, #sudo-update, file-search#escape, home-lists#empty: each draws the pane's frame with the real composer. Not Now, Escape or an empty home now leave the composer in view, not an empty stage. The notice's anchor is the composer.

Test

webviews/test/gallery-agent-pane-entries.test.ts (Chromium on the gallery dev server). It runs each of the 13 states and checks that it reaches ready "1" with no page error and no play error. It also checks its anchors and layout shift. For the blank stages it checks the pane's frame is still there, and that the component drew what the variant is for: no notice after Not Now or for a sudo update, no list rows in an empty home. Long frames don't fail it.

cd webviews && CMUX_BROWSER_TESTS=1 bun test test/gallery-agent-pane-entries.test.ts

  • base 8e797b7aaf9 with the test copied in: 0 pass, 14 fail (no element for input[aria-label="Search sessions"], no element for option "/\/Users\/you$/", no element for .acpmux-header-pr, no element for menuitem "Hide Dictation Button", blank stages)
  • head, merged with base 9aa00c6e20f: 13 pass

Observed / Not run

  • Observed: the test above, red on base and green on head. On a cold dev server, the first run after the base merge hit the shared warmDevServer 100 s limit; the rerun passed 13/13. prepush-gate.py: no new violations.
  • scripts/web-lint.sh: everything passes except formatting in src/agent-session/acpmux/App.tsx, which is a base red at 9aa00c6e20f. This PR doesn't touch that file.
  • Not fixed here, found while checking these entries:
    • session-sidebar#rail-keyboard times out after ArrowDown/End.
    • session-sidebar#view-switching-animation-audit finds no .acpmux-sidebar-active when projects are grouped.
    • harness-health-notice#restart-after-turn layout-shifts about 0.002 because Not Now moves when the main action appears.
    • reply-image#local stays as it is. The React Compiler caches usePathInfo's reads (chips/linkStore.ts) by path, so the host's answer never redraws a local image. Review found that seeding the fixture here hid that bug. The product fix and this entry follow in their own PR.
  • The "waitFor did not hold" plays are left to the gallery-perf lane's accessibleName() fix.

No capture: gallery fixtures only. The gallery advisory run shows these states.

Changelog

none

Agent session: huge-blue

🤖 Generated with Claude Code

teamleaderleo and others added 6 commits October 21, 2026 08:56
Sidebar search is "Search chats" (#19895) and the sidebar fills its shell; the start folder's home
row reads "~" (#22724); Revoke lives in the composer's access menu (#20303); the composer-context
strip shows only before a chat's first send (#20869).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
…ane's frame; local reply image gets its host answer

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by chief-pet-default-off on huge-blue · session

1 similar comment
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by chief-pet-default-off on huge-blue · session

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 2407060: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23237 -f ref=cmux/gallery-agent-pane-plays -f platform=macos -f backend_mode=local

Pending: CI is running on 24070608c5 (run); the result below was for 89c7712e5b and no longer applies.

Last result: Probably yours: chat-find.test.ts fails here but not on main's latest full suite. Seen on other PRs too (likely flaky): gallery-coverage.test.ts, agent-pane-math.test.tsx, thread-minimap-feel.test.ts and 2 more.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); it is rewritten when this head's CI completes.

web and size checks: green

CI fast guards failed on 89c7712e5b (https://github.com/manaflow-ai/cmux/actions/runs/39573993938). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

Tour of 6204e3c689 (run): no media. The tour did not run: only webview code changed (10 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 15 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp1kt7u_y2/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpztpmu7cb/summary-fail.json (live):/summary-fail.json (live): View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test/agent-pane-scrollbar-full-height.test.ts/agent-pane-scrollbar-full-height.test View Logs
test/agent-pane-scrollbar-full-height.test.ts/agent-pane-scrollbar-full-height.test View Logs
test/composer-claude-split.test.ts/composer-claude-split.test View Logs
test/composer-claude-split.test.ts/composer-claude-split.test View Logs
test/home-composer-menu.test.tsx/home-composer-menu.test.tsx View Logs
test/home-composer-menu.test.tsx/home-composer-menu.test.tsx View Logs
test/home-quote-selection.test.tsx/home-quote-selection.test.tsx View Logs

...and 5 more test failures. View all on Blacksmith: run 39578218430, run 39578218159

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-jn01c created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next / cmux-next checks (god files, concurrency, crash safety, l10n) › Tier routing is red on 7 of 10 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

teamleaderleo and others added 2 commits October 21, 2026 09:26
…he frame

Review of #23237: the harness notice's dismissed and sudo-update states check
no notice is drawn (and dismissed keeps its step checks), the empty home checks
the home area has no rows. The local reply image's seeded fixture hid the
usePathInfo bug, so it goes back and the product fix follows in its own PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

codex-review: SHIP at 6204e3c

  • Reviewed the current diff, its focused tests, and the affected call paths; no correctness bug found.

@teamleaderleo
teamleaderleo merged commit c1d4c23 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/gallery-agent-pane-plays branch October 21, 2026 10:39
teamleaderleo added a commit that referenced this pull request Oct 21, 2026
#23325)

#23237 added test/gallery-agent-pane-entries.test.ts with frames that load every gallery entry while #23250
added the check:browser-lanes guard against that, so webviews' bun run check is red on feat-cmux-next. Every PR
that touches webviews/ or scripts/cmux-next/ now fails the cmux-next fast gates' web lint on it.


Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant