Repository navigation
test(gallery): agent-pane entry cases open each entry's own frame (base red: check:browser-lanes) - #23326
test(gallery): agent-pane entry cases open each entry's own frame (base red: check:browser-lanes)#23326teamleaderleo wants to merge 1 commit into
Conversation
#23250's browser-lane guard landed beside #23237, so check:browser-lanes is red on base for this file: its frames loaded every gallery file. They now open galleryFrame(entry) and warm each entry's frame, which also ends the cold 100 s warm-up timeouts this file hit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
|
Owned by chief-pet-default-off on huge-blue · session |
|
Bead |
|
Closing as a duplicate of #23325, which fixes the same check:browser-lanes base red the same way and is already in review. The one difference: this branch gives warmGalleryFrame a 200 s budget for all 9 entries together, against the 100 s default; I've passed that to land-and-ci. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: web / Web status; NEW: green on the base 2482f23; do not merge until green; see lane-rules |
Summary
Base red:
check:browser-lanesfails onwebviews/test/gallery-agent-pane-entries.test.ts(lines 85 and 94, "opens a gallery frame without entryPath"). #23250 added that guard, and #23237 added this file, at about the same time. The cases now opengalleryFrame(entry, { variant }), andwarmGalleryFramewarms each entry's frame instead of every gallery file. That also ends the cold 100 s warm-up timeouts this file used to hit.Changelog
none
Test
cd webviews && bun run check:browser-lanes: red on basee07b30ae690(the two lines above); passes on head.CMUX_BROWSER_TESTS=1 bun test test/gallery-agent-pane-entries.test.tson a cold server: 12 of 13 passed in 111 s, with no warm-up timeout. The one failure,harness-health-notice#dismissed(layout shift 0.0019 on clicking Update), passed on the rerun. That is the notice's leading spinner moving the words whenever the "updating" frame gets painted, a product bug the Not Now PR fixes.Observed / Not run
scripts/web-lint.shpasses.prepush-gate.py: no new violations.No capture: test-only change.
Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the gallery agent-pane entry tests so each case opens its own entry's frame, satisfying the new browser-lane guard.
galleryFrameinstead of every gallery file.warmGalleryFramewarms each entry's frame, ending the cold 100 s warm-up timeouts this file hit.Written for commit 0f09604. Summary will update on new commits.