Repository navigation
fix(agent-pane): preserve composer slot after first send - #21363
Conversation
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
88f3b9c to
7055daf
Compare
|
Visual preview of fe2d254: in the maintainers' private review feed. |
3a03de4 to
6be435f
Compare
|
Hosted exact-head receipt for
|
This comment has been minimized.
This comment has been minimized.
|
all web/size checks green |
|
Passes: CI passes on CI passes on Written by |
|
|
|
Independent triage receipt: exact head 6be435f remains mergeable but hosted react-apps-check/Web status are red on composer-location-strip.test.ts (20 pass, 1 fail; 46px geometry drift). This is a deterministic composer-layout regression/branch interaction, so I am holding the PR rather than treating the queued release compile as sufficient. Repair or rebase against the current composer geometry fix, then rerun the exact-head web suite. |
|
Focused repair pushed at exact head The deterministic 46px failure came from latching the hidden composer slot during a transient unselected render. The fix only latches that slot after observing a visible strip for the same known session key, and adds a reopened-history regression test. Local focused test and typecheck passed; hosted browser/web checks are the acceptance gate. |
|
The reviewed fix is now on the PR branch at exact head |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Exact-head follow-up |
|
Exact-head 740e composer regression coverage passed; the only red web shard is the repeated unrelated |
- vp fmt webviews/src/agent-session/acpmux/Composer.tsx Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39085357990
740e090 to
fe2d254
Compare
|
Visual review: HQ feed · workflow run |
Summary
Keep the cx-ncc.58 composer stable through the first send and add a regression for the pending harness transition. The visible location strip disappears after the first send, but a session-scoped hidden slot preserves the bottom-anchored composer controls while transcript rows mount; queued prompts replace that slot, and reopened chats do not inherit it. The test also locks the single
thinking-liverow and its status transition.This is intentionally current-base only. It does not cherry-pick the stale native strip patch or the broad motion/sidebar work from #21331.
Validation
bun test test/composer-location-row-new-chat-only.test.tsx— 5 passbun test test/transcript-live-runs.test.tsx— 4 passbun run typecheck— no type errors in 1482 filesvp fmt ... --checkgit diff --checkHosted exact-head validation is required for
agent-pane.new-chat-no-shift#send-to-streaming; the prior base receipt reproduced the 45.9px jump in both Chromium and WebKit.