Skip to content

fix(agent-pane): preserve composer slot after first send - #21363

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
codex/cx-ncc58-regression
Oct 18, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
codex/cx-ncc58-regression

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Keep the cx-ncc.58 composer stable through the first send and add a regression for the pending harness transition. The visible location strip disappears after the first send, but a session-scoped hidden slot preserves the bottom-anchored composer controls while transcript rows mount; queued prompts replace that slot, and reopened chats do not inherit it. The test also locks the single thinking-live row and its status transition.

This is intentionally current-base only. It does not cherry-pick the stale native strip patch or the broad motion/sidebar work from #21331.

Validation

  • bun test test/composer-location-row-new-chat-only.test.tsx — 5 pass
  • bun test test/transcript-live-runs.test.tsx — 4 pass
  • bun run typecheck — no type errors in 1482 files
  • vp fmt ... --check
  • git diff --check

Hosted exact-head validation is required for agent-pane.new-chat-no-shift#send-to-streaming; the prior base receipt reproduced the 45.9px jump in both Chromium and WebKit.

@cursor

cursor Bot commented Oct 17, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9223990c-7b71-462e-af5d-4387aae89f3f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo force-pushed the codex/cx-ncc58-regression branch from 88f3b9c to 7055daf Compare October 17, 2026 23:00
@teamleaderleo teamleaderleo changed the title test(agent-pane): keep pending harness thinking row stable fix(agent-pane): preserve composer slot after first send Oct 17, 2026
@teamleaderleo

teamleaderleo commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator Author

Visual preview of fe2d254: in the maintainers' private review feed.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Hosted exact-head receipt for 6be435f2710c97f7b83b7834da890ff4f648282d:

  • Chromium and WebKit still report press Enter: anchor .acpmux-model moved 45.9px.
  • Direct stage geometry shows the hidden placeholder present at 46px before interaction and the final composer/model geometry unchanged.
  • This indicates the gallery play is snapshotting the pre-placeholder frame, or otherwise measuring before the layout-preserving slot mounts. The receipt is red for the play, so this PR is not merge-ready; please keep the guard closed while the play timing/fixture is repaired.

@blacksmith-sh

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

all web/size checks green

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Passes: CI passes on fe2d2540dc.

CI passes on fe2d2540dc (run 39094780775 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards passes on fe2d2540dc (https://github.com/manaflow-ai/cmux/actions/runs/39094780775). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent triage receipt: exact head 6be435f remains mergeable but hosted react-apps-check/Web status are red on composer-location-strip.test.ts (20 pass, 1 fail; 46px geometry drift). This is a deterministic composer-layout regression/branch interaction, so I am holding the PR rather than treating the queued release compile as sufficient. Repair or rebase against the current composer geometry fix, then rerun the exact-head web suite.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Focused repair pushed at exact head 7adb3a2f4a282060105ede63e1498ec7b0134dd5.

The deterministic 46px failure came from latching the hidden composer slot during a transient unselected render. The fix only latches that slot after observing a visible strip for the same known session key, and adds a reopened-history regression test. Local focused test and typecheck passed; hosted browser/web checks are the acceptance gate.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

The reviewed fix is now on the PR branch at exact head 7adb3a2f4a282060105ede63e1498ec7b0134dd5. Previous 6be CI receipts are stale; hosted checks are rerunning for this head.

@cursor

cursor Bot commented Oct 18, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Exact-head follow-up 740e090fabdf12221881afe718d50a7cda0ec229 is the formatter autofix on top of the reviewed latch repair. The deterministic composer geometry regression is addressed; prior 7adb receipts are stale. Waiting on fresh hosted browser/web and release checks.

@blacksmith-sh

blacksmith-sh Bot commented Oct 18, 2026

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
test/apps-flow.test.ts/apps-flow.test View Logs
test/apps-flow.test.ts/apps-flow.test View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Exact-head 740e composer regression coverage passed; the only red web shard is the repeated unrelated apps-flow.test.ts empty-catalog timeout in Chromium/WebKit at line 158 (.apps-empty). The other shard passed and release compile passed. Holding merge until the shared apps-flow failure is resolved or a fresh green exact-head web run is available.

@teamleaderleo
teamleaderleo force-pushed the codex/cx-ncc58-regression branch from 740e090 to fe2d254 Compare October 18, 2026 03:46
@github-actions

Copy link
Copy Markdown
Contributor

Visual review: HQ feed · workflow run

@teamleaderleo
teamleaderleo merged commit fff8130 into feat-cmux-next Oct 18, 2026
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant