Skip to content

fix(cmux-next): restore composer row rhythm and open-chip wash (base red since #21574) - #21645

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/composer-row-rhythm-chip-press
Oct 18, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/composer-row-rhythm-chip-press

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Every feat-cmux-next pull request since #21574 fails web / react-apps-check (2) on two test files it did not touch. #21574 merged with that job red (its local run skipped the browser lane). This puts back the two values that broke them, and keeps the rest of #21574.

  • composer-row-rhythm.test.ts failed with uneven gaps inside groups: model→effort 19.0, steer→mic 16.0, mic→send 16.0 at all four widths. --acpmux-row-gap went from 4 px to 7 px, which only the model/effort pair uses; the trailing cluster's gap was pinned to 4 px. Back to 4 px puts model and effort 16 px apart like the trailing controls. The +/chips and mode group gaps are unchanged (the mode padding is group-gap − row-gap, so the drawn group gap stays the same).
  • composer-chip-press.test.ts failed with pressed oklab(… / 0.16) against held color(srgb … / 0.11). The open-chip rule fix(cmux-next): align composer control chrome #21574 added after the ink-only hover used --acpmux-row-hover (the 11% pill hover). The rule it overrides used --acpmux-pill-open (16%), the tone the press shows. It now uses --acpmux-pill-open again, and still wins over the transparent hover.

Testing

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the two CSS value regressions from #21574 so web / react-apps-check (2) passes again; every feat-cmux-next PR since that merge has failed two test files it doesn't touch.

  • Restores --acpmux-row-gap: 4px so model and effort sit 16 px apart, matching the trailing Interrupt, mic, and Send cluster.
  • Selected/open chips now keep their --acpmux-pill-open 16% wash on hover instead of the 11% ink-only hover tone, so a press matches the held chip.

Written for commit 5a3ad5c. Summary will update on new commits.

View guided diff Turn on auto-fix

#21574 merged with web / react-apps-check (2) red, and every feat-cmux-next PR
since inherits two failing files:

- composer-row-rhythm: a 7 px row gap put model and effort 19 px apart while
  Interrupt, mic and Send stay 16 px apart. Back to 4 px, so the in-group gap is
  16 px everywhere; the between-group gap is unchanged.
- composer-chip-press: the open chip's late override used the 11% hover tone, so
  a press (16% open tone) no longer matched the held, open chip. It now uses
  --acpmux-pill-open like the rule it overrides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d2eadf6d-2489-4592-baf6-a496d80eda3f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Receipt for 5a3ad5c (this PR's head; a new push replaces it)

  • Visual review: HQ feed card · gallery before/after runs
  • Checks: this head
  • App of this head (app.zip, kept 1 day): gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr21645 -f ref=fix/composer-row-rhythm-chip-press -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Visual preview of 5a3ad5c: in the maintainers' private review feed.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-uotcn created for this PR by the cmux coordinator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant