Repository navigation
fix(cmux-next): restore composer row rhythm and open-chip wash (base red since #21574) - #21645
Conversation
#21574 merged with web / react-apps-check (2) red, and every feat-cmux-next PR since inherits two failing files: - composer-row-rhythm: a 7 px row gap put model and effort 19 px apart while Interrupt, mic and Send stay 16 px apart. Back to 4 px, so the in-group gap is 16 px everywhere; the between-group gap is unchanged. - composer-chip-press: the open chip's late override used the 11% hover tone, so a press (16% open tone) no longer matched the held, open chip. It now uses --acpmux-pill-open like the rule it overrides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Receipt for
|
|
Visual preview of 5a3ad5c: in the maintainers' private review feed. |
|
Bead |
Every feat-cmux-next pull request since #21574 fails
web / react-apps-check (2)on two test files it did not touch. #21574 merged with that job red (its local run skipped the browser lane). This puts back the two values that broke them, and keeps the rest of #21574.composer-row-rhythm.test.tsfailed withuneven gaps inside groups: model→effort 19.0, steer→mic 16.0, mic→send 16.0at all four widths.--acpmux-row-gapwent from 4 px to 7 px, which only the model/effort pair uses; the trailing cluster's gap was pinned to 4 px. Back to 4 px puts model and effort 16 px apart like the trailing controls. The+/chips and mode group gaps are unchanged (the mode padding isgroup-gap − row-gap, so the drawn group gap stays the same).composer-chip-press.test.tsfailed with pressedoklab(… / 0.16)against heldcolor(srgb … / 0.11). The open-chip rule fix(cmux-next): align composer control chrome #21574 added after the ink-only hover used--acpmux-row-hover(the 11% pill hover). The rule it overrides used--acpmux-pill-open(16%), the tone the press shows. It now uses--acpmux-pill-openagain, and still wins over the transparent hover.Testing
warmDevServer: / still cold after 100000 ms) both before and after this change, so this PR's ownreact-apps-check (2)run is the evidence.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the two CSS value regressions from #21574 so
web / react-apps-check (2)passes again; every feat-cmux-next PR since that merge has failed two test files it doesn't touch.--acpmux-row-gap: 4pxso model and effort sit 16 px apart, matching the trailing Interrupt, mic, and Send cluster.--acpmux-pill-open16% wash on hover instead of the 11% ink-only hover tone, so a press matches the held chip.Written for commit 5a3ad5c. Summary will update on new commits.