fix(cmux-next): align composer control chrome by teamleaderleo · Pull Request #21574 · manaflow-ai/cmux

teamleaderleo · 2026-10-18T10:26:02Z

Summary

Align cmux NEXT composer control chrome with the shared compact rhythm: location controls keep transparent hover hit areas, chevrons receive the same optical correction, focus rings remain clear, and the model/effort/action spacing stays stable across narrow rows.

Changelog

Changed

Tightened composer control spacing and chevron alignment while preserving the existing location and New Tab implementations.

Testing

cd webviews && bun run typecheck — passed; no type errors in 1514 files.
cd webviews && bun test test/composer-row-fit.test.ts — 3 passed.
cd webviews && bun test test/composer-row-rhythm.test.ts — browser lane skipped locally because CMUX_BROWSER_TESTS is unset; the suite is intended for CI/Freestyle browser hosts.
git diff --check — passed.

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Aligns the cmux NEXT composer control chrome with the shared compact rhythm so location, model/effort, and action controls draw consistent spacing, hover, and focus behavior.

Location and composer chip controls keep transparent hover hit areas; only open or selected controls show their state wash.
Down-chevrons across location and picker controls share the same 0.75px optical correction, now asserted by the row-rhythm test.
Focus-visible outlines are uniform 2px with a 2px offset (larger under prefers-contrast: more).
Model/effort row gaps are retuned to 7px/10px so they read as the same optical gap as trailing controls.
The icons-fit mode keeps the effort chip at its measured 49px width.

^{Written for commit 0bf3444. Summary will update on new commits.}

coderabbitai · 2026-10-18T10:26:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: ba602bf6-bd2b-4e0b-b06c-37e79baef146

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-18T10:26:11Z

Visual review: HQ feed · workflow run

teamleaderleo · 2026-10-18T10:27:50Z

Visual preview of 0bf3444: in the maintainers' private review feed.

teamleaderleo · 2026-10-18T10:28:36Z

Bead cx-pm1o9 created for this PR by the cmux coordinator.

github-actions · 2026-10-18T10:28:57Z

red: web / Web status; do not merge until green; see lane-rules
red: web / react-apps-check; do not merge until green; see lane-rules
red: web / react-apps-check (2); do not merge until green; see lane-rules

github-actions · 2026-10-18T10:29:19Z

Unclear: web / react-apps-check (2) failed: no known signature; failed step: Test webviews.

CI failed on 0bf3444821 (run 39121213034 attempt 1): 2 unknown.

Job	Verdict	Why
web / react-apps-check (2)	unknown	no known signature; failed step: `Test webviews`
web / react-apps-check	unknown	no known signature; failed step: `Check webview test shards`

Not re-run automatically: web / react-apps-check (2), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

github-actions · 2026-10-18T10:29:49Z

CI fast guards failed on 0bf3444821 (https://github.com/manaflow-ai/cmux/actions/runs/39121213034). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally. This comment is updated in place on each push.

cursor · 2026-10-18T10:56:17Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

blacksmith-sh · 2026-10-18T11:11:41Z

Found 4 test failures on Blacksmith runners:

Failures

Test	View Logs
`test/composer-chip-press.test.ts/composer-chip-press.test`	View Logs
`test/composer-chip-press.test.ts/composer-chip-press.test`	View Logs
`test/composer-row-rhythm.test.ts/composer-row-rhythm.test`	View Logs
`test/composer-row-rhythm.test.ts/composer-row-rhythm.test`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

github-actions · 2026-10-18T12:11:40Z

cmux-next tour of 0bf3444821455f20de5dd497dce0ae8f0227d254 (run)

The tour job failed before the tour ran (build or setup); the run log has the output.

The tour produced no media.

_{Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.}

#21574 merged with web / react-apps-check (2) red, and every feat-cmux-next PR since inherits two failing files: - composer-row-rhythm: a 7 px row gap put model and effort 19 px apart while Interrupt, mic and Send stay 16 px apart. Back to 4 px, so the in-group gap is 16 px everywhere; the between-group gap is unchanged. - composer-chip-press: the open chip's late override used the 11% hover tone, so a press (16% open tone) no longer matched the held, open chip. It now uses --acpmux-pill-open like the rule it overrides. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

fix(cmux-next): align composer control chrome

77e6046

teamleaderleo force-pushed the codex/cmux-next-composer-chrome-20261018 branch from 455b5c4 to 77e6046 Compare October 18, 2026 10:48

chore(web): apply formatter to composer rhythm test

0bf3444

teamleaderleo merged commit eeb9cec into feat-cmux-next Oct 18, 2026
102 of 105 checks passed

teamleaderleo deleted the codex/cmux-next-composer-chrome-20261018 branch October 18, 2026 11:47

This was referenced Oct 18, 2026

ci(gallery-link): post one PR receipt with commit, checks and app #21636

Merged

fix(cmux-next): restore composer row rhythm and open-chip wash (base red since #21574) #21645

Merged

This was referenced Oct 18, 2026

fix(next): stop What's New repeating each title as its description #21650

Merged

cmux-next: canonical Composer and work-first orchestration gallery #21200

Closed

Navigation Menu

Repository navigation

fix(cmux-next): align composer control chrome - #21574

fix(cmux-next): align composer control chrome#21574
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
codex/cmux-next-composer-chrome-20261018

teamleaderleo commented Oct 18, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 18, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Oct 18, 2026 •

edited

Loading

Uh oh!

teamleaderleo commented Oct 18, 2026 •

edited

Loading

Uh oh!

teamleaderleo commented Oct 18, 2026

Uh oh!

github-actions Bot commented Oct 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 18, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 18, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Oct 18, 2026

Uh oh!

blacksmith-sh Bot commented Oct 18, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 18, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 18, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Changed

Testing

Summary by cubic

Uh oh!

coderabbitai Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 18, 2026

Uh oh!

github-actions Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Oct 18, 2026

Bugbot needs on-demand usage enabled

Uh oh!

blacksmith-sh Bot commented Oct 18, 2026

Failures

Uh oh!

Uh oh!

github-actions Bot commented Oct 18, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 18, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Oct 18, 2026 •

edited

Loading

github-actions Bot commented Oct 18, 2026 •

edited

Loading

teamleaderleo commented Oct 18, 2026 •

edited

Loading

github-actions Bot commented Oct 18, 2026 •

edited

Loading

github-actions Bot commented Oct 18, 2026 •

edited

Loading

github-actions Bot commented Oct 18, 2026 •

edited

Loading