fix(cmux-next): hide access grant count from pill by teamleaderleo · Pull Request #21575 · manaflow-ai/cmux

teamleaderleo · 2026-10-18T10:28:57Z

Summary

The Agent Chat access pill showed the number of granted permissions beside the current mode, which made the compact footer wider without adding an action. The pill now keeps its mode label and lock/shield affordance while leaving grant details in the menu.

Testing

cd webviews && bun test test/access-chip-pending-warning.test.tsx test/composer-chip-press.test.ts test/composer-row-layout.test.ts test/composer-row-fit.test.ts — 9 passed, 2 browser-lane tests skipped because they require CI/Freestyle.
cd webviews && bun run typecheck — no type errors in 1,514 files.
The focused regression was committed first as c3822b809d6; it failed against the old count span. The fix is 0e6ae8101be.
The repository-wide python3 scripts/verify-local.py preflight selected 30,166 paths because this feature base is behind origin/main; it was interrupted during the unrelated Swift syntax sweep. The scoped web checks above are the executed evidence for this two-file web change.

Changelog

Fixed: The Agent Chat access pill no longer shows a grant count; grant details remain available in its menu.

Proof

The focused DOM test renders a granted access state and verifies that the compact pill has no count while retaining its mode label.

Checklist

Behavior changes have added or updated tests.
No user-facing strings changed; localization audit has no new strings.
Reviewed with a subagent before merge; this child PR is ready for maintainer review.

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

Hides the access grant count from the Agent Chat composer pill so the compact footer stays narrow; grant details remain available in the access menu.

Bug Fixes

Coalesces divider and column drag commands so the daemon stops timing out.
Rebuilds warm CI prebuilt modules after a binary pin change and keeps a pulled nightly build off the feed.
Stops the feed wire from reconnecting with a server-refused token.

New Features

Pins the Home dock column, auto-resumes agents stopped on errors, and lets cmux:// links open in the app.
Adds Go to Workspace palette navigation, compact composer attachments, markdown font size settings, and a Desktop Wallpaper fallback.

Updated the access-grant gallery play and test coverage to match the new no-count pill behavior.

^{Written for commit f03bb1b. Summary will update on new commits.}

coderabbitai · 2026-10-18T10:29:05Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: f485ea00-cb79-476c-98aa-4564563adcfc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

teamleaderleo · 2026-10-18T10:30:58Z

Visual preview of 626479a: in the maintainers' private review feed.

teamleaderleo · 2026-10-18T10:38:50Z

Bead cx-ip6r8 created for this PR by the cmux coordinator.

cursor · 2026-10-18T10:48:42Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

teamleaderleo · 2026-10-18T11:54:58Z

Skipping the merge: an independent review of head 47d8762 found that this breaks a gallery play the PR did not update.

Blocking: webviews/src/agent-session/acpmux/ComposerPickers.gallery.tsx:212-213 (the access-grants play) throws "Access trigger is missing the compact allowed-rule count" when .acpmux-access-grant-count is absent. This PR deletes that element, so the play now fails every time it runs. PR CI skipped the web-tests and gallery lanes, which is why the PR is green. Fix: invert that check to assert the count is absent, and update the entry's note ("the footer shows only a compact count").

The component change itself is correct, and the 6 tests in access-chip-pending-warning.test.tsx pass. Nit: the .acpmux-access-grant-count rule in composerLocation.css:297 is now dead CSS.

blacksmith-sh · 2026-10-18T12:12:43Z

Found 10 test failures on Blacksmith runners:

Failures

Test	View Logs
`/tmp/tmpvpbmvekx/summary-fail.json (live):/summary-fail.json (live):`	View Logs
`/tmp/tmpxshphuw8/summary-missing.json (live):/summary-missing.json (live):`	View Logs
`test/agent-pane-mode-keys.test.ts/agent-pane-mode-keys.test`	View Logs
`test/agent-pane-mode-keys.test.ts/agent-pane-mode-keys.test`	View Logs
`test/check-system-blue.test.ts/check-system-blue.test`	View Logs
`test/check-system-blue.test.ts/check-system-blue.test`	View Logs
`test/composer-footer-plain.test.ts/composer-footer-plain.test`	View Logs
`test/composer-footer-plain.test.ts/composer-footer-plain.test`	View Logs
`test/theme-colors.test.ts/theme-colors.test`	View Logs
`test/theme-colors.test.ts/theme-colors.test`	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

github-actions · 2026-10-18T12:13:16Z

red: web / Web status; do not merge until green; see lane-rules
red: web / react-apps-check; do not merge until green; see lane-rules
red: web / react-apps-check (1); do not merge until green; see lane-rules
red: web / react-apps-check (2); do not merge until green; see lane-rules

github-actions · 2026-10-18T12:13:36Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review f03bb1b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr21575 -f ref=codex/composer-access-pill -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check (2) failed: no known signature; failed step: Check diff viewer eager JS budget. This PR merged before its CI finished: fix forward on main.

CI failed on f03bb1b2bf (run 39315463204 attempt 1): 3 unknown.

Job	Verdict	Why
web / react-apps-check (2)	unknown	no known signature; failed step: `Check diff viewer eager JS budget`
web / react-apps-check (1)	unknown	no known signature; failed step: `Check diff viewer eager JS budget`
web / react-apps-check	unknown	no known signature; failed step: `Check webview test shards`

Not re-run automatically: web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

CI fast guards failed on 626479a446 (https://github.com/manaflow-ai/cmux/actions/runs/39219484329). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

github-actions · 2026-10-18T12:14:18Z

CI fast guards passes on a39ea1b740 (https://github.com/manaflow-ai/cmux/actions/runs/39202521521). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

…resh

…play check The accessGrants play still required .acpmux-access-grant-count on the Mode trigger, which this PR removed; it now asserts the trigger shows no count. The .acpmux-access-grant-count CSS rule had no element left to style. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…ser-access-pill

- regenerated Packages/macOS/CmuxNext/ci-target-graph.json - vp fmt webviews/src/agent-session/acpmux/replyHref.ts - vp fmt webviews/src/pages/markdown/README.md - vp fmt webviews/src/pages/markdown/links.ts - vp fmt webviews/test/markdown-cmux-app-links.test.ts Autofix-Run: https://github.com/manaflow-ai/cmux/actions/runs/39211834367

…8099 # Conflicts: # webviews/src/agent-session/acpmux/replyHref.ts # webviews/src/pages/markdown/links.ts

teamleaderleo · 2026-10-19T19:42:37Z

Merging at f03bb1b. It merges feat-cmux-next 4bc289e and resolves the render() helper conflict in access-chip-pending-warning.test.tsx by keeping both permissionAccess and base's holdsModePick. At f03bb1b, bun test ./test/access-chip-pending-warning.test.tsx passes 9/9 on Huge Blue. The blocking review finding (the access-grants gallery play required the count) is fixed in a39ea1b: the play now asserts there is no count, and the dead .acpmux-access-grant-count CSS is removed.

The remaining reds are inherited from feat-cmux-next. This PR changes only 4 webviews files.

cmux-next checks: the only failing check is Motion tokens, at Sources/CmuxNextTabs/TabCell+HibernationRing.swift:109 (CAMediaTimingFunction(name: .easeIn)). That line is on feat-cmux-next 4bc289e, from c9df8bf.
web / react-apps-check: vp check exits 1 on feat-cmux-next 6c4456b. Run locally, it reports a formatting issue in src/pages/settings/icons.tsx, and once that is formatted, 3 lint warnings, which still exit 1. None of the flagged files are in this PR.

…ser-access-pill # Conflicts: # webviews/test/access-chip-pending-warning.test.tsx

cursor · 2026-10-19T19:58:57Z

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

greptile-apps · 2026-10-19T20:02:30Z

Confidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Removes the grant count from the Agent Chat access pill.

The access pill shows its mode without a grant count.

Review was based on code inspection. Tests and visual checks were not run.

_{Reviews (1) · Last reviewed commit: "Merge remote-tracking branch 'origin/fea..." · Reviewed by Greptile}

github-actions · 2026-10-19T22:10:07Z

Shipped in:

cmux NEXT nightly 1.0.0-nightly.3932202374401 (9a68cd147c)
cmux NEXT nightly 1.0.0-nightly.3932896939801 (d9cd7134d3)
cmux NEXT nightly 1.0.0-nightly.3932981759301 (1ab289a4c2)

teamleaderleo force-pushed the codex/composer-access-pill branch from 0e6ae81 to dab1033 Compare October 18, 2026 10:48

teamleaderleo added 2 commits October 18, 2026 03:50

test(composer): cover access pill grant count

2c6a0cc

fix(composer): hide access grant count from pill

47d8762

teamleaderleo force-pushed the codex/composer-access-pill branch from dab1033 to 47d8762 Compare October 18, 2026 10:50

test(composer): cover access grant menu details

3ac9e3c

teamleaderleo mentioned this pull request Oct 18, 2026

fix(cmux-next): restore composer row rhythm and open-chip wash (base red since #21574) #21645

Merged

teamleaderleo and others added 3 commits October 19, 2026 04:51

Merge remote-tracking branch 'origin/feat-cmux-next' into pr21575-ref…

7597f22

…resh

Merge remote-tracking branch 'origin/feat-cmux-next' into codex/compo…

bb4ca26

…ser-access-pill

teamleaderleo requested a review from lawrencecchen as a code owner October 19, 2026 06:46

teamleaderleo temporarily deployed to cmux-tui-merge-tree October 19, 2026 06:46 — with GitHub Actions Inactive

manaflow-cmux-pr-autofix Bot temporarily deployed to cmux-tui-merge-tree October 19, 2026 07:14 Inactive

Merge remote-tracking branch 'origin/feat-cmux-next' into rm21575-175…

626479a

…8099 # Conflicts: # webviews/src/agent-session/acpmux/replyHref.ts # webviews/src/pages/markdown/links.ts

Merge remote-tracking branch 'origin/feat-cmux-next' into codex/compo…

f03bb1b

…ser-access-pill # Conflicts: # webviews/test/access-chip-pending-warning.test.tsx

teamleaderleo merged commit 7e5d0b1 into feat-cmux-next Oct 19, 2026

teamleaderleo deleted the codex/composer-access-pill branch October 19, 2026 19:59

Conversation

teamleaderleo commented Oct 18, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Changelog

Proof

Checklist

Summary by cubic

Uh oh!

coderabbitai Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

teamleaderleo commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 18, 2026

Uh oh!

cursor Bot commented Oct 18, 2026

Bugbot needs on-demand usage enabled

Uh oh!

teamleaderleo commented Oct 18, 2026

Uh oh!

blacksmith-sh Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failures

Uh oh!

github-actions Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Oct 19, 2026

Bugbot needs on-demand usage enabled

Uh oh!

greptile-apps Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

github-actions Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 18, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Oct 18, 2026 •

edited

Loading

teamleaderleo commented Oct 18, 2026 •

edited

Loading

blacksmith-sh Bot commented Oct 18, 2026 •

edited

Loading

github-actions Bot commented Oct 18, 2026 •

edited

Loading

github-actions Bot commented Oct 18, 2026 •

edited

Loading

github-actions Bot commented Oct 18, 2026 •

edited

Loading

teamleaderleo commented Oct 19, 2026 •

edited

Loading

greptile-apps Bot commented Oct 19, 2026 •

edited

Loading

github-actions Bot commented Oct 19, 2026 •

edited

Loading