Skip to content

fix(setup): install hooks before toolchain checks - #21450

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/auto-install-worktree-hooks
Oct 18, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/auto-install-worktree-hooks

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Changelog

  • Fixed setup so clone-local formatting hooks install before toolchain and submodule checks.

Previously a first setup failure (missing Xcode, Metal, Rust, or Ghostty prerequisites) exited before installing hooks, leaving every worktree in the clone without the formatter guard. Hook installation is now the first setup action, so failures cannot leave an unguarded checkout.

Validation: git diff --check; shell flow reviewed.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes setup so clone-local formatting hooks install before toolchain and submodule checks.

Previously, a failed first setup (missing Xcode, Metal, Rust, or Ghostty prerequisites) exited before hook installation, leaving every worktree in the clone without the formatter guard. Hook installation now runs first, so a setup failure can't leave an unguarded checkout.

Written for commit 0f98270. Summary will update on new commits.

View guided diff Turn on auto-fix

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c0ae4320-ab0f-47f9-b214-cc37d18723d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-invmj created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit 89f99b8 into feat-cmux-next Oct 18, 2026
73 checks passed
@teamleaderleo
teamleaderleo deleted the fix/auto-install-worktree-hooks branch October 18, 2026 04:07
@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39096093835 at b246059 failed: cmux app scheme compile (Debug), cmux-next Release compile (Xcode 26).
Those jobs last passed at fde94c5. This pull request is one of 5 merged since: #21383, #21446, #21384, #21450, #21442.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant