Skip to content

Gallery: make current-composer handoff fast and shareable - #21442

Merged
teamleaderleo merged 28 commits into
feat-cmux-nextfrom
leo/current-composer-visual-20261017
Oct 18, 2026
Merged

teamleaderleo merged 28 commits into
feat-cmux-nextfrom
leo/current-composer-visual-20261017

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add a usable, exact-head gallery handoff for the current composer fixture.

Changelog

  • Added permalink, copy-link, and Team feed actions to the gallery shell.
  • Resolve direct gallery routes as soon as the named lazy entry loads.
  • Keep gallery chrome aligned with the selected app theme.
  • Record the verified live feed route and managed preview receipt.

Proof


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Makes gallery handoff of the current-composer fixture faster and shareable: permalinks, copy-link, and Team feed actions are now in the shell, and named deep-link routes resolve as soon as that entry loads instead of waiting for the whole registry.

  • Adds the current-composer visual-only variant for the New Tab surface, with seeded quiet chat rows and a check that no Release journey rows appear.
  • Adds waitFor(id) to the entry store so deep links render immediately; remaining entries still load in the background.
  • Makes the gallery chrome follow the selected app theme, and labels every preview as either a component surface or a window-pane view with rendered dimensions.
  • Shows each fixture's purpose note on browse cards.
  • Records the fixture mandate, acceptance criteria, and managed receipt hashes in plans/cmux-next/evidence/current-composer-visual-20261017.md.

Written for commit 6b2ba8c. Summary will update on new commits.

View guided diff Turn on auto-fix

…hell.css /Users/leoli/Projects/cmux-next-dev/webviews/src/gallery/shell/shell.css
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Visual review: HQ feed · workflow run

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e8afdb91-0cb6-4a78-a78a-9668cd1af5c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

all web/size checks green

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Passes: CI passes on 6b2ba8c37e.

CI passes on 6b2ba8c37e (run 39094827510 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

CI fast guards passes on 6b2ba8c37e (https://github.com/manaflow-ai/cmux/actions/runs/39094827510). This covers only the fast guards, not CI: CI's result is the ci-status check, and the CI failure attribution comment names any failing test.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-t635c created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit b246059 into feat-cmux-next Oct 18, 2026
103 checks passed
@teamleaderleo
teamleaderleo deleted the leo/current-composer-visual-20261017 branch October 18, 2026 04:09
@github-actions

Copy link
Copy Markdown
Contributor

cmux-next tour of 6b2ba8c37e09d4368815a5e36cd51926baa15acc (run)

The tour job failed before the tour ran (build or setup); the run log has the output.

The tour produced no media.

Tours are data in scripts/cmux-next/media/tours: add a step or a tour file to show your feature.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39096093835 at b246059 failed: cmux app scheme compile (Debug), cmux-next Release compile (Xcode 26).
Those jobs last passed at fde94c5. This pull request is one of 5 merged since: #21383, #21446, #21384, #21450, #21442.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant